[xwiki-devs] [VOTE] Move filesystem attachment storage into the core.

Caleb James DeLisle calebdelisle at lavabit.com
Fri Jan 28 17:33:35 CET 2011


I would like to move the attachment storage code into the trunk for testing and inclusion in 3.0.
I would like to put it in /core/xwiki-store/ which can begin the modularization of the storage engine.

The filesystem attachment storage is still a work in progress but the main attachment storage class
runs. I have added a new type of lock which automatically breaks deadlock and might solve the
problem with deletion sometimes blocking.

This code depends on and includes:
TransactionRunnable which will allow us to evaluate TR in real life situations.
Serialization apis for including a refactoring of the existing XMLWriter.
File save/delete TransactionRunnables which serve as primitives for safe file saving and deletion on
the filesystem.
Lock manager which is still brand new and has to be moved into it's own package yet.
An EntityReferenceSerializer for getting file paths from document names.

This code provides:
FilesystemAttachmentStore which is beta and functional.
FilesystemAttachmentVersioningStore which is alpha and "you're on your own".
along with compatible FilesystemAttachmentContent and ListAttachmentArchive.

Here is my +1 for including this in the core so it can be developed and tested in concert.

Caleb



More information about the devs mailing list