[xwiki-commits] r1329 - xwiki/trunk/src/main/java/com/xpn/xwiki/render/filter

[jeremi joslin]

Hi Nam,
Can you use a StringBuffer instead of a String for creating the link,
StringBuffer has better performance, see
http://java.sun.com/developer/JDCTechTips/2002/tt0305.html

Can you also put the css in the skin instead of in the code.

thanks,
jeremi

On 9/20/06, Phung Hai Nam <namphunghai at users.forge.objectweb.org> wrote:
> Author: namphunghai
> Date: 2006-09-20 04:44:42 +0200 (Wed, 20 Sep 2006)
> New Revision: 1329
>
> Modified:
>    xwiki/trunk/src/main/java/com/xpn/xwiki/render/filter/XWikiHeadingFilter.java
> Log:
> XWIKI-356. Fixed  a bug with multilingual  in section editing
>
> Modified: xwiki/trunk/src/main/java/com/xpn/xwiki/render/filter/XWikiHeadingFilter.java
> ===================================================================
> --- xwiki/trunk/src/main/java/com/xpn/xwiki/render/filter/XWikiHeadingFilter.java       2006-09-19 20:04:26 UTC (rev 1328)
> +++ xwiki/trunk/src/main/java/com/xpn/xwiki/render/filter/XWikiHeadingFilter.java       2006-09-20 02:44:42 UTC (rev 1329)
> @@ -23,6 +23,7 @@
>  package com.xpn.xwiki.render.filter;
>
>  import com.xpn.xwiki.XWikiContext;
> +import com.xpn.xwiki.XWikiException;
>  import com.xpn.xwiki.doc.XWikiDocument;
>  import com.xpn.xwiki.render.XWikiRadeoxRenderEngine;
>  import com.xpn.xwiki.util.TOCGenerator;
> @@ -130,12 +131,20 @@
>              if (level.equals("1") || level.equals("1.1") ) {
>                  if(doc.getContent().indexOf(title.trim()) != -1) {
>                      sectionNumber++;
> -                    String url = xcontext.getDoc().getURL("edit",xcontext);
> -                    if(xcontext.getWiki().getEditorPreference(xcontext).equals("wysiwyg")) {
> -                        url += "?xpage=wysiwyg&section=" + sectionNumber;
> -                    } else {
> -                        url +="?section=" + sectionNumber;
> -                    }
> +                    String editparams = "";
> +                    if (xcontext.getWiki().getEditorPreference(xcontext).equals("wysiwyg"))
> +                        editparams += "xpage=wysiwyg&section=" + sectionNumber;
> +                    else
> +                        editparams += "section=" + sectionNumber;
> +                    try {
> +                        if ((xcontext.getWiki().isMultiLingual(xcontext)) && (doc.getRealLanguage(xcontext) != null)) {
> +                             String languageParam = "language=" + doc.getRealLanguage(xcontext);
> +                            editparams = languageParam + "&" + editparams;
> +                        }
> +                    } catch (XWikiException e) { }
> +
> +                    String url = doc.getURL("edit", editparams, xcontext);
> +
>                      return heading + "<span style='float:right;margin-left:5px;margin-right:5px;'>&#91;<a style='text-decoration: none;' title='Edit section: "+text+"' href='"+ url+"'>"+"edit"+"</a>&#93;</span>";
>                  }
>              }
>
>
>
>
>
> --
> You receive this message as a subscriber of the xwiki-commits at objectweb.org mailing list.
> To unsubscribe: mailto:xwiki-commits-unsubscribe at objectweb.org
> For general help: mailto:sympa at objectweb.org?subject=help
> ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
>
>
>


-- 
jeremi