[xwiki-notifications] [Issue] Commented: (XWIKI-2529) Impossible to overload macros.vm

[Vincent Massol (JIRA)]

    [ http://jira.xwiki.org/jira/browse/XWIKI-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=27636#action_27636 ] 

Vincent Massol commented on XWIKI-2529:
---------------------------------------

Well right now we do support macros.vm in skins but only on the filesystem. The reason for supporting this is to allow skins to define macros used in their template files for example. In general a macro is supposed to be shared and is independent of the skin so Sergiu is right, these should go in the XWikiPreferences (which doesn't work right now).

However since we support macros.vm in skin on the filesystem it makes sense to also support them in skins defined in XWikiSkins objects.

So I'd be +1 to support the request right now + of course add support for global macros defined in XWikiPreferences. For both use cases we need to use notifications to be notified when the document changes and recreate a Velocity Engine whenever this happens.


> Impossible to overload macros.vm
> --------------------------------
>
>                 Key: XWIKI-2529
>                 URL: http://jira.xwiki.org/jira/browse/XWIKI-2529
>             Project: XWiki Core
>          Issue Type: Bug
>          Components: Macros & Filters, Templates & User Interface
>    Affects Versions: 1.3.2, 1.4.1, 1.5 M2
>         Environment: Tested on the XWiki Profarm (1.3.2), on 1.4.1 (standalone) & 1.5M2 (standalone)
>            Reporter: eveilleau thomas
>            Priority: Critical
>
> It's impossible to overload macros.vm by :
> - adding the "macros.vm" field in the XWiki.XWikiSkins class 
> - changing things in the "macros.vm" field of the XWikiSkins object used for the wiki skin
> - saving it
> The only solution i actually see is directly modify the macros.vm file (but having to change things in the file system is not a good workaround).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira