[xwiki-notifications] [Issue] Commented: (XWIKI-2006) Allows to configurate name of database schema

[Thomas Mortagne (JIRA)]

    [ http://jira.xwiki.org/jira/browse/XWIKI-2006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=27641#action_27641 ] 

Thomas Mortagne commented on XWIKI-2006:
----------------------------------------

Some comment:
- why apply "prefix" only in virtual mode ? The problem is that if there is any prefix configured it's difficult to switch from virtual and non-virtual mode. You could call it xwiki.db.prefix and apply it even in non-virtual mode.
- you should add a method taking the DatabaseProduct as parameter used by both getSchemaFromWikiName and initHibernate to have the name transformation at only one place.

Except for that, this is a very good patch.
I can take care of the two comments myself and add some unit/integration tests if it's ok for you (you already done lot of work ;)).

> Allows to configurate name of database schema
> ---------------------------------------------
>
>                 Key: XWIKI-2006
>                 URL: http://jira.xwiki.org/jira/browse/XWIKI-2006
>             Project: XWiki Core
>          Issue Type: Improvement
>          Components: Storage
>    Affects Versions: 1.5 M1
>         Environment: any
>            Reporter: Ruslan Shevchenko
>            Assignee: Thomas Mortagne
>            Priority: Minor
>             Fix For: 1.6 M1
>
>         Attachments: configurated_db_schema_02.patch, configurated_db_schema_03.patch, configurated_db_schema_04.patch, configurated_db_schema_05.patch, configurated_db_schema_06.patch, configurated_db_schema_07.patch, configurated_db_schema_08.patch, testplan.notes.txt
>
>
> attached path allows to configure
> 1. name of database schema of main wiki.
> 2. prefixes for database schemas for virtual wikis.
> (tested by hand with normal and virtual wiki configurations)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira