[xwiki-notifications] [Issue] Commented: (XPWATCHLIST-26) Only redraw watchlist menu instead of entire menu when enabling/disabling a space/page.

[Jean-Vincent Drean (JIRA)]

    [ http://jira.xwiki.org/jira/browse/XPWATCHLIST-26?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=27734#action_27734 ] 

Jean-Vincent Drean commented on XPWATCHLIST-26:
-----------------------------------------------

Hi Rob,
We try not to increase the number of templates so I'm a bit reluctant to create a new one for this. About your use case I think you could put the Event.observe inside menuview.vm, wdyt ? 

> Only redraw watchlist menu instead of entire menu  when enabling/disabling a space/page.
> ----------------------------------------------------------------------------------------
>
>                 Key: XPWATCHLIST-26
>                 URL: http://jira.xwiki.org/jira/browse/XPWATCHLIST-26
>             Project: XWiki Watch List Application
>          Issue Type: Improvement
>          Components: Application
>    Affects Versions: 1.3, 1.4, 1.5
>            Reporter: Rob
>         Attachments: XPWATCHLIST-25.patch
>
>
> If somebody were to use prototype Event.observe on certain menu actions, after choosing to watch/unwatch a space/page and re-drawing the entire menu (menuview.vm) the listeners would be lost. For example, I implemented "send page by email" in a lightbox which was hidden on page load. I used prototype to listen for a click on an 'email page' button on the print menu. When the entire menu is redrawn, the listener/s are broken, which is why I'm only redrawing the watch section of the main menu. It also slightly saves bandwidth. That is why I created a separate template to be used for drawing the watchlist section of the menu. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.xwiki.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira