- notifications - lists.xwiki.org

[xwiki/xwiki-platform] 9d1a34: XWIKI-22121: Improve the registration experience

by XWiki Notifications

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 9d1a34f7974cff7ef2fa0ba0aea4f152a16ef831 https://github.com/xwiki/xwiki-platform/commit/9d1a34f7974cff7ef2fa0ba0aea4… Author: Sereza7 <lucas.charpentier(a)xwiki.com> Date: 2024-11-13 (Wed, 13 Nov 2024) Changed paths: M xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-pageobjects/src/main/java/org/xwiki/administration/test/po/TemplatesAdministrationSectionPage.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-profile/xwiki-platform-user-profile-test/xwiki-platform-user-profile-test-pageobjects/src/main/java/org/xwiki/user/test/po/ChangePasswordPage.java Log Message: ----------- XWIKI-22121: Improve the registration experience * Added a wait on the changePasswordAsAdmin so that the validator used up to date info about the fields (when leaving the field, validation on the field is done. Once this individual validation is done, we add a class on the field to show its current status. We wait for this status, and then the form validation will have all the individual field validations updated). This fixes changePasswordWhenPolicyIsLength8AndNumberMandatory . * Updated the wait condition when validating the form for a new template. With the new validation script, we do not show a message for some fields when it's just `ok`. Instead of checking the number of valid fields, we check that there's one validation (since there's still one as of now) and no invalid field. I kept the waitCondition as close as possible to what was before. It could probably be improved but I went with the safer changes. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

10 months

1
0
0 0

[xwiki/xwiki-platform] 60b054: XWIKI-12987: Relative links are made absolute or e...

by XWiki Notifications

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 60b054243cdb734718ec0e3e704658c969c73dc3 https://github.com/xwiki/xwiki-platform/commit/60b054243cdb734718ec0e3e7046… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-11-13 (Wed, 13 Nov 2024) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java Log Message: ----------- XWIKI-12987: Relative links are made absolute or even broken after moving a page * ugly fix of the page reference regression and cover it with integration test To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

10 months

1
0
0 0

[jira@xwiki.org][Issue] Updates for XWIKI-22653: Don't render log items if they are not displayed

by XWiki Notifications

10 months

1
0
0 0

[xwiki-contrib/cristal] 54e5c9: Added translation using Weblate (German)

by XWiki Notifications

Branch: refs/heads/main Home: https://github.com/xwiki-contrib/cristal Commit: 54e5c9a16d8f593fb3f48dce2c453e45b2de56f0 https://github.com/xwiki-contrib/cristal/commit/54e5c9a16d8f593fb3f48dce2c4… Author: Simpel <git(a)simpel.cc> Date: 2024-11-13 (Wed, 13 Nov 2024) Changed paths: A core/authentication/authentication-ui/langs/translation-de.json Log Message: ----------- Added translation using Weblate (German) Commit: ca89fa3392b69c22da9815a7f214e5d88190a4d9 https://github.com/xwiki-contrib/cristal/commit/ca89fa3392b69c22da9815a7f21… Author: Simpel <git(a)simpel.cc> Date: 2024-11-13 (Wed, 13 Nov 2024) Changed paths: M core/authentication/authentication-ui/langs/translation-de.json Log Message: ----------- Translated using Weblate (German) Currently translated at 100.0% (4 of 4 strings) Translation: XWiki Contrib/cristal - authentication-ui Translate-URL: https://l10n.xwiki.org/projects/xwiki-contrib/cristal/cristal-authenticatio… Commit: fdef32218f17521e6341201ed93f50ec24db919b https://github.com/xwiki-contrib/cristal/commit/fdef32218f17521e6341201ed93… Author: Simpel <git(a)simpel.cc> Date: 2024-11-13 (Wed, 13 Nov 2024) Changed paths: M core/authentication/authentication-ui/langs/translation-de.json Log Message: ----------- Translated using Weblate (German) Currently translated at 100.0% (5 of 5 strings) Translation: XWiki Contrib/cristal - authentication-ui Translate-URL: https://l10n.xwiki.org/projects/xwiki-contrib/cristal/cristal-authenticatio… Commit: 07ded47695430525e11a4f06d65681d514fd4772 https://github.com/xwiki-contrib/cristal/commit/07ded47695430525e11a4f06d65… Author: Simpel <git(a)simpel.cc> Date: 2024-11-13 (Wed, 13 Nov 2024) Changed paths: A core/page-actions/page-actions-ui/langs/translation-de.json Log Message: ----------- Added translation using Weblate (German) Commit: 1cde8374b49804e854ef8b634f532c046f6ce363 https://github.com/xwiki-contrib/cristal/commit/1cde8374b49804e854ef8b634f5… Author: Simpel <git(a)simpel.cc> Date: 2024-11-13 (Wed, 13 Nov 2024) Changed paths: M core/page-actions/page-actions-ui/langs/translation-de.json Log Message: ----------- Translated using Weblate (German) Currently translated at 100.0% (6 of 6 strings) Translation: XWiki Contrib/cristal - page-actions-ui Translate-URL: https://l10n.xwiki.org/projects/xwiki-contrib/cristal/cristal-page-actions-… Commit: 3c6bde8f6b68207c9e3803933acb87aba6d7388d https://github.com/xwiki-contrib/cristal/commit/3c6bde8f6b68207c9e3803933ac… Author: 一颗小土豆 <2428100619(a)qq.com> Date: 2024-11-13 (Wed, 13 Nov 2024) Changed paths: A core/attachments/attachments-ui/langs/translation-zh.json Log Message: ----------- Added translation using Weblate (Chinese (Simplified) (zh)) Commit: 9419f13525dcc9dae45a80ead23f25ac206b9f2e https://github.com/xwiki-contrib/cristal/commit/9419f13525dcc9dae45a80ead23… Author: 一颗小土豆 <2428100619(a)qq.com> Date: 2024-11-13 (Wed, 13 Nov 2024) Changed paths: M core/attachments/attachments-ui/langs/translation-zh.json Log Message: ----------- Translated using Weblate (Chinese (Simplified) (zh)) Currently translated at 100.0% (5 of 5 strings) Translation: XWiki Contrib/cristal - attachments-ui Translate-URL: https://l10n.xwiki.org/projects/xwiki-contrib/cristal/cristal-attachments-u… Commit: ed63844e866d0f927809bbe3ed1e5ba65f9322b1 https://github.com/xwiki-contrib/cristal/commit/ed63844e866d0f927809bbe3ed1… Author: Manuel Leduc <manuel.leduc(a)xwiki.com> Date: 2024-11-13 (Wed, 13 Nov 2024) Changed paths: A core/attachments/attachments-ui/langs/translation-zh.json A core/authentication/authentication-ui/langs/translation-de.json A core/page-actions/page-actions-ui/langs/translation-de.json Log Message: ----------- Merge pull request #389 from xwikiorgci/weblate-xwiki-contrib-cristal-skin Translations update from Weblate Compare: https://github.com/xwiki-contrib/cristal/compare/398996542df1...ed63844e866d To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/cristal/settings/notifications

10 months

1
0
0 0

[jira@xwiki.org][Issue] Updates for CRISTAL-293: Support history for Nextcloud backend

by XWiki Notifications

10 months

1
0
0 0

[jira@xwiki.org][Issue] Updates for XWIKI-22617: On a sub-wiki, we cannot use a Skin from another wiki or from filesystem anymore

by XWiki Notifications

10 months

1
0
0 0

[jira@xwiki.org][Issue] Updates for XWIKI-22284: Re-joining a Realtime editing session discards unsaved changes

by XWiki Notifications

10 months

1
0
0 0

[jira@xwiki.org][Issue] Updates for XWIKI-20712: The side box used by the Encyclopedia template appears after the content when exporting to PDF

by XWiki Notifications

10 months

1
0
0 0

[jira@xwiki.org][Issue] Updates for XWIKI-22612: Can't use inline style without selecting the text first

by XWiki Notifications

10 months

1
0
0 0

[jira@xwiki.org][Issue] Updates for XWIKI-21595: Remove the "Replace FOP" configuration option from the PDF Export administration section

by XWiki Notifications

10 months

1
0
0 0

[jira@xwiki.org][Issue] Updates for XWIKI-22409: Add automated test for "Show Page Information Tab (No)"

by XWiki Notifications

10 months

1
0
0 0

[xwiki-contrib/cristal] 398996: [Misc] Improve contentTools.ts tsdoc

by XWiki Notifications

Branch: refs/heads/main Home: https://github.com/xwiki-contrib/cristal Commit: 398996542df122aa5b4e95d735839716b8c10b8b https://github.com/xwiki-contrib/cristal/commit/398996542df122aa5b4e95d7358… Author: Manuel Leduc <manuel.leduc(a)xwiki.com> Date: 2024-11-13 (Wed, 13 Nov 2024) Changed paths: M skin/src/vue/contentTools.ts Log Message: ----------- [Misc] Improve contentTools.ts tsdoc To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/cristal/settings/notifications

10 months

1
0
0 0

[jira@xwiki.org][Issue] Updates for XWIKI-22592: Upgrade to Testcontainers 1.20.3

by XWiki Notifications

10 months

1
0
0 0

[xwiki/xwiki-platform]

by XWiki Notifications

Branch: refs/heads/backport-3639-to-stable-15.10.x Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

10 months

1
0
0 0

[xwiki/xwiki-platform] 40cae0: Translated using Weblate (Chinese (Simplified) (zh))

by XWiki Notifications

Branch: refs/heads/stable-15.10.x Home: https://github.com/xwiki/xwiki-platform Commit: 40cae0fd3522a83cf3aed730d8e4e3d406116ddd https://github.com/xwiki/xwiki-platform/commit/40cae0fd3522a83cf3aed730d8e4… Author: 一颗小土豆 <2428100619(a)qq.com> Date: 2024-11-13 (Wed, 13 Nov 2024) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/resources/ApplicationResources_zh.properties Log Message: ----------- Translated using Weblate (Chinese (Simplified) (zh)) Currently translated at 80.2% (3606 of 4492 strings) Translation: XWiki Platform/XWiki Core Resources Translate-URL: https://l10n.xwiki.org/projects/xwiki-platform/xwiki-core-resources/zh/ (cherry picked from commit 688e83ee9f4b1c3554ed73c8f9d91ea286a14a7b) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

10 months

1
0
0 0

[xwiki/xwiki-platform] c9598a: Translated using Weblate (Chinese (Simplified) (zh))

by XWiki Notifications

Branch: refs/heads/backport-3639-to-stable-15.10.x Home: https://github.com/xwiki/xwiki-platform Commit: c9598ab3779ad3b69db790765d11d5dae4a0e880 https://github.com/xwiki/xwiki-platform/commit/c9598ab3779ad3b69db790765d11… Author: 一颗小土豆 <2428100619(a)qq.com> Date: 2024-11-13 (Wed, 13 Nov 2024) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/resources/ApplicationResources_zh.properties Log Message: ----------- Translated using Weblate (Chinese (Simplified) (zh)) Currently translated at 80.2% (3606 of 4492 strings) Translation: XWiki Platform/XWiki Core Resources Translate-URL: https://l10n.xwiki.org/projects/xwiki-platform/xwiki-core-resources/zh/ (cherry picked from commit 688e83ee9f4b1c3554ed73c8f9d91ea286a14a7b) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

10 months

1
0
0 0

[xwiki/xwiki-platform] 688e83: Translated using Weblate (Chinese (Simplified) (zh))

by XWiki Notifications

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 688e83ee9f4b1c3554ed73c8f9d91ea286a14a7b https://github.com/xwiki/xwiki-platform/commit/688e83ee9f4b1c3554ed73c8f9d9… Author: 一颗小土豆 <2428100619(a)qq.com> Date: 2024-11-13 (Wed, 13 Nov 2024) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/resources/ApplicationResources_zh.properties Log Message: ----------- Translated using Weblate (Chinese (Simplified) (zh)) Currently translated at 80.2% (3606 of 4492 strings) Translation: XWiki Platform/XWiki Core Resources Translate-URL: https://l10n.xwiki.org/projects/xwiki-platform/xwiki-core-resources/zh/ To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

10 months

1
0
0 0

[jira@xwiki.org][Issue] Updates for XWIKI-22644: Not all images are showing in the Pdf export

by XWiki Notifications

10 months

1
0
0 0

[jira@xwiki.org][Issue] Updates for XWIKI-12987: Relative links are made absolute or even broken after moving a page

by XWiki Notifications

10 months

1
0
0 0

[xwiki/xwiki-platform]

by XWiki Notifications

Branch: refs/heads/feature-deploy-refactor-links Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

10 months

1
0
0 0

[xwiki/xwiki-platform] fc01c1: XWIKI-12987: Relative links are made absolute or e...

by XWiki Notifications

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: fc01c140169d8f1f39eeb98435639ec28bd56f4c https://github.com/xwiki/xwiki-platform/commit/fc01c140169d8f1f39eeb9843563… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-11-13 (Wed, 13 Nov 2024) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/render/DefaultOldRendering.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/XWikiTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/checkstyle/checkstyle-suppressions.xml M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/ReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/ReferenceUpdater.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractCopyOrMoveJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractEntityJobWithChecks.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/CopyJob.java A xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/InternalCopyOrMoveJobException.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/MoveJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/RenameJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListener.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/job/question/EntitySelection.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/job/MoveJobTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/job/RenameJobTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListenerTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultMacroRefactoring.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceUpdater.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultMacroRefactoringTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultModelBridgeTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultReferenceUpdaterTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/ResourceReferenceRenamerTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoring.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/test/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoringTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/macro/MacroRefactoring.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-test/xwiki-platform-wiki-test-docker/src/test/it/org/xwiki/wiki/test/ui/SubWikiIT.java Log Message: ----------- XWIKI-12987: Relative links are made absolute or even broken after moving a page (#3634) The idea of this work is to: * Change the way AbstractCopyOrMoveJob works to perform computation of couple source/target documents before processing them * Provide a way to access that map source/target documents * Use that information when performing a call to ReferenceRenamer to define if a relative untyped link should be handled or not The PR provides mainly: - new APIs in ReferenceRenamer and MacroRefactoring to integrate the map of references that have been moved as part of same job - refactorings of AbstractCopyOrMoveJob: * specific computation of getEntities to actually visit the hierarchy and populate the entities with the couple of source/target documents * new abstract methods to avoid duplications (not strictly needed for this work) * new method to retrieve the map of source/target documents - new conditions in ResourceReferenceRenamer to decide if a link should be renamed or not: most of the logic of the fix is encoded there (see also clarifications) - new calls in XWiki#updateLinksForRename and BackLinkUpdaterListener#updateBackLinks to give the map of source/target when calling the rename of references - new integration test simulating the scenario indicated in the ticket and also performing a supplementary check related to a regression found afterwards - same integration test also performed on a subwiki in SubWikiIT The refactoring of references is currently called at two places: by the BackLinkUpdaterListener for all backlinks after a document has been renamed (triggered by a document event) by XWiki#updateLinksForRename to rename the internal links of the current document (which is always a call to updateResourceReferenceRelative, see below) The problem of XWIKI-12987 is that XWiki#updateLinksForRename is called first and does perform an absolute rename of the relative links. Now ResourceReferenceRenamer APIs names might be misleading: updateResourceReferenceRelative and updateResourceReferenceAbsolute are not about the references being absolute or relative: it's about the renamed references being absolute or relative respectively to the current document. It took me a while to integrate this, and I'm still struggling a bit with it. So the problem was to find a proper condition to decide when to not refactor links, for this I'm performing a check for assessing if a link is absolute or not, by trying to resolve the ResourceReference without any parameter: if the result equals the reference with parameter then it was absolute. Then for the updateResourceReferenceAbsolute the idea is to only perform update of the links, if the provided link is absolute, or if it's relative but the current document hasn't been moved as part of same job: in such case we do need to update the relative link, because there won't be a call to XWiki#updateLinksForRename on that document to update the link, we only get the call from BackLinkUpdaterListener. For the updateResourceReferenceRelative the check is a bit more complex. We only update links that are relative here, we don't want to update absolute references (is that correct? Can't find a counter example right now). Then since we only perform refactoring of links relative to current document, we also check that the link about to be refactored is not related to pages that are part of the moved document in the same job: if those are also moved in the same job, then they're moved using same "direction", they're part of same hierarchy and we don't want to change the relative links wrt to them. This check is the main part of avoiding to update the relative links. And finally we perform the update of the link only if the doc actually exists: we would create absolute links for those not existing doc, which doesn't make sense, we should keep the relative link we don't really know what the user wanted to do with those. Note that we could do the same check in updateResourceReferenceAbsolute but we don't really have the need since this is only called from the BackLinkUpdaterListener and if I'm correct we'll never have registered backlinks for a not existing doc. Note that initially we discussed about using untyped link as a condition to perform or not the refactoring: I dropped the idea because we currently always create image resource references as untyped references from the WYSIWYG editor. Note that this work currently includes a known regression when renaming links on the form `page:../SubSpace/Page`, this is going to be handled in further work. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

10 months