October 2024 - notifications

[xwiki/xwiki-platform] de8dfe: XWIKI-12987: Relative links are made absolute or e...
by XWiki Notifications 31 Oct '24

31 Oct '24

Branch: refs/heads/XWIKI-12987 Home: https://github.com/xwiki/xwiki-platform Commit: de8dfed35ea50b779e0f9153f08aa73f4c992c7a https://github.com/xwiki/xwiki-platform/commit/de8dfed35ea50b779e0f9153f08a… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-10-31 (Thu, 31 Oct 2024) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/render/DefaultOldRendering.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/XWikiTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/checkstyle/checkstyle-suppressions.xml M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/ReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/ReferenceUpdater.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractCopyOrMoveJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractEntityJobWithChecks.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/CopyJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/MoveJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListener.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultMacroRefactoring.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceUpdater.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultMacroRefactoringTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultReferenceUpdaterTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/ResourceReferenceRenamerTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/macro/MacroRefactoring.java Log Message: ----------- XWIKI-12987: Relative links are made absolute or even broken after moving a page WIP The idea of this work is to: 1. Provide a way to access all documents that are moved as part of a move job 2. Use that information when performing a call to ReferenceRenamer to define if a relative untyped link should be handled or not On top of it, the idea is also to check if the doc exists in case of refactoring of a link to avoid refactoring unexisting relative links. One problem is remaining about relative link pointing to sibling pages (e.g. the link to Alice in Bob page in the ticket): we rely apparently to an old mechanism for backward compatibility reason for this to work in the UI, we might need same thing in the check, or to decide to ignore that UC. I started to add an integration tests but for some reason it's not passing, though it seemed to be working locally for the scenario described in the ticket (except for the link in Bob page). Commit: d9d5d0f771e8bc1e71e9299185b2a77a9782b598 https://github.com/xwiki/xwiki-platform/commit/d9d5d0f771e8bc1e71e9299185b2… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-10-31 (Thu, 31 Oct 2024) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoring.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/test/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoringTest.java Log Message: ----------- XWIKI-12987: Relative links are made absolute or even broken after moving a page * Fix integration test setup * Fix some signatures * Work on the conditions for performing link update: WIP Commit: 4b6e0ab61ce6b78ca874ad6594657eb63f67c659 https://github.com/xwiki/xwiki-platform/commit/4b6e0ab61ce6b78ca874ad659465… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-10-31 (Thu, 31 Oct 2024) Changed paths: M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java Log Message: ----------- XWIKI-12987: Relative links are made absolute or even broken after moving a page * Fix conditions to make all RenamePageIT passing * WIP: need to double check that some conditions are not redundant and double check side effects Commit: f74c4c535bdb3c88ffcb31b0e937d241d9bba5b6 https://github.com/xwiki/xwiki-platform/commit/f74c4c535bdb3c88ffcb31b0e937… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-10-31 (Thu, 31 Oct 2024) Changed paths: M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListenerTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultReferenceUpdaterTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/ResourceReferenceRenamerTest.java Log Message: ----------- XWIKI-12987: Relative links are made absolute or even broken after moving a page * Simplify a bit the conditions in ResourceReferenceRenamer and ensure all unit tests are passing in refactoring module Commit: 3f16fb6efd7a2411e143d966d951796bd649122a https://github.com/xwiki/xwiki-platform/commit/3f16fb6efd7a2411e143d966d951… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-10-31 (Thu, 31 Oct 2024) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/XWikiTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/ReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/ReferenceUpdater.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractEntityJobWithChecks.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListener.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultMacroRefactoring.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/main/java/org/xwiki/rendering/macro/MacroRefactoring.java Log Message: ----------- XWIKI-12987: Relative links are made absolute or even broken after moving a page * Fix checkstyle * WIP: try to find proper oracle for renaming absolute references, without success so far. Commit: 7fdbb08f4d3a211418673875375fdb829e34671d https://github.com/xwiki/xwiki-platform/commit/7fdbb08f4d3a211418673875375f… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-10-31 (Thu, 31 Oct 2024) Changed paths: M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultReferenceUpdaterTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/ResourceReferenceRenamerTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/main/java/org/xwiki/rendering/internal/macro/include/IncludeMacroRefactoring.java Log Message: ----------- XWIKI-12987: Relative links are made absolute or even broken after moving a page * Find proper conditions to perform or not link renames * Fix unit tests to add missing conditions * WIP: need to fix coverage and check on subwikis / with more conditions (e.g. with holes in hierarchy) Commit: c5904bc49cade122d3352a2dc5489c9ef3ecfee7 https://github.com/xwiki/xwiki-platform/commit/c5904bc49cade122d3352a2dc548… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-10-31 (Thu, 31 Oct 2024) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/ResourceReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultModelBridgeTest.java Log Message: ----------- XWIKI-12987: Relative links are made absolute or even broken after moving a page * Fix a regression and provide a test to cover it Commit: c58c5e668a011b17288b2269e17be74adb6c71a0 https://github.com/xwiki/xwiki-platform/commit/c58c5e668a011b17288b2269e17b… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-10-31 (Thu, 31 Oct 2024) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/RenamePageIT.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-test/xwiki-platform-wiki-test-docker/src/test/it/org/xwiki/wiki/test/ui/SubWikiIT.java Log Message: ----------- XWIKI-12987: Relative links are made absolute or even broken after moving a page * Provide subwiki integration tests * Minor improvment in RenamePageIT Compare: https://github.com/xwiki/xwiki-platform/compare/4b1f9bf36ca3...c58c5e668a01 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-commons] bc70b6: [release] Put back master revapi ignore removed by...
by XWiki Notifications 31 Oct '24

31 Oct '24

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-commons Commit: bc70b689122a9593e2be36848dae3551dd7408e8 https://github.com/xwiki/xwiki-commons/commit/bc70b689122a9593e2be36848dae3… Author: Thomas Mortagne <thomas.mortagne(a)gmail.com> Date: 2024-10-31 (Thu, 31 Oct 2024) Changed paths: M xwiki-commons-core/pom.xml Log Message: ----------- [release] Put back master revapi ignore removed by the 16.9.0 release To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-platform] 9f4ace: XWIKI-21729: Bad interaction between quick search ...
by XWiki Notifications 31 Oct '24

31 Oct '24

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 9f4ace5e68d2450b3b6faea0d68cc77d597a81a1 https://github.com/xwiki/xwiki-platform/commit/9f4ace5e68d2450b3b6faea0d68c… Author: LucasC <lucas.charpentier(a)xwiki.com> Date: 2024-10-31 (Thu, 31 Oct 2024) Changed paths: M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-ui/src/main/resources/XWiki/QuickSearchUIX.xml M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-webjar/src/main/webjar/searchSuggest.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/suggest.js Log Message: ----------- XWIKI-21729: Bad interaction between quick search and the drawer (#2835) * Fired an event that was overwise unused * Fixed its listener * Added an optional argument for the suggest resetTimeout function (to allow a more precise control of the suggest panel) * Added a comment to explain the origin of a hard coded timer. * Improved the JS to retrieve the timing value from the CSS To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 8bfe40: XWIKI-21770: Mention administration radio buttons ...
by XWiki Notifications 31 Oct '24

31 Oct '24

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 8bfe4069665fb16513159e8bd974c39b4f3094ff https://github.com/xwiki/xwiki-platform/commit/8bfe4069665fb16513159e8bd974… Author: LucasC <lucas.charpentier(a)xwiki.com> Date: 2024-10-31 (Thu, 31 Oct 2024) Changed paths: M xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-ui/src/main/resources/XWiki/AdminSheet.xml Log Message: ----------- XWIKI-21770: Mention administration radio buttons are not aligned (#2819) * Separated style for checkbox and radio inputs * Updated vertical align for radio inputs Note: This also fixes a misalign in the rights UI. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[[email protected]][Issue] Updates for XWIKI-22625: TestUtils#getURL doesn't take the wiki into account
by XWiki Notifications 31 Oct '24

31 Oct '24

1 0

[[email protected]][Issue] Updates for XWIKI-21631: Tour generates a bottom scroll-bar, when items are created near the margins
by XWiki Notifications 31 Oct '24

31 Oct '24

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 31 Oct '24

31 Oct '24

Branch: refs/heads/backport-3615-to-stable-16.4.x Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 898dd0: XWIKI-22625: TestUtils#getURL doesn't take the wik...
by XWiki Notifications 31 Oct '24

31 Oct '24

Branch: refs/heads/stable-16.4.x Home: https://github.com/xwiki/xwiki-platform Commit: 898dd04df7ec0deeeab3ac49eee66b32a7b94106 https://github.com/xwiki/xwiki-platform/commit/898dd04df7ec0deeeab3ac49eee6… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-10-31 (Thu, 31 Oct 2024) Changed paths: M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/pom.xml M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/TestUtils.java A xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/test/java/org/xwiki/test/ui/TestUtilsTest.java Log Message: ----------- XWIKI-22625: TestUtils#getURL doesn't take the wiki into account (#3615) * Improve getBaseBinURL so that it fallbacks on currentWiki if this one is provided * Add a new getURL API taking into account the wiki name * Extract the wiki from the entityReference when using getURL with a reference * Fix and cover possible NPE * Move wikiName argument to the beginning to follow the URL scheme * Remove Unstable * minor fix (cherry picked from commit 77c5da6df3e53a517d94423b70d7017b399b5dc6) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 31 Oct '24

31 Oct '24

Branch: refs/heads/backport-3615-to-stable-15.10.x Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 6945df: XWIKI-22625: TestUtils#getURL doesn't take the wik...
by XWiki Notifications 31 Oct '24

31 Oct '24

Branch: refs/heads/stable-15.10.x Home: https://github.com/xwiki/xwiki-platform Commit: 6945df2763d4be7108bd13f468f8592f77875375 https://github.com/xwiki/xwiki-platform/commit/6945df2763d4be7108bd13f468f8… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-10-31 (Thu, 31 Oct 2024) Changed paths: M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/pom.xml M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/TestUtils.java A xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/test/java/org/xwiki/test/ui/TestUtilsTest.java Log Message: ----------- XWIKI-22625: TestUtils#getURL doesn't take the wiki into account (#3615) * Improve getBaseBinURL so that it fallbacks on currentWiki if this one is provided * Add a new getURL API taking into account the wiki name * Extract the wiki from the entityReference when using getURL with a reference * Fix and cover possible NPE * Move wikiName argument to the beginning to follow the URL scheme * Remove Unstable * minor fix (cherry picked from commit 77c5da6df3e53a517d94423b70d7017b399b5dc6) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0