Branch: refs/heads/stable-16.10.x
Home: https://github.com/xwiki/xwiki-commons
Commit: 9a5232ebf2e4d96f581ef1cd166926def82e251e
https://github.com/xwiki/xwiki-commons/commit/9a5232ebf2e4d96f581ef1cd16692…
Author: Michael Hamann <michael.hamann(a)xwiki.com>
Date: 2025-03-20 (Thu, 20 Mar 2025)
Changed paths:
M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/pom.xml
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/AbstractJobStatusFolderResolver.java
M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/DefaultJobStatusStore.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/JobStatusFolderResolver.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/Version1JobStatusFolderResolver.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/Version2JobStatusFolderResolver.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/Version3JobStatusFolderResolver.java
M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/resources/META-INF/components.txt
M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/java/org/xwiki/job/internal/DefaultJobStatusStoreTest.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/java/org/xwiki/job/internal/Version1JobStatusFolderResolverTest.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/java/org/xwiki/job/internal/Version2JobStatusFolderResolverTest.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/java/org/xwiki/job/internal/Version3JobStatusFolderResolverTest.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/3/correct/location/log.index
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/3/correct/location/log.xml
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/3/correct/location/status.xml
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location/log.index
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location/log.xml
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location/status.xml.zip
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location2/log.index
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location2/log.xml
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location2/status.xml.zip
Log Message:
-----------
XCOMMONS-3276: NPE Warnings after upgrading XWiki to 16.10.3 related to DefaultJobStatusStore - Failed to load job status (#1261)
* Handle null values as before.
* Also fix XCOMMONS-3275: Job status of jobs executed before the upgrade to 16.10.x cannot be loaded anymore
* Improve the repair step:
* Move the job log along with the job status during repair.
* Delete empty directories during repair.
* Handle duplicate job statuses by keeping the most recent one.
* Revert the filename generation to use URL encoding but avoid problematic characters and add a version prefix.
* Instead of moving all job statuses at startup, move them only when accessed and check old locations.
* Add implementations of the previous job folder status names.
* Add and improve tests.
* Don't delete the whole directory on remove() but just the job files.
* Move the checkstyle ignore into the Java file.
(cherry picked from commit efcf062d4940c77839210c921383e5ccd0278fc8)
To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications
Branch: refs/heads/backport-1261-to-stable-16.10.x
Home: https://github.com/xwiki/xwiki-commons
Commit: 6199b6f63569b2ecd22e2aacae74d9fbd87f4289
https://github.com/xwiki/xwiki-commons/commit/6199b6f63569b2ecd22e2aacae74d…
Author: Michael Hamann <michael.hamann(a)xwiki.com>
Date: 2025-03-20 (Thu, 20 Mar 2025)
Changed paths:
M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/pom.xml
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/AbstractJobStatusFolderResolver.java
M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/DefaultJobStatusStore.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/JobStatusFolderResolver.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/Version1JobStatusFolderResolver.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/Version2JobStatusFolderResolver.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/Version3JobStatusFolderResolver.java
M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/resources/META-INF/components.txt
M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/java/org/xwiki/job/internal/DefaultJobStatusStoreTest.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/java/org/xwiki/job/internal/Version1JobStatusFolderResolverTest.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/java/org/xwiki/job/internal/Version2JobStatusFolderResolverTest.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/java/org/xwiki/job/internal/Version3JobStatusFolderResolverTest.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/3/correct/location/log.index
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/3/correct/location/log.xml
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/3/correct/location/status.xml
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location/log.index
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location/log.xml
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location/status.xml.zip
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location2/log.index
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location2/log.xml
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location2/status.xml.zip
Log Message:
-----------
XCOMMONS-3276: NPE Warnings after upgrading XWiki to 16.10.3 related to DefaultJobStatusStore - Failed to load job status (#1261)
* Handle null values as before.
* Also fix XCOMMONS-3275: Job status of jobs executed before the upgrade to 16.10.x cannot be loaded anymore
* Improve the repair step:
* Move the job log along with the job status during repair.
* Delete empty directories during repair.
* Handle duplicate job statuses by keeping the most recent one.
* Revert the filename generation to use URL encoding but avoid problematic characters and add a version prefix.
* Instead of moving all job statuses at startup, move them only when accessed and check old locations.
* Add implementations of the previous job folder status names.
* Add and improve tests.
* Don't delete the whole directory on remove() but just the job files.
* Move the checkstyle ignore into the Java file.
(cherry picked from commit efcf062d4940c77839210c921383e5ccd0278fc8)
To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications
Branch: refs/heads/master
Home: https://github.com/xwiki/xwiki-commons
Commit: efcf062d4940c77839210c921383e5ccd0278fc8
https://github.com/xwiki/xwiki-commons/commit/efcf062d4940c77839210c921383e…
Author: Michael Hamann <michael.hamann(a)xwiki.com>
Date: 2025-03-20 (Thu, 20 Mar 2025)
Changed paths:
M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/pom.xml
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/AbstractJobStatusFolderResolver.java
M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/DefaultJobStatusStore.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/JobStatusFolderResolver.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/Version1JobStatusFolderResolver.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/Version2JobStatusFolderResolver.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/java/org/xwiki/job/internal/Version3JobStatusFolderResolver.java
M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/main/resources/META-INF/components.txt
M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/java/org/xwiki/job/internal/DefaultJobStatusStoreTest.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/java/org/xwiki/job/internal/Version1JobStatusFolderResolverTest.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/java/org/xwiki/job/internal/Version2JobStatusFolderResolverTest.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/java/org/xwiki/job/internal/Version3JobStatusFolderResolverTest.java
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/3/correct/location/log.index
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/3/correct/location/log.xml
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/3/correct/location/status.xml
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location/log.index
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location/log.xml
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location/status.xml.zip
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location2/log.index
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location2/log.xml
A xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-default/src/test/resources/jobs/status/wrong/location2/status.xml.zip
Log Message:
-----------
XCOMMONS-3276: NPE Warnings after upgrading XWiki to 16.10.3 related to DefaultJobStatusStore - Failed to load job status (#1261)
* Handle null values as before.
* Also fix XCOMMONS-3275: Job status of jobs executed before the upgrade to 16.10.x cannot be loaded anymore
* Improve the repair step:
* Move the job log along with the job status during repair.
* Delete empty directories during repair.
* Handle duplicate job statuses by keeping the most recent one.
* Revert the filename generation to use URL encoding but avoid problematic characters and add a version prefix.
* Instead of moving all job statuses at startup, move them only when accessed and check old locations.
* Add implementations of the previous job folder status names.
* Add and improve tests.
* Don't delete the whole directory on remove() but just the job files.
* Move the checkstyle ignore into the Java file.
To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications
Branch: refs/heads/master
Home: https://github.com/xwiki/xwiki-platform
Commit: 05adae51bde4ca0696a24e8e2a9ca0c5ab693af2
https://github.com/xwiki/xwiki-platform/commit/05adae51bde4ca0696a24e8e2a9c…
Author: Michael Hamann <michael.hamann(a)xwiki.com>
Date: 2025-03-20 (Thu, 20 Mar 2025)
Changed paths:
A xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/main/java/org/xwiki/test/SecurityCachePerformanceTestScriptService.java
M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/main/resources/META-INF/components.txt
M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/AllIT.java
A xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/SecurityCacheStressIT.java
M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/main/java/org/xwiki/security/authorization/cache/internal/DefaultSecurityCache.java
M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/main/java/org/xwiki/security/authorization/cache/internal/DefaultSecurityCacheLoader.java
M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/main/java/org/xwiki/security/authorization/cache/internal/SecurityCache.java
M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/cache/internal/DefaultSecurityCacheLoaderTest.java
M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/cache/internal/DefaultSecurityCacheTest.java
Log Message:
-----------
XWIKI-22979: Access to pages is slow under high load on the security cache (#3992)
* Remove the read lock of the security cache to avoid blocking read
access during cache writes.
* Switch from a ReadWriteLock to a simple write lock as ReadWriteLocks
might be slow, and we don't really need it anymore.
* Remove the useless check of the internal entries for security access
entries to avoid needlessly acquiring the write lock.
* Improve the concurrency behavior of upgrading entries to user entries
to ensure that removing the read lock is safe.
* Replace the invalidation lock used to prevent loading outdated data by
an invalidation counter. This avoids holding any locks in the security
cache while a document is potentially loaded from the database. Before
that, it could happen that while a remove operation is waiting on the
lock, a database load is executed under the invalidation read lock.
That would block both the invalidation and all further cache loads as
the invalidation read lock cannot be obtained anymore as soon as a
thread is waiting for the invalidation write lock.
* Update the security cache loader and the affected tests.
* Make the write lock in the security cache unfair for increased
performance.
* Add a stress test for the security cache.
To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications