July 2026 - notifications - lists.xwiki.org

[xwiki/xwiki-platform] 3681e0: [Misc] Fix mechanical SonarQube issues in oldcore ...
by XWiki Notifications 30 Jul '26

30 Jul '26

Branch: refs/heads/claude/clever-feynman-lm4cfw Home: https://github.com/xwiki/xwiki-platform Commit: 3681e02596e5c6a996933e82ed53f4601509e73c https://github.com/xwiki/xwiki-platform/commit/3681e02596e5c6a996933e82ed53… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-30 (Thu, 30 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/stats/impl/xwiki/XWikiStatsReader.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiGroupServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/store/hibernate/internal/MySQLHibernateAdapter.java Log Message: ----------- [Misc] Fix mechanical SonarQube issues in oldcore (java:S6485, java:S6397) * java:S6485: use HashMap.newHashMap()/HashSet.newHashSet()/LinkedHashSet.newLinkedHashSet() instead of the constructors taking an initial capacity * java:S6397: drop redundant single-character regex character classes Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-rendering] 3fc7cb: [Misc] Fix various mechanical SonarQube issues in ...
by XWiki Notifications 30 Jul '26

30 Jul '26

Branch: refs/heads/claude/peaceful-archimedes-lm4cfw Home: https://github.com/xwiki/xwiki-rendering Commit: 3fc7cbbdda539b764877cd2ae9446a8db406cab7 https://github.com/xwiki/xwiki-rendering/commit/3fc7cbbdda539b764877cd2ae94… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-30 (Thu, 30 Jul 2026) Changed paths: M xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/AbstractBlock.java M xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/match/BlockNavigator.java M xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/listener/ListenerRegistry.java M xwiki-rendering-api/src/main/java/org/xwiki/rendering/listener/chaining/ListenerChain.java M xwiki-rendering-transformations/xwiki-rendering-transformation-linkchecker/src/main/java/org/xwiki/rendering/internal/transformation/linkchecker/LinkCheckerTransformation.java M xwiki-rendering-wikimodel/src/main/java/org/xwiki/rendering/wikimodel/WikiParameters.java M xwiki-rendering-wikimodel/src/main/java/org/xwiki/rendering/wikimodel/impl/InternalWikiScannerContext.java M xwiki-rendering-wikimodel/src/main/java/org/xwiki/rendering/wikimodel/xhtml/handler/DivisionTagHandler.java M xwiki-rendering-wikimodel/src/main/java/org/xwiki/rendering/wikimodel/xhtml/handler/ImgTagHandler.java M xwiki-rendering-wikimodel/src/main/java/org/xwiki/rendering/wikimodel/xhtml/impl/TagStack.java M xwiki-rendering-wikimodel/src/main/java/org/xwiki/rendering/wikimodel/xhtml/impl/XhtmlHandler.java M xwiki-rendering-wikimodel/src/main/java/org/xwiki/rendering/wikimodel/xwiki/xwiki20/XWikiSerializer2.java Log Message: ----------- [Misc] Fix various mechanical SonarQube issues in the rendering modules * java:S6397: drop redundant single-character regex character classes * java:S6485: use the HashMap/LinkedHashMap.newXxx() factory methods * java:S6208: merge fall-through case labels into comma-separated labels * java:S6204: use Stream.toList() instead of collect(Collectors.toList()) * java:S2864: iterate entrySet() instead of keySet() + get() * java:S1161: add a missing @Override annotation * java:S1481/java:S1068: remove an unused local variable and an unused private field * java:S1126: replace an if-then-else returning booleans with a single return Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-commons] 8b1074: [Misc] Use instanceof pattern matching instead of ...
by XWiki Notifications 30 Jul '26

30 Jul '26

Branch: refs/heads/claude/nifty-bell-lm4cfw Home: https://github.com/xwiki/xwiki-commons Commit: 8b1074352b6dfa81ccbb66f474f8ff55b84f5d2c https://github.com/xwiki/xwiki-commons/commit/8b1074352b6dfa81ccbb66f474f8f… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-30 (Thu, 30 Jul 2026) Changed paths: M xwiki-commons-core/xwiki-commons-component/xwiki-commons-component-default/src/main/java/org/xwiki/component/annotation/AbstractComponentDependencyFactory.java M xwiki-commons-core/xwiki-commons-component/xwiki-commons-component-default/src/main/java/org/xwiki/component/annotation/ComponentAnnotationLoader.java M xwiki-commons-core/xwiki-commons-component/xwiki-commons-component-default/src/main/java/org/xwiki/component/embed/EmbeddableComponentManager.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-api/src/main/java/org/xwiki/filter/internal/FilterUtils.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-api/src/main/java/org/xwiki/filter/internal/converter/FilterEventParametersConverter.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-api/src/main/java/org/xwiki/filter/internal/input/InputSourceConverter.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-api/src/main/java/org/xwiki/filter/internal/output/OutputTargetConverter.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-api/src/main/java/org/xwiki/filter/type/FilterStreamType.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-api/src/main/java/org/xwiki/filter/type/SystemType.java M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-api/src/main/java/org/xwiki/job/AbstractJob.java M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-api/src/main/java/org/xwiki/job/AbstractJobStatus.java M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-api/src/main/java/org/xwiki/job/JobGroupPath.java M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-api/src/main/java/org/xwiki/job/event/status/PushLevelProgressEvent.java M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-api/src/main/java/org/xwiki/job/internal/DefaultJobProgress.java M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/main/java/org/xwiki/logging/LogQueue.java M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/main/java/org/xwiki/logging/LogTree.java M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/main/java/org/xwiki/logging/LogTreeNode.java M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/main/java/org/xwiki/logging/LogUtils.java M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/main/java/org/xwiki/logging/Message.java M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/main/java/org/xwiki/logging/marker/AbstractContainerMarker.java M xwiki-commons-core/xwiki-commons-logging/xwiki-commons-logging-api/src/main/java/org/xwiki/logging/marker/TranslationMarker.java M xwiki-commons-core/xwiki-commons-properties/src/main/java/org/xwiki/properties/converter/collection/AbstractCollectionConverter.java M xwiki-commons-core/xwiki-commons-properties/src/main/java/org/xwiki/properties/internal/DefaultBeanManager.java M xwiki-commons-core/xwiki-commons-properties/src/main/java/org/xwiki/properties/internal/DefaultConverterManager.java M xwiki-commons-core/xwiki-commons-properties/src/main/java/org/xwiki/properties/internal/DefaultPropertyDescriptor.java Log Message: ----------- [Misc] Use instanceof pattern matching instead of explicit casts (SonarQube java:S6201) * Convert 53 instanceof-and-cast sites in xwiki-commons-component-default, xwiki-commons-filter-api, xwiki-commons-job-api, xwiki-commons-logging-api and xwiki-commons-properties to Java 16+ instanceof pattern matching. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/backport/stable-18.6.x/pr-6020 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] b945a1: [Misc] Revert the java:S5785 changes on the equals...
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/stable-18.6.x Home: https://github.com/xwiki/xwiki-platform Commit: b945a1fa66130bd0869090dceeeaae46eb6ee9b9 https://github.com/xwiki/xwiki-platform/commit/b945a1fa66130bd0869090dceeea… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-29 (Wed, 29 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-bridge/src/test/java/org/xwiki/bridge/ActionExecutingEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/AbstractRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/SimpleEventQueryTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/test/java/org/xwiki/observation/ActionExecutionEventTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/RegexEntityReferenceTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiLinkTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/NumberPropertyTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/job/question/EntitySelectionTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightMapTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightSetTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-api/src/test/java/org/xwiki/url/ExtendedURLTest.java M xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-api/src/test/java/org/xwiki/webjars/WebJarResourceReferenceTest.java Log Message: ----------- [Misc] Revert the java:S5785 changes on the equals()/hashCode() contract tests (#6020) (#6022) Converting assertTrue/assertFalse(a.equals(b)) into assertEquals/assertNotEquals in tests whose purpose is to verify the equals()/hashCode() contract changes what is being tested. JUnit compares through AssertionUtils.objectsAreEqual(a, b), i.e. a == null ? b == null : a.equals(b), so the call site no longer shows which object is the receiver and which one is the argument, and it invites a later java:S3415 "swap these arguments" change that would call the other object's equals() instead. The 88 assertions concerned are restored to their boolean form in 14 test files, and the reason now lives in the code as @SuppressWarnings("java:S5785") plus an explanatory comment on each contract-test method. Assertions that merely happen to compare two values with equals() in ordinary tests are left converted, as are the hashCode() comparisons outside contract tests. RegexEntityReferenceTest is the clearest case: RegexEntityReference#equals() only runs the regex when the regex reference is the receiver, so the converted assertions were one java:S3415 argument swap away from silently no longer matching anything. On this branch the class-level @SuppressWarnings("java:S3415") that master had added to hold that off was never applied, so the file goes straight from the converted form back to the boolean one. This reverts the equals()/hashCode() contract-test parts of 1eafd658a13, a94435cb30c, ce509be1144 and d5ac2bd37e0. (cherry picked from commit d114bf0615cdf7c1f058ac4547721f48302c43d9) Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 1321f6: [Misc] Revert the java:S5785 changes on the equals...
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/backport/stable-18.6.x/pr-6020 Home: https://github.com/xwiki/xwiki-platform Commit: 1321f6a848ab6b51842a1a56c07b0191f5c20911 https://github.com/xwiki/xwiki-platform/commit/1321f6a848ab6b51842a1a56c07b… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-29 (Wed, 29 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-bridge/src/test/java/org/xwiki/bridge/ActionExecutingEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/AbstractRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/SimpleEventQueryTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/test/java/org/xwiki/observation/ActionExecutionEventTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/RegexEntityReferenceTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiLinkTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/NumberPropertyTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/job/question/EntitySelectionTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightMapTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightSetTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-api/src/test/java/org/xwiki/url/ExtendedURLTest.java M xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-api/src/test/java/org/xwiki/webjars/WebJarResourceReferenceTest.java Log Message: ----------- [Misc] Revert the java:S5785 changes on the equals()/hashCode() contract tests (#6020) Converting assertTrue/assertFalse(a.equals(b)) into assertEquals/assertNotEquals in tests whose purpose is to verify the equals()/hashCode() contract changes what is being tested. JUnit compares through AssertionUtils.objectsAreEqual(a, b), i.e. a == null ? b == null : a.equals(b), so the call site no longer shows which object is the receiver and which one is the argument, and it invites a later java:S3415 "swap these arguments" change that would call the other object's equals() instead. The 88 assertions concerned are restored to their boolean form in 14 test files, and the reason now lives in the code as @SuppressWarnings("java:S5785") plus an explanatory comment on each contract-test method. Assertions that merely happen to compare two values with equals() in ordinary tests are left converted, as are the hashCode() comparisons outside contract tests. RegexEntityReferenceTest is the clearest case: RegexEntityReference#equals() only runs the regex when the regex reference is the receiver, so the converted assertions were one java:S3415 argument swap away from silently no longer matching anything. On this branch the class-level @SuppressWarnings("java:S3415") that master had added to hold that off was never applied, so the file goes straight from the converted form back to the boolean one. This reverts the equals()/hashCode() contract-test parts of 1eafd658a13, a94435cb30c, ce509be1144 and d5ac2bd37e0. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> (cherry picked from commit d114bf0615cdf7c1f058ac4547721f48302c43d9) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/misc-s5785-equals-contract-tests Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] d114bf: [Misc] Revert the java:S5785 changes on the equals...
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: d114bf0615cdf7c1f058ac4547721f48302c43d9 https://github.com/xwiki/xwiki-platform/commit/d114bf0615cdf7c1f058ac454772… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-29 (Wed, 29 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-bridge/src/test/java/org/xwiki/bridge/ActionExecutingEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/AbstractRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/SimpleEventQueryTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/test/java/org/xwiki/observation/ActionExecutionEventTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/RegexEntityReferenceTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiLinkTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/NumberPropertyTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/job/question/EntitySelectionTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightMapTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightSetTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-api/src/test/java/org/xwiki/url/ExtendedURLTest.java M xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-api/src/test/java/org/xwiki/webjars/WebJarResourceReferenceTest.java Log Message: ----------- [Misc] Revert the java:S5785 changes on the equals()/hashCode() contract tests (#6020) Converting assertTrue/assertFalse(a.equals(b)) into assertEquals/assertNotEquals in tests whose purpose is to verify the equals()/hashCode() contract changes what is being tested. JUnit compares through AssertionUtils.objectsAreEqual(a, b), i.e. a == null ? b == null : a.equals(b), so the call site no longer shows which object is the receiver and which one is the argument, and it invites a later java:S3415 "swap these arguments" change that would call the other object's equals() instead. The 88 assertions concerned are restored to their boolean form in 14 test files, and the reason now lives in the code as @SuppressWarnings("java:S5785") plus an explanatory comment on each contract-test method. Assertions that merely happen to compare two values with equals() in ordinary tests are left converted, as are the hashCode() comparisons outside contract tests. RegexEntityReferenceTest is the clearest case: RegexEntityReference#equals() only runs the regex when the regex reference is the receiver, which is why it already needed a class-level @SuppressWarnings("java:S3415") to stay correct. That suppression is dropped since the assertions call equals() explicitly again. This reverts the equals()/hashCode() contract-test parts of 1eafd658a13, a94435cb30c, ce509be1144 and d5ac2bd37e0. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 87a7c0: [Misc] Revert the java:S5785 changes on the equals...
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/misc-s5785-equals-contract-tests Home: https://github.com/xwiki/xwiki-platform Commit: 87a7c019edbde0068e1834b59d9f1bfe552f4f30 https://github.com/xwiki/xwiki-platform/commit/87a7c019edbde0068e1834b59d9f… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-29 (Wed, 29 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-bridge/src/test/java/org/xwiki/bridge/ActionExecutingEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/AbstractRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/SimpleEventQueryTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/test/java/org/xwiki/observation/ActionExecutionEventTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/RegexEntityReferenceTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiLinkTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/NumberPropertyTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/job/question/EntitySelectionTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightMapTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightSetTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-api/src/test/java/org/xwiki/url/ExtendedURLTest.java M xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-api/src/test/java/org/xwiki/webjars/WebJarResourceReferenceTest.java Log Message: ----------- [Misc] Revert the java:S5785 changes on the equals()/hashCode() contract tests Converting assertTrue/assertFalse(a.equals(b)) into assertEquals/assertNotEquals in tests whose purpose is to verify the equals()/hashCode() contract changes what is being tested. JUnit compares through AssertionUtils.objectsAreEqual(a, b), i.e. a == null ? b == null : a.equals(b), so the call site no longer shows which object is the receiver and which one is the argument, and it invites a later java:S3415 "swap these arguments" change that would call the other object's equals() instead. The 88 assertions concerned are restored to their boolean form in 14 test files, and the reason now lives in the code as @SuppressWarnings("java:S5785") plus an explanatory comment on each contract-test method. Assertions that merely happen to compare two values with equals() in ordinary tests are left converted, as are the hashCode() comparisons outside contract tests. RegexEntityReferenceTest is the clearest case: RegexEntityReference#equals() only runs the regex when the regex reference is the receiver, which is why it already needed a class-level @SuppressWarnings("java:S3415") to stay correct. That suppression is dropped since the assertions call equals() explicitly again. This reverts the equals()/hashCode() contract-test parts of 1eafd658a13, a94435cb30c, ce509be1144 and d5ac2bd37e0. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-dev-llm] 20bbe2: [Misc] Release v1.0.0
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-dev-llm Commit: 20bbe28ef8fd9634d3d7080801acaef30239886c https://github.com/xwiki/xwiki-dev-llm/commit/20bbe28ef8fd9634d3d7080801aca… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-29 (Wed, 29 Jul 2026) Changed paths: M .claude-plugin/marketplace.json M kimi.plugin.json M opencode.jsonc M xwiki/.claude-plugin/plugin.json Log Message: ----------- [Misc] Release v1.0.0 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0