August 2026 - notifications

[xwiki/xwiki-platform] 9c62da: [Misc] Add the handoff for the remaining logging b...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-best-practices Home: https://github.com/xwiki/xwiki-platform Commit: 9c62da8cfb12495643c81133fce83077fe104fc3 https://github.com/xwiki/xwiki-platform/commit/9c62da8cfb12495643c81133fce8… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: A docs/logging-audit-handoff.md Log Message: ----------- [Misc] Add the handoff for the remaining logging best-practices work Lists the 365 remaining sites by module and by category, the fix policy for each category, and the cases that look like violations but are not, so that the follow-up PRs stay consistent with the two commits that precede this one. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] ffe6e5: [Misc] Fix broken SLF4J log messages
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-best-practices Home: https://github.com/xwiki/xwiki-platform Commit: ffe6e5ff15c0c2950a2ad4e6f2608b164a8ddefe https://github.com/xwiki/xwiki-platform/commit/ffe6e5ff15c0c2950a2ad4e6f260… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-wiki/src/main/java/org/xwiki/component/wiki/internal/bridge/WikiObjectComponentManagerEventListenerProxy.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/main/java/org/xwiki/eventstream/internal/AbstractAsynchronousEventStore.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-index/src/main/java/org/xwiki/extension/index/internal/DefaultExtensionIndex.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-events-hibernate/xwiki-platform-legacy-events-hibernate-api/src/main/java/org/xwiki/eventstream/store/internal/LegacyEventLoader.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-preferences/xwiki-platform-notifications-preferences-api/src/main/java/org/xwiki/notifications/preferences/internal/AbstractDocumentNotificationPreferenceProvider.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-preferences/xwiki-platform-notifications-preferences-api/src/main/java/org/xwiki/notifications/preferences/internal/WikiNotificationPreferenceProvider.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/DefaultMandatoryDocumentInitializerManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiRightServiceImpl.java M xwiki-platform-core/xwiki-platform-repository/xwiki-platform-repository-server-api/src/main/java/org/xwiki/repository/internal/XWikiRepositoryModel.java M xwiki-platform-core/xwiki-platform-sheet/xwiki-platform-sheet-api/src/main/java/org/xwiki/sheet/internal/DefaultSheetManager.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-rest/src/main/java/org/xwiki/test/extension/RestExtensionInstaller.java Log Message: ----------- [Misc] Fix broken SLF4J log messages Several log statements never printed the values they promised: * A corrupted placeholder ("[¶}]" instead of "[{}]") in XWikiRightServiceImpl. * "%s" / "{0}" placeholders, which SLF4J does not substitute, in LegacyEventLoader and WikiObjectComponentManagerEventListenerProxy. * Placeholders with no matching argument in AbstractDocumentNotificationPreferenceProvider and WikiNotificationPreferenceProvider, so the offending target was never shown. * Arguments with no matching placeholder, silently dropped by SLF4J, in AbstractAsynchronousEventStore, DefaultMandatoryDocumentInitializerManager, XWikiRepositoryModel and RestExtensionInstaller. Also fixes "existance" -> "existence" in DefaultExtensionIndex and DefaultSheetManager. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> Commit: 032f96f947ebfd2f166d69fc8a01c77953c92ad3 https://github.com/xwiki/xwiki-platform/commit/032f96f947ebfd2f166d69fc8a01… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-mailsender/src/main/java/com/xpn/xwiki/plugin/mailsender/MailSenderPlugin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/filter/input/XWikiAttachmentEventGenerator.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/filter/output/PropertyClassOutputFilterStream.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/skin/AbstractResourceSkin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/store/hibernate/HibernateStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/template/InternalTemplateManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/monitor/api/MonitorData.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/monitor/api/MonitorPlugin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/PdfExportImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/packaging/Package.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/hibernate/query/HqlQueryExecutor.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/AbstractDataMigrationManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/AbstractResizeMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R140600000XWIKI19869DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R40000XWIKI6990DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/MyPersistentLoginManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/RegisterAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/SkinAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiServletURLFactory.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/filter/Importer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/velocity/XWikiVelocityManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/store/hibernate/internal/MySQLHibernateAdapter.java Log Message: ----------- [Misc] Apply the logging best practices to xwiki-platform-oldcore Follows https://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HLo… * Replace string concatenation and String.format() in log messages with the parameterized SLF4J signatures, which also removes the now-redundant isDebugEnabled()/isErrorEnabled() guards. * Surround placeholder values with [] so they are visually delimited. * Stop passing a Throwable to warn(), using ExceptionUtils.getRootCauseMessage() instead, so that stack traces stay reserved for errors. * Pass the Throwable to error() where it was previously only logged at debug level, and replace two e.printStackTrace() calls in MonitorPlugin. Along the way this fixes a few log statements that were wrong rather than just badly formatted: * Package.readFromZip() promised a "[{}]" document reference but passed no argument for it, so the failing entry was never identified. * MonitorPlugin reported "endRequest"/"startRequest" from startRequest(), startTimer() and endTimer() due to copy-paste. * MyPersistentLoginManager included the username or password being encrypted/decrypted in its error messages; those values no longer reach the logs. * Typos: "idenfier" -> "identifier", "handler revision" -> "handle revision", "emptry" -> "empty", "produce" -> "produces", "occured" -> "occurred", "decypting" -> "decrypting". Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> Compare: https://github.com/xwiki/xwiki-platform/compare/ffe6e5ff15c0%5E...032f96f94… To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-dev-llm]
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-okf-no-hard-wrapping-forum-xwiki-org Home: https://github.com/xwiki/xwiki-dev-llm To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0

[xwiki/xwiki-dev-llm] bcfb15: [Misc] Record that prose for xwiki.org and the for...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-dev-llm Commit: bcfb1502ee42154478bea220a05872bd12668d0a https://github.com/xwiki/xwiki-dev-llm/commit/bcfb1502ee42154478bea220a0587… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M .claude-plugin/marketplace.json M kimi.plugin.json M opencode.jsonc M xwiki/.claude-plugin/plugin.json M xwiki/instructions/xwiki-org.md M xwiki/okf/conventions/documentation.md M xwiki/okf/index.md Log Message: ----------- [Misc] Record that prose for xwiki.org and the forum is never hard-wrapped Add the convention to okf/conventions/documentation.md: content written for xwiki.org pages and for forum.xwiki.org (Discourse) posts must not be hard-wrapped — one paragraph, and each list item, is a single unbroken line. Both surfaces reflow prose themselves, so manual breaks inside a paragraph gain nothing, are painful to re-wrap in the web editor and can leak into the rendered output. The 120-character limit is a Java-source rule enforced by Checkstyle; applying it to prose bound for a web editor is a category error. Fenced and {{code}} blocks keep their own line structure. Sync the okf/index.md and instructions/xwiki-org.md maps, and bump the plugin version to 1.0.4 so installed plugins pull the update. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> Commit: a1a6fa2ddb12f64887e2363983bb1ffcfb0abb0e https://github.com/xwiki/xwiki-dev-llm/commit/a1a6fa2ddb12f64887e2363983bb1… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M .claude-plugin/marketplace.json M kimi.plugin.json M opencode.jsonc M xwiki/.claude-plugin/plugin.json M xwiki/instructions/xwiki-org.md M xwiki/okf/conventions/documentation.md M xwiki/okf/index.md Log Message: ----------- [Misc] Record that prose for xwiki.org and the forum is never hard-wrapped Compare: https://github.com/xwiki/xwiki-dev-llm/compare/e58a2cc17dfb...a1a6fa2ddb12 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0

[xwiki/xwiki-dev-llm] bcfb15: [Misc] Record that prose for xwiki.org and the for...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-okf-no-hard-wrapping-forum-xwiki-org Home: https://github.com/xwiki/xwiki-dev-llm Commit: bcfb1502ee42154478bea220a05872bd12668d0a https://github.com/xwiki/xwiki-dev-llm/commit/bcfb1502ee42154478bea220a0587… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M .claude-plugin/marketplace.json M kimi.plugin.json M opencode.jsonc M xwiki/.claude-plugin/plugin.json M xwiki/instructions/xwiki-org.md M xwiki/okf/conventions/documentation.md M xwiki/okf/index.md Log Message: ----------- [Misc] Record that prose for xwiki.org and the forum is never hard-wrapped Add the convention to okf/conventions/documentation.md: content written for xwiki.org pages and for forum.xwiki.org (Discourse) posts must not be hard-wrapped — one paragraph, and each list item, is a single unbroken line. Both surfaces reflow prose themselves, so manual breaks inside a paragraph gain nothing, are painful to re-wrap in the web editor and can leak into the rendered output. The 120-character limit is a Java-source rule enforced by Checkstyle; applying it to prose bound for a web editor is a category error. Fenced and {{code}} blocks keep their own line structure. Sync the okf/index.md and instructions/xwiki-org.md maps, and bump the plugin version to 1.0.4 so installed plugins pull the update. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0

[xwiki/xwiki-rendering]
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-fix-logging-best-practices Home: https://github.com/xwiki/xwiki-rendering To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-rendering] 989303: [Misc] Fix logging best practices violations in th...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-rendering Commit: 989303b53586ebbc00defd54fbef3b3adefe7caf https://github.com/xwiki/xwiki-rendering/commit/989303b53586ebbc00defd54fbe… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/parser/reference/DefaultResourceReferenceParser.java M xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/transformation/RenderingContextStore.java M xwiki-rendering-syntaxes/xwiki-rendering-syntax-xhtml/src/main/java/org/xwiki/rendering/internal/renderer/xhtml/link/DefaultXHTMLLinkRenderer.java M xwiki-rendering-transformations/xwiki-rendering-transformation-icon/src/main/java/org/xwiki/rendering/internal/transformation/icon/IconTransformation.java M xwiki-rendering-transformations/xwiki-rendering-transformation-macro/src/main/java/org/xwiki/rendering/internal/transformation/macro/MacroTransformation.java Log Message: ----------- [Misc] Fix logging best practices violations in the rendering modules (#397) * Do not print a stack trace in a warning: RenderingContextStore was passing the exception as the trailing SLF4J argument, which logs a full stack trace. Log the root cause message instead. * Use parameterized logging instead of string concatenation in IconTransformation, and log the root cause rather than the direct message. * Surround log parameters with brackets: the trailing placeholder of the MacroTransformation debug message was not wrapped. * Log the identifying parameter (macro id, syntax, resource type) in the error messages that previously logged only a bare sentence plus a stack trace. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-rendering] 8f514b: [Misc] Fix logging best practices violations in th...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-fix-logging-best-practices Home: https://github.com/xwiki/xwiki-rendering Commit: 8f514b9609a37c5912a76ecc1582070ae4e35647 https://github.com/xwiki/xwiki-rendering/commit/8f514b9609a37c5912a76ecc158… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/parser/reference/DefaultResourceReferenceParser.java M xwiki-rendering-api/src/main/java/org/xwiki/rendering/internal/transformation/RenderingContextStore.java M xwiki-rendering-syntaxes/xwiki-rendering-syntax-xhtml/src/main/java/org/xwiki/rendering/internal/renderer/xhtml/link/DefaultXHTMLLinkRenderer.java M xwiki-rendering-transformations/xwiki-rendering-transformation-icon/src/main/java/org/xwiki/rendering/internal/transformation/icon/IconTransformation.java M xwiki-rendering-transformations/xwiki-rendering-transformation-macro/src/main/java/org/xwiki/rendering/internal/transformation/macro/MacroTransformation.java Log Message: ----------- [Misc] Fix logging best practices violations in the rendering modules * Do not print a stack trace in a warning: RenderingContextStore was passing the exception as the trailing SLF4J argument, which logs a full stack trace. Log the root cause message instead. * Use parameterized logging instead of string concatenation in IconTransformation, and log the root cause rather than the direct message. * Surround log parameters with brackets: the trailing placeholder of the MacroTransformation debug message was not wrapped. * Log the identifying parameter (macro id, syntax, resource type) in the error messages that previously logged only a bare sentence plus a stack trace. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-rendering]
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-move-legacy-revapi-ignores-to-root-pom Home: https://github.com/xwiki/xwiki-rendering To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-rendering] d89fd5: [Misc] Move the legacy module Revapi ignores to th...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-rendering Commit: d89fd5a373ee2bed771667cb0209a166fe82b7e6 https://github.com/xwiki/xwiki-rendering/commit/d89fd5a373ee2bed771667cb020… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M pom.xml M xwiki-rendering-legacy/xwiki-rendering-legacy-transformations/xwiki-rendering-legacy-transformation-macro/pom.xml Log Message: ----------- [Misc] Move the legacy module Revapi ignores to the root pom (#394) * Revapi ignores for xwiki-rendering are declared in the root pom, so move the MacroDescriptorAspect#aroundGetDefaultCategory ignore there from the xwiki-rendering-legacy-transformation-macro pom. * The revapi-maven-plugin declaration in that module only existed to hold that ignore, so it's removed and the module now inherits the root configuration. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0