August 2026 - notifications

[xwiki/xwiki-platform] f830da: [Misc] Apply the logging best practices to 5 more ...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-batch1 Home: https://github.com/xwiki/xwiki-platform Commit: f830da6df99384a324ebccae952fecbb87f2ea45 https://github.com/xwiki/xwiki-platform/commit/f830da6df99384a324ebccae952f… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-multi/src/main/java/org/xwiki/component/internal/DocumentDeletedListener.java M xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-multi/src/main/java/org/xwiki/component/internal/WikiDeletedListener.java M xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-wiki/src/main/java/org/xwiki/component/wiki/internal/DefaultWikiComponentInvocationHandler.java M xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-wiki/src/main/java/org/xwiki/component/wiki/internal/DefaultWikiComponentManagerEventListener.java M xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-wiki/src/main/java/org/xwiki/component/wiki/internal/WikiComponentManagerEventListenerHelper.java M xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-wiki/src/main/java/org/xwiki/component/wiki/internal/bridge/DefaultWikiObjectComponentManagerEventListener.java M xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-wiki/src/main/java/org/xwiki/component/wiki/internal/bridge/WikiObjectComponentManagerEventListenerProxy.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/main/java/org/xwiki/eventstream/AbstractRecordableEventDescriptor.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/main/java/org/xwiki/eventstream/internal/AbstractAsynchronousEventStore.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/AbstractRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-default/src/main/java/org/xwiki/eventstream/internal/DefaultUntypedRecordableEventDescriptor.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-default/src/main/java/org/xwiki/eventstream/internal/UntypedEventListener.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-default/src/test/java/org/xwiki/eventstream/internal/DefaultUntypedRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-stores/xwiki-platform-eventstream-store-common/src/main/java/org/xwiki/eventstream/store/internal/DocumentEventListener.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-stores/xwiki-platform-eventstream-store-common/src/main/java/org/xwiki/eventstream/store/internal/RecordableEventListener.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-distribution/src/main/java/org/xwiki/extension/distribution/internal/DefaultDistributionManager.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/XarExtensionJobFinishedListener.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/job/RepairXarJob.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/job/diff/AbstractUnifiedDiffBuilder.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/job/diff/AttachmentUnifiedDiffBuilder.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-index/src/main/java/org/xwiki/extension/index/internal/DefaultExtensionIndex.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-index/src/main/java/org/xwiki/extension/index/internal/job/ExtensionIndexJob.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-velocity/src/main/java/org/xwiki/rendering/internal/macro/velocity/filter/HTMLVelocityMacroFilter.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-api/src/main/java/org/xwiki/rendering/internal/macro/wikibridge/WikiMacroEventListener.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-store/src/main/java/org/xwiki/rendering/wikimacro/internal/DefaultWikiMacroInitializer.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-store/src/main/java/org/xwiki/rendering/wikimacro/internal/RegisterMacrosOnImportListener.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/main/java/org/xwiki/security/authentication/internal/DefaultAuthenticationFailureManager.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/main/java/org/xwiki/security/authentication/internal/R140600000XWIKI19869DataMigrationListener.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/main/java/org/xwiki/security/authorization/DefaultAuthorizationManager.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-bridge/src/main/java/org/xwiki/security/internal/DocumentInitializerRightsManager.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-requiredrights/xwiki-platform-security-requiredrights-default/src/main/java/org/xwiki/platform/security/requiredrights/internal/analyzer/DefaultMacroBlockRequiredRightAnalyzer.java Log Message: ----------- [Misc] Apply the logging best practices to 5 more platform modules * Modules covered: component (11 sites), extension (9), security (9), eventstream (9) and rendering (8). * Replaced String.format()/concatenation-built messages with {} placeholders and arguments. * Removed the Throwable from warn() calls, appending ExceptionUtils.getRootCauseMessage() instead; error() calls keep their Throwable and now use placeholders. * Wrapped bare {} placeholders in [] and trimmed trailing whitespace from messages. * Updated the two LogCaptureExtension assertions whose rendered message changed. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-legacy Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] d19b3e: [Misc] Apply the logging best practices to xwiki-p...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: d19b3e459e9798c775f1c528b1cd6caefcaf8dbe https://github.com/xwiki/xwiki-platform/commit/d19b3e459e9798c775f1c528b1cd… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-events-hibernate/xwiki-platform-legacy-events-hibernate-api/src/main/java/org/xwiki/eventstream/internal/LegacyEventMigrationJob.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-messagestream/xwiki-platform-legacy-messagestream-api/src/main/java/org/xwiki/messagestream/internal/DefaultMessageStream.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-notifications/xwiki-platform-legacy-notifications-notifiers/xwiki-platform-legacy-notifications-notifiers-api/src/main/java/org/xwiki/notifications/notifiers/internal/email/live/LiveNotificationEmailListener.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/internal/web/XWikiConfigurationService.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/web/TempResourceAction.java Log Message: ----------- [Misc] Apply the logging best practices to xwiki-platform-legacy (#6060) * Wrap the bare {} placeholders in [] in LegacyEventMigrationJob and DefaultMessageStream. * Replace getMessage() with ExceptionUtils.getRootCauseMessage() in the DefaultMessageStream warnings. * Move the Throwable of the LiveNotificationEmailListener warning into a root cause placeholder, since stack traces are reserved for error(). * Replace the String concatenations of XWikiConfigurationService and the String.format() of TempResourceAction with {} placeholders. * Fix the "Faile to lod configuration" typo in XWikiConfigurationService. * Log the "Failed to load the file [...] as a resource using the Servlet Context" message only when the lookup actually fails: it used to be emitted unconditionally, right before the success path returned. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] d26aec: [Misc] Apply the logging best practices to xwiki-p...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-legacy Home: https://github.com/xwiki/xwiki-platform Commit: d26aec3e84a2efec6940c8f6a40a9462a0986266 https://github.com/xwiki/xwiki-platform/commit/d26aec3e84a2efec6940c8f6a40a… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-events-hibernate/xwiki-platform-legacy-events-hibernate-api/src/main/java/org/xwiki/eventstream/internal/LegacyEventMigrationJob.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-messagestream/xwiki-platform-legacy-messagestream-api/src/main/java/org/xwiki/messagestream/internal/DefaultMessageStream.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-notifications/xwiki-platform-legacy-notifications-notifiers/xwiki-platform-legacy-notifications-notifiers-api/src/main/java/org/xwiki/notifications/notifiers/internal/email/live/LiveNotificationEmailListener.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/internal/web/XWikiConfigurationService.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/web/TempResourceAction.java Log Message: ----------- [Misc] Apply the logging best practices to xwiki-platform-legacy * Wrap the bare {} placeholders in [] in LegacyEventMigrationJob and DefaultMessageStream. * Replace getMessage() with ExceptionUtils.getRootCauseMessage() in the DefaultMessageStream warnings. * Move the Throwable of the LiveNotificationEmailListener warning into a root cause placeholder, since stack traces are reserved for error(). * Replace the String concatenations of XWikiConfigurationService and the String.format() of TempResourceAction with {} placeholders. * Fix the "Faile to lod configuration" typo in XWikiConfigurationService. * Log the "Failed to load the file [...] as a resource using the Servlet Context" message only when the lookup actually fails: it used to be emitted unconditionally, right before the success path returned. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-notifications Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] ff443e: [Misc] Apply the logging best practices to xwiki-p...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: ff443e33624f9bf3f86c4a06dca4cb16059ddb93 https://github.com/xwiki/xwiki-platform/commit/ff443e33624f9bf3f86c4a06dca4… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/internal/DeletedDocumentCleanUpFilterProcessingQueue.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/internal/scope/ScopeNotificationFilter.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/internal/user/EventUserFilterPreferencesGetter.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/main/java/org/xwiki/notifications/filters/internal/migrators/ScopeNotificationFilterClassMigrator.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-watch/src/main/java/org/xwiki/notifications/filters/watch/internal/AutomaticWatchModeListener.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/main/java/org/xwiki/notifications/notifiers/internal/email/live/PrefilteringLiveNotificationEmailManager.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/main/java/org/xwiki/notifications/notifiers/internal/UserEventDispatcher.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/main/java/org/xwiki/notifications/notifiers/internal/UserEventManager.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/main/java/org/xwiki/notifications/notifiers/internal/email/AbstractMimeMessageIterator.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/main/java/org/xwiki/notifications/notifiers/internal/email/UserAvatarAttachmentExtractor.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-preferences/xwiki-platform-notifications-preferences-api/src/main/java/org/xwiki/notifications/preferences/internal/DefaultNotificationPreferenceManager.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-preferences/xwiki-platform-notifications-preferences-default/src/main/java/org/xwiki/notifications/preferences/internal/email/DefaultNotificationEmailUserPreferenceManager.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-sources/src/main/java/org/xwiki/notifications/sources/internal/TagNotificationFilter.java Log Message: ----------- [Misc] Apply the logging best practices to xwiki-platform-notifications (#6059) Follows https://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HLo… Clears the 17 sites the logging audit found in xwiki-platform-notifications: * Stop passing a Throwable to warn(), using ExceptionUtils.getRootCauseMessage() instead, so that stack traces stay reserved for errors. * Surround placeholder values with [] so they are visually delimited. * Trim the trailing space before a logged value in ScopeNotificationFilter and before the stack trace in AbstractMimeMessageIterator. DefaultNotificationPreferenceManager passed the caught exception as a placeholder argument to error(), so it logged the exception's toString() and no stack trace at all; it now goes in the Throwable slot. The same message said "preference provide" rather than "preference provider". Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-search Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] c968a9: [Misc] Apply the logging best practices to xwiki-p...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: c968a934eb7fe00a8d4c35e8ed8babf96bdc1ff4 https://github.com/xwiki/xwiki-platform/commit/c968a934eb7fe00a8d4c35e8ed8b… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/DefaultSolrIndexer.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/IndexingUserConfigurationInitializer.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/job/IndexerJob.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/reference/DefaultSolrReferenceResolver.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/reference/DocumentSolrReferenceResolver.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/reference/ObjectSolrReferenceResolver.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/reference/SpaceSolrReferenceResolver.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/reference/WikiSolrReferenceResolver.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/test/java/org/xwiki/search/solr/internal/job/IndexerJobTest.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-embedded/src/main/java/org/xwiki/search/solr/internal/EmbeddedSolr.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-query/src/main/java/org/xwiki/query/solr/internal/SolrQueryExecutor.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-query/src/main/java/org/xwiki/query/solr/internal/SolrSearchExclusionsQueryFilter.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-query/src/test/java/org/xwiki/query/solr/internal/SolrQueryExecutorTest.java Log Message: ----------- [Misc] Apply the logging best practices to xwiki-platform-search (#6058) Follows https://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HLo… Clears the 18 sites the logging audit found in xwiki-platform-search, of which 17 needed a change: * Replace string concatenation and String.format() in log messages with the parameterized SLF4J signatures. error() keeps its Throwable, so IndexingUserConfigurationInitializer still logs the stack trace it was using String.format() to preserve. * Surround placeholder values with [] so they are visually delimited. * Stop passing a Throwable to warn(), using ExceptionUtils.getRootCauseMessage() instead, so that stack traces stay reserved for errors. * Trim the trailing space before the stack trace logged by SolrSearchExclusionsQueryFilter. SolrQueryExecutorTest now distinguishes the two bad results it removes, since the root cause it logs names the failing document. AbstractSolrCoreInitializer is left alone: its unbracketed placeholder holds the " dynamic" sentence fragment rather than a datum. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-test Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] abb25f: [Misc] Apply the logging best practices to xwiki-p...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: abb25f5ac8f1aab19971c6afe48d6b2f8df194d1 https://github.com/xwiki/xwiki-platform/commit/abb25f5ac8f1aab19971c6afe48d… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/DockerTestUtils.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/StopFileWatcher.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/WARBuilder.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/XWikiDockerExtension.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/configuration/ConfigurationFilesGenerator.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/database/DatabaseContainerExecutor.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/servletengine/ServletContainerExecutor.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-integration/src/main/java/org/xwiki/test/integration/XWikiExecutorSuite.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-integration/src/main/java/org/xwiki/test/integration/maven/ArtifactResolver.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-integration/src/main/java/org/xwiki/test/integration/maven/DebuggingDependencyVisitor.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/TestDebugger.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/TestUtils.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/XWikiWebDriver.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/BasePage.java Log Message: ----------- [Misc] Apply the logging best practices to xwiki-platform-test (#6057) * [Misc] Apply the logging best practices to xwiki-platform-test Follows https://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HLo… Clears the 39 sites the logging audit found in xwiki-platform-test, of which 25 needed a change: * Surround placeholder values with [] so they are visually delimited. * Stop passing a Throwable to warn(), using ExceptionUtils.getRootCauseMessage() instead, so that stack traces stay reserved for errors. In XWikiWebDriver the warning logs a synthetic exception only to capture the wasteful findElement() caller, so the stack trace is the whole payload: it moves into a "Call stack is [{}]" placeholder via ExceptionUtils.getStackTrace() rather than being dropped. * Replace the indentation prefix concatenated into DebuggingDependencyVisitor's message with a leading {} placeholder. * Trim the trailing space before the stack trace logged by BasePage. DockerTestUtils used the Plexus ExceptionUtils, which has no getRootCauseMessage(); it now uses the Commons Lang one, whose getRootCause() serves the existing EOFException check just as well. The 14 remaining sites are deliberately left alone, per the audit's own exclusions: values that already bracket themselves (a List in WARBuilder, a Collection in RestExtensionInstaller, the script result in TestUtils, the [\n{}\n] blocks in LogCaptureValidator), the compound [{} : {}] and [{}/{}] identifiers in the WCAG classes and BasePage, MavenResolver's ModelProblem.getMessage() which is not an exception message, and the warn() with a stack trace in ValidateConsoleExtensionTest, which is the fixture the test validates. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> * [Misc] Keep the call stack in the two TestUtils warnings Both warnings are emitted from helpers that arbitrary test code calls, so the caller frame is what tells you which test tripped them. Reducing them to a root-cause message dropped exactly that. They now log the full trace through a "Call stack is [{}]" placeholder, like the wasteful-wait warning in XWikiWebDriver, so the location is still there while warn() keeps the SLF4J Throwable slot free. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0