August 2026 - notifications

[xwiki/xwiki-platform] f485f6: XWIKI-24710: Add script APIs to count distinct act...
by XWiki Notifications 26 Aug '26

26 Aug '26

Branch: refs/heads/XWIKI-24710 Home: https://github.com/xwiki/xwiki-platform Commit: f485f60d5c76a026faa7cafdb669c71bdb1ad3d5 https://github.com/xwiki/xwiki-platform/commit/f485f60d5c76a026faa7cafdb669… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-26 (Wed, 26 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/pom.xml M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/ActiveInstallsConfiguration.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/DataManager.java A xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/TooManyExtensionsException.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/internal/DefaultActiveInstallsConfiguration.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/internal/DefaultDataManager.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/internal/data/DatePingDataProvider.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/internal/data/DistributionPingDataProvider.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/internal/data/ExtensionPingDataProvider.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/script/ActiveInstallsScriptService.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/test/it/org/xwiki/activeinstalls2/internal/PingSenderIT.java A xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/test/java/org/xwiki/activeinstalls2/ActiveInstallsConfigurationTest.java A xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/test/java/org/xwiki/activeinstalls2/DataManagerTest.java A xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/test/java/org/xwiki/activeinstalls2/internal/DefaultActiveInstallsConfigurationTest.java A xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/test/java/org/xwiki/activeinstalls2/script/ActiveInstallsScriptServiceTest.java M xwiki-platform-tools/xwiki-platform-tool-configuration-resources/src/main/resources/xwiki.properties.vm Log Message: ----------- XWIKI-24710: Add script APIs to count distinct active installs globally and per extension * Add DataManager#countDistinctInstalls(), counting the distinct instances matching a query with a cardinality aggregation on the instance id. Contrary to countInstalls(), which counts pings, this counts installs: an instance pings once a day but also on every restart. * Add DataManager#countDistinctInstallsByExtension(), returning the same count per extension id in a single query. It uses a reverse nested aggregation since the extensions are indexed as a nested type while the instance id is on the root document. It returns a SequencedMap, so that the documented bucket ordering is part of the type rather than only of the Javadoc. * Expose both through the activeinstalls2 script service. * Both methods are default methods throwing their declared checked exception, so that existing DataManager implementations keep working. Mark them, and the two new configuration methods, @Unstable: the shape of the query slot and whether the per-extension count should be rights-gated are still open, and an unstable API can be reshaped within the cycle rather than deprecated. * Set the cardinality precision threshold explicitly on both aggregations: the maximum Elasticsearch supports (40000) for the global count, and the new activeinstalls2.extensionInstanceCountPrecisionThreshold property (10000 by default) for the per-extension one, which pays that memory once per extension counted. Document in both APIs the count above which the result is an approximation. * Add ActiveInstallsConfiguration#getMaxExtensionCountPerQuery(), configurable with the new activeinstalls2.maxExtensionCountPerQuery property, to bound how many extensions a single per-extension count can report. This makes both the point at which the query starts failing and the cost it can impose on the Elasticsearch cluster configurable. DefaultActiveInstallsConfiguration clamps both properties into the ranges the role documents. * Detect that a per-extension count would report only some of the extensions by asking the terms aggregation for one extension more than the maximum, and refusing the count when that extra one comes back, rather than by reading sum_other_doc_count. The former is exact whatever the number of shards of the index, while the latter also holds the buckets that a shard didn't report because they fell below its shard_size. * Raise the new TooManyExtensionsException rather than a generic Exception when that bound is exceeded, so that a caller can tell that raising the configured maximum is what's needed without matching on a message. It carries the maximum that was exceeded; the property to raise shapes its message but is not exposed, belonging to the ActiveInstallsConfiguration implementation in use rather than to the exception. * Assemble the queried field paths from the mapping property names declared by the ping data providers, instead of re-declaring them and keeping them in sync by hand. DatePingDataProvider now uses the shared instance id path too. * Document that a query on the extensions doesn't restrict the extensions being counted, that the counts are keyed by the id an extension is installed under rather than resolved through its features, and that restricting a count to the instances that are actually active is a matter of querying on the ping date. * Document on countInstalls() that it counts pings and not instances despite its name, and correct the field that its Javadoc example queries, which doesn't exist in the mapping. * Encode the JSON query in UTF-8 rather than in the platform default charset before base64-encoding it into the Elasticsearch wrapper query, and share the wrapper construction between countInstalls() and the search requests. * Extend the integration test to verify the distinct counts with and without a query, the per-extension counts and their order, that a maximum exactly reaching the number of extensions in the index still counts them all, and that exceeding it fails rather than under-reporting. Add unit tests for the DataManager and ActiveInstallsConfiguration default methods, for the script service and for the configuration, and raise the module's instruction coverage ratios to 0.92 with the integration tests and 0.12 without. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[[email protected]][Issue] Updates for XWIKI-24741: Provide a localization adapter for ES modules
by XWiki Notifications 26 Aug '26

26 Aug '26

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 26 Aug '26

26 Aug '26

Branch: refs/heads/misc-sonar-regex-backtracking Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 1cbbd1: [Misc] Simplify two regular expressions that backt...
by XWiki Notifications 26 Aug '26

26 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 1cbbd138c1d0aa39dc0ba384b54340a6d18efb42 https://github.com/xwiki/xwiki-platform/commit/1cbbd138c1d0aa39dc0ba384b543… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-26 (Wed, 26 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-csrf/src/test/java/org/xwiki/csrf/DefaultCSRFTokenTest.java M xwiki-platform-tools/xwiki-platform-tool-standards-validator/src/main/java/org/xwiki/validator/HTML5DutchWebGuidelinesValidator.java Log Message: ----------- [Misc] Simplify two regular expressions that backtrack super-linearly (SonarQube) (#6232) * java:S8786: the CSRF token check matched ".*[bad chars].*" against the whole token, and the email pattern of the Dutch web guidelines validator chained two unbounded quantifiers over overlapping character sets ("([\.\w])+[\w]+"). Both backtrack quadratically on a non-matching input. The token check now looks for the bad characters with find() instead of wrapping them in ".*", and the local part of the email is matched by "[\w-][.\w]+\w", which accepts exactly the same strings. * java:S5998: the domain part "([\w-]+\.)+" is a group repetition, which Java's regex engine implements recursively and can therefore overflow the stack on a long input. Making the group atomic keeps the same language while letting each iteration leave no backtracking state behind. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-docker] ac23fd: XDOCKER-18: Automate updating the stable version
by XWiki Notifications 26 Aug '26

26 Aug '26

Branch: refs/heads/XDOCKER-18-automate-docker-images-release Home: https://github.com/xwiki/xwiki-docker Commit: ac23fd7bc43d1e1e74e83898f8602973242b1ad8 https://github.com/xwiki/xwiki-docker/commit/ac23fd7bc43d1e1e74e83898f86029… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-26 (Wed, 26 Aug 2026) Changed paths: M README.md M build.gradle M gradle/helpers.gradle M gradle/official-image.gradle M gradle/run-instances.gradle M gradle/update-versions.gradle Log Message: ----------- XDOCKER-18: Automate updating the stable version * Regenerate the images in 'submitOfficialImage', so that a 'versions.json' pushed without its regenerated directories is reported as a dirty tree instead of publishing tags the pushed Dockerfiles do not produce. * Refuse in 'updateXWiki' a bump that would put two cycles on the same version line, which the duplicate tag check rejects at configuration time and would therefore leave every later './gradlew' failing. * Boot in 'smokeTest' the cycles 'generate' rewrote as well as the ones whose versions moved, so that a 'template/' edit is smoke-tested by 'release' too. * Add '-Pfresh' to 'runAll', to remove each instance and its volumes before starting it. * Validate the boolean command line flags, '-PdryRun=false' having read as true. * Drop a comment justifying itself by an earlier revision, and a transient issue key from another. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-docker/settings/notifications

1 0

[[email protected]][Issue] Updates for XWIKI-24732: The fact that the page titles can be changed in edit mode is not so visible anymore
by XWiki Notifications 26 Aug '26

26 Aug '26

1 0

[xwiki/xwiki-platform] ab8eb4: [Misc] Simplify two regular expressions that backt...
by XWiki Notifications 26 Aug '26

26 Aug '26

Branch: refs/heads/misc-sonar-regex-backtracking Home: https://github.com/xwiki/xwiki-platform Commit: ab8eb4d711579475f81cf26c77db05b0d91decae https://github.com/xwiki/xwiki-platform/commit/ab8eb4d711579475f81cf26c77db… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-26 (Wed, 26 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-csrf/src/test/java/org/xwiki/csrf/DefaultCSRFTokenTest.java M xwiki-platform-tools/xwiki-platform-tool-standards-validator/src/main/java/org/xwiki/validator/HTML5DutchWebGuidelinesValidator.java Log Message: ----------- [Misc] Simplify two regular expressions that backtrack super-linearly (SonarQube) * java:S8786: the CSRF token check matched ".*[bad chars].*" against the whole token, and the email pattern of the Dutch web guidelines validator chained two unbounded quantifiers over overlapping character sets ("([\.\w])+[\w]+"). Both backtrack quadratically on a non-matching input. The token check now looks for the bad characters with find() instead of wrapping them in ".*", and the local part of the email is matched by "[\w-][.\w]+\w", which accepts exactly the same strings. * java:S5998: the domain part "([\w-]+\.)+" is a group repetition, which Java's regex engine implements recursively and can therefore overflow the stack on a long input. Making the group atomic keeps the same language while letting each iteration leave no backtracking state behind. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[[email protected]][Issue] Updates for XWIKI-22257: Hash the superadmin password
by XWiki Notifications 26 Aug '26

26 Aug '26

1 0

[xwiki/xwiki-platform] 1696a6: XWIKI-24710: Add script APIs to count distinct act...
by XWiki Notifications 26 Aug '26

26 Aug '26

Branch: refs/heads/XWIKI-24710 Home: https://github.com/xwiki/xwiki-platform Commit: 1696a6109516445d562e7f92661d0e53db1047dd https://github.com/xwiki/xwiki-platform/commit/1696a6109516445d562e7f92661d… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-26 (Wed, 26 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/pom.xml M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/ActiveInstallsConfiguration.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/DataManager.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/internal/DefaultActiveInstallsConfiguration.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/internal/DefaultDataManager.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/script/ActiveInstallsScriptService.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/test/it/org/xwiki/activeinstalls2/internal/PingSenderIT.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/test/java/org/xwiki/activeinstalls2/ActiveInstallsConfigurationTest.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/test/java/org/xwiki/activeinstalls2/internal/DefaultActiveInstallsConfigurationTest.java M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/test/java/org/xwiki/activeinstalls2/script/ActiveInstallsScriptServiceTest.java M xwiki-platform-tools/xwiki-platform-tool-configuration-resources/src/main/resources/xwiki.properties.vm Log Message: ----------- XWIKI-24710: Add script APIs to count distinct active installs globally and per extension * Make the per-extension cardinality precision threshold configurable through the new activeinstalls2.extensionInstanceCountPrecisionThreshold property, so that the counts of the most widely installed extensions can be kept exact as the install base grows without waiting for a release. The global count keeps the hardcoded 40000, which is the maximum Elasticsearch supports. * Clamp both configured values in DefaultDataManager rather than only in DefaultActiveInstallsConfiguration, since any implementation of the ActiveInstallsConfiguration role can be injected there and an out-of-range value would overflow the over-request or be rejected by Elasticsearch. * Return a SequencedMap from countDistinctInstallsByExtension(), so that the documented bucket ordering is part of the type rather than only of the Javadoc. * Drop TooManyExtensionsException from the throws clauses, where it is redundant with the Exception it extends, and document it with @throws instead. * Share the wrapper-query construction between countInstalls() and the search requests. * Document the query restricting a count to the instances that are actually active on the DataManager methods, which counted over the whole index otherwise. * Document both ends of the maxExtensionCountPerQuery clamping in xwiki.properties. * Split the phase invalidating the single-instance fixture out of PingSenderIT#sendPingData() into its own @Order(2) test, so that the dependency between the two is enforced rather than only commented. * Raise the non-integration-tests instruction ratio from 0.11 to 0.12, the module now being at 0.12394 without the IT and 0.9256 with it. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-docker] 4f9836: XDOCKER-18: Automate updating the stable version
by XWiki Notifications 26 Aug '26

26 Aug '26

Branch: refs/heads/XDOCKER-18-automate-docker-images-release Home: https://github.com/xwiki/xwiki-docker Commit: 4f98360bf634919b588bcd62b05d4d8e70523f98 https://github.com/xwiki/xwiki-docker/commit/4f98360bf634919b588bcd62b05d4d… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-26 (Wed, 26 Aug 2026) Changed paths: M README.md M gradle/helpers.gradle M gradle/official-image.gradle M gradle/run-instances.gradle Log Message: ----------- XDOCKER-18: Automate updating the stable version * Default 'stream' to running in the project directory, as 'capture' and 'exitCode' already do. A process inherits the working directory of the JVM that starts it, which for a Gradle build is the daemon's and therefore not something a script gets to assume. Every command run through it passes one today, so this only ever matters for the next one written without. * Validate the '-Pcycles' and '-Pvariants' entries against the cycles and variants that exist, the way '-PbasePort' and '-PtargetRepo' already validate theirs. Both ways of getting them wrong were silent: an empty value ('-Pcycles' with nothing after it) left an empty list, which every caller reads as "no selection" and therefore as "all of them" - the opposite of narrowing anything down - and a typo such as '-Pvariants=mysql' surfaced only later as a missing directory, naming a path rather than the property that named it. The message lists the available values, which is what whoever got it wrong is looking for. * Establish the submission guards before '-PdryRun' returns rather than after it. "Am I ready to submit?" is what a dry run is reached for, and answering only "here is what the file would look like" left the release manager to discover a dirty tree, an unpushed HEAD or a red Docker Build run on the real invocation instead. A dry run reports them and still succeeds where a real one fails on them, since the natural moment to preview the file is right after './gradlew release', with the regenerated tree not yet committed. * Collect those reasons instead of throwing on the first, so that one run names everything that is in the way. 'checkImagesBuild' returns its reason rather than raising it, for the same purpose. * Check for a Pull Request still open from the working branch in a rehearsal too. Unlike the guards on what is reachable upstream, that one is about not destroying something on the target, which a target of your own has just as much of. * Say in the Docker Build check why looking at the most recent runs alone is enough for the two questions it asks. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-docker/settings/notifications

1 0