- notifications - lists.xwiki.org

[xwiki/xwiki-platform] ab358f: XWIKI-24679: The cursor in CKEditor sometimes jump...
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/backport/stable-18.4.x/pr-6135 Home: https://github.com/xwiki/xwiki-platform Commit: ab358f09468d2be147aa292c3a354f9639b26f18 https://github.com/xwiki/xwiki-platform/commit/ab358f09468d2be147aa292c3a35… Author: Michael Hamann <michael.hamann(a)xwiki.com> Date: 2026-08-11 (Tue, 11 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-selection/plugin.js Log Message: ----------- XWIKI-24679: The cursor in CKEditor sometimes jumps to the start of the document (#6135) * Unlock the selection before focusing the editor to avoid an error when CKEditor restores the selection. This is okay because we restore the selection right after. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> (cherry picked from commit ba479f104a41bda6eaa697a95dd2a6c8a68d79dd) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] e403ae: XWIKI-24679: The cursor in CKEditor sometimes jump...
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/backport/stable-17.10.x/pr-6135 Home: https://github.com/xwiki/xwiki-platform Commit: e403ae834bc2ed56010edc2f0e5f6f75ce4b198a https://github.com/xwiki/xwiki-platform/commit/e403ae834bc2ed56010edc2f0e5f… Author: Michael Hamann <michael.hamann(a)xwiki.com> Date: 2026-08-11 (Tue, 11 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-selection/plugin.js Log Message: ----------- XWIKI-24679: The cursor in CKEditor sometimes jumps to the start of the document (#6135) * Unlock the selection before focusing the editor to avoid an error when CKEditor restores the selection. This is okay because we restore the selection right after. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> (cherry picked from commit ba479f104a41bda6eaa697a95dd2a6c8a68d79dd) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] ba479f: XWIKI-24679: The cursor in CKEditor sometimes jump...
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: ba479f104a41bda6eaa697a95dd2a6c8a68d79dd https://github.com/xwiki/xwiki-platform/commit/ba479f104a41bda6eaa697a95dd2… Author: Michael Hamann <michael.hamann(a)xwiki.com> Date: 2026-08-11 (Tue, 11 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-plugins/src/main/webjar/xwiki-selection/plugin.js Log Message: ----------- XWIKI-24679: The cursor in CKEditor sometimes jumps to the start of the document (#6135) * Unlock the selection before focusing the editor to avoid an error when CKEditor restores the selection. This is okay because we restore the selection right after. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 747dac: XWIKI-24283: org.xwiki.blocknote.test.ui.AllIT$Nes...
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 747dac9b9a84138d8823bf8840c95e61ec9e4755 https://github.com/xwiki/xwiki-platform/commit/747dac9b9a84138d8823bf8840c9… Author: Michael Hamann <michael.hamann(a)xwiki.com> Date: 2026-08-11 (Tue, 11 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-blocknote/xwiki-platform-blocknote-test/xwiki-platform-blocknote-test-docker/src/test/it/org/xwiki/blocknote/test/ui/ImageIT.java M xwiki-platform-core/xwiki-platform-blocknote/xwiki-platform-blocknote-test/xwiki-platform-blocknote-test-pageobjects/src/main/java/org/xwiki/blocknote/test/po/BlockNoteRichTextArea.java M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-test/xwiki-platform-wysiwyg-test-pageobjects/src/main/java/org/xwiki/wysiwyg/test/po/image/select/ImageDialogUploadSelectForm.java M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-ui/src/main/resources/XWiki/WYSIWYG/ImageSelectorServiceUIX/Upload.xml Log Message: ----------- XWIKI-24283: org.xwiki.blocknote.test.ui.AllIT$NestedImageIT#editImage is flickering (#6130) * Wait until the image is loaded before asserting its height. * Change how the upload button is enabled: disable it by default, enable it in JavaScript. * Let the JavaScript code for the upload button return early when there is no upload form. * Prevent an actual submit of the form as this is never desired. This is close to having impact on actual users, but I doubt that the timing of selecting a file before the JavaScript handler is bound can be achieved by a human. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[[email protected]][Issue] Updates for XWIKI-24680: Renaming an attachment without changing its location deletes the attachment
by XWiki Notifications 11 Aug '26

11 Aug '26

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/backport/stable-18.4.x/pr-6136 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 47b5a3: XWIKI-24680: Renaming an attachment without changi...
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/stable-18.4.x Home: https://github.com/xwiki/xwiki-platform Commit: 47b5a370dfd638f01510d414ebbb1680836c4597 https://github.com/xwiki/xwiki-platform/commit/47b5a370dfd638f01510d414ebbb… Author: github-actions[bot] <41898282+github-actions[bot](a)users.noreply.github.com> Date: 2026-08-11 (Tue, 11 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-api/pom.xml M xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-api/src/main/java/org/xwiki/attachment/internal/refactoring/job/MoveAttachmentJob.java M xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-api/src/test/java/org/xwiki/attachment/internal/refactoring/job/MoveAttachmentJobTest.java M xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-test/xwiki-platform-attachment-test-docker/src/test/it/org/xwiki/attachment/test/ui/docker/MoveAttachmentIT.java Log Message: ----------- XWIKI-24680: Renaming an attachment without changing its location deletes the attachment (#6136) (#6143) * XWIKI-24680: Renaming an attachment without changing its location deletes the attachment * Use a single document instance when the source and the destination of the move are the same document, so that the renamed attachment is added to the instance that is saved instead of to a discarded clone. * Convert MoveAttachmentJobTest to @OldcoreTest so that the job loads, modifies and saves actual XWikiDocument instances through the store, and assert what the job persists rather than which mock it interacts with. * Add a functional test renaming an attachment without changing its location, a case that was only ever covered in combination with a move to another page. * XWIKI-24680: Renaming an attachment without changing its location deletes the attachment * Restore the assertions on the calls performed by the job that the conversion to @OldcoreTest had dropped: which document is saved with which comment, that the rolled back document is saved with the rollback comment, which document the existing redirection is removed from, and that no document is saved at all when the rights are missing. * Assert that the job leaves the document instance held by the store untouched, which is what the verifications on XWikiDocument#clone() used to cover. * Resolve the document authors with the real user reference components instead of mocking the resolver, since the previous assertion on GuestUserReference held even when no author was set. * Assert the redirection object in the test covering the failure to save the target document. * Perform the rename of the functional test with a different user than the one who uploaded the attachment, and assert that the rename preserves the attachment author, version and history while the document author becomes the user performing the rename. * Assert that the redirection created by the rename is effective and not merely recorded, by downloading the attachment under its old name. * Drop the page reload that immediately followed the creation of the page in the rename test. --------- (cherry picked from commit 86fd126316cb0bcbbd9fcd68b43c9e45b4acc533) Co-authored-by: Vincent Massol <vincent(a)massol.net> Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/backport/stable-17.10.x/pr-6136 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 68591f: XWIKI-24680: Renaming an attachment without changi...
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/stable-17.10.x Home: https://github.com/xwiki/xwiki-platform Commit: 68591f4a0aa724c6202dc265b658ce24632f8ba5 https://github.com/xwiki/xwiki-platform/commit/68591f4a0aa724c6202dc265b658… Author: github-actions[bot] <41898282+github-actions[bot](a)users.noreply.github.com> Date: 2026-08-11 (Tue, 11 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-api/pom.xml M xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-api/src/main/java/org/xwiki/attachment/internal/refactoring/job/MoveAttachmentJob.java M xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-api/src/test/java/org/xwiki/attachment/internal/refactoring/job/MoveAttachmentJobTest.java M xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-test/xwiki-platform-attachment-test-docker/src/test/it/org/xwiki/attachment/test/ui/docker/MoveAttachmentIT.java Log Message: ----------- XWIKI-24680: Renaming an attachment without changing its location deletes the attachment (#6136) (#6142) * XWIKI-24680: Renaming an attachment without changing its location deletes the attachment * Use a single document instance when the source and the destination of the move are the same document, so that the renamed attachment is added to the instance that is saved instead of to a discarded clone. * Convert MoveAttachmentJobTest to @OldcoreTest so that the job loads, modifies and saves actual XWikiDocument instances through the store, and assert what the job persists rather than which mock it interacts with. * Add a functional test renaming an attachment without changing its location, a case that was only ever covered in combination with a move to another page. * XWIKI-24680: Renaming an attachment without changing its location deletes the attachment * Restore the assertions on the calls performed by the job that the conversion to @OldcoreTest had dropped: which document is saved with which comment, that the rolled back document is saved with the rollback comment, which document the existing redirection is removed from, and that no document is saved at all when the rights are missing. * Assert that the job leaves the document instance held by the store untouched, which is what the verifications on XWikiDocument#clone() used to cover. * Resolve the document authors with the real user reference components instead of mocking the resolver, since the previous assertion on GuestUserReference held even when no author was set. * Assert the redirection object in the test covering the failure to save the target document. * Perform the rename of the functional test with a different user than the one who uploaded the attachment, and assert that the rename preserves the attachment author, version and history while the document author becomes the user performing the rename. * Assert that the redirection created by the rename is effective and not merely recorded, by downloading the attachment under its old name. * Drop the page reload that immediately followed the creation of the page in the rename test. --------- (cherry picked from commit 86fd126316cb0bcbbd9fcd68b43c9e45b4acc533) Co-authored-by: Vincent Massol <vincent(a)massol.net> Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] e86f1f: XWIKI-24680: Renaming an attachment without changi...
by XWiki Notifications 11 Aug '26

11 Aug '26

Branch: refs/heads/backport/stable-18.4.x/pr-6136 Home: https://github.com/xwiki/xwiki-platform Commit: e86f1f46858fab082ec5bf5c30e9451a95d320b3 https://github.com/xwiki/xwiki-platform/commit/e86f1f46858fab082ec5bf5c30e9… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-11 (Tue, 11 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-api/pom.xml M xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-api/src/main/java/org/xwiki/attachment/internal/refactoring/job/MoveAttachmentJob.java M xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-api/src/test/java/org/xwiki/attachment/internal/refactoring/job/MoveAttachmentJobTest.java M xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-test/xwiki-platform-attachment-test-docker/src/test/it/org/xwiki/attachment/test/ui/docker/MoveAttachmentIT.java Log Message: ----------- XWIKI-24680: Renaming an attachment without changing its location deletes the attachment (#6136) * XWIKI-24680: Renaming an attachment without changing its location deletes the attachment * Use a single document instance when the source and the destination of the move are the same document, so that the renamed attachment is added to the instance that is saved instead of to a discarded clone. * Convert MoveAttachmentJobTest to @OldcoreTest so that the job loads, modifies and saves actual XWikiDocument instances through the store, and assert what the job persists rather than which mock it interacts with. * Add a functional test renaming an attachment without changing its location, a case that was only ever covered in combination with a move to another page. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> * XWIKI-24680: Renaming an attachment without changing its location deletes the attachment * Restore the assertions on the calls performed by the job that the conversion to @OldcoreTest had dropped: which document is saved with which comment, that the rolled back document is saved with the rollback comment, which document the existing redirection is removed from, and that no document is saved at all when the rights are missing. * Assert that the job leaves the document instance held by the store untouched, which is what the verifications on XWikiDocument#clone() used to cover. * Resolve the document authors with the real user reference components instead of mocking the resolver, since the previous assertion on GuestUserReference held even when no author was set. * Assert the redirection object in the test covering the failure to save the target document. * Perform the rename of the functional test with a different user than the one who uploaded the attachment, and assert that the rename preserves the attachment author, version and history while the document author becomes the user performing the rename. * Assert that the redirection created by the rename is effective and not merely recorded, by downloading the attachment under its old name. * Drop the page reload that immediately followed the creation of the page in the rename test. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> (cherry picked from commit 86fd126316cb0bcbbd9fcd68b43c9e45b4acc533) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0