- notifications - lists.xwiki.org

[xwiki/xwiki-commons] 9e35ab: [Misc] Apply the logging best practices: root caus...
by XWiki Notifications 03 Aug '26

03 Aug '26

Branch: refs/heads/misc-logging-commons Home: https://github.com/xwiki/xwiki-commons Commit: 9e35ab25499010f26bf41f6fafa13082224f1cec https://github.com/xwiki/xwiki-commons/commit/9e35ab25499010f26bf41f6fafa13… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-03 (Mon, 03 Aug 2026) Changed paths: M xwiki-commons-core/xwiki-commons-component/xwiki-commons-component-default/src/main/java/org/xwiki/component/annotation/ComponentAnnotationLoader.java M xwiki-commons-core/xwiki-commons-component/xwiki-commons-component-default/src/main/java/org/xwiki/component/embed/EmbeddableComponentManager.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/repository/internal/RepositoryUtils.java M xwiki-commons-core/xwiki-commons-filter/xwiki-commons-filter-xml/src/main/java/org/xwiki/filter/xml/internal/parser/DefaultXMLParser.java M xwiki-commons-core/xwiki-commons-job/xwiki-commons-job-api/src/main/java/org/xwiki/job/internal/DefaultJobProgress.java M xwiki-commons-core/xwiki-commons-velocity/src/main/java/org/xwiki/velocity/tools/EscapeTool.java M xwiki-commons-core/xwiki-commons-velocity/src/test/java/org/xwiki/velocity/tools/EscapeToolTest.java M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/XMLUtils.java M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/XMLUtilsTest.java M xwiki-commons-tools/xwiki-commons-tool-test/xwiki-commons-tool-test-simple/src/main/java/org/xwiki/test/junit5/RuntimeUtils.java Log Message: ----------- [Misc] Apply the logging best practices: root cause in warn(), no explicit toString(), static final Logger Runs the six-pass logging audit from xwiki-platform over xwiki-commons. What #1867 left, in 12 sites: * warn(..., e.getMessage()) x5 (EscapeTool, XMLUtils x4) -> getRootCauseMessage(), which surfaces the underlying cause instead of the wrapper's message. The new rendering is shorter and names the class: [WrappedRuntimeException: Invalid url protocol: file] where it used to repeat the whole wrapper chain. * An explicit .toString() on a placeholder argument x4 (ComponentAnnotationLoader, RepositoryUtils, DefaultJobProgress x2). SLF4J calls toString() itself, so this is redundant, eager, and NPEs on a null where SLF4J would render "null" -- and both DefaultJobProgress sites are on the branch taken precisely because the source could not be matched. * DefaultXMLParser dropped its ConversionException entirely, so nothing said why the conversion failed. * EmbeddableComponentManager built a new Logger per instance (neither static nor final). It is now private static final LOGGER next to the SHUTDOWN_LOGGER already in that class. * RuntimeUtils assembled its message with String.format() into a local, so the call site had no literal at all; the local stays because the return value needs it, only the log call is parameterized. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-rendering] 6db8fd: [Misc] Apply the logging best practices: don't dro...
by XWiki Notifications 03 Aug '26

03 Aug '26

Branch: refs/heads/misc-logging-rendering Home: https://github.com/xwiki/xwiki-rendering Commit: 6db8fdadca3ce680e09dff7e939eea508934d10c https://github.com/xwiki/xwiki-rendering/commit/6db8fdadca3ce680e09dff7e939… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-03 (Mon, 03 Aug 2026) Changed paths: M xwiki-rendering-transformations/xwiki-rendering-transformation-linkchecker/src/main/java/org/xwiki/rendering/internal/transformation/linkchecker/DefaultLinkCheckerThread.java M xwiki-rendering-transformations/xwiki-rendering-transformation-linkchecker/src/test/java/org/xwiki/rendering/internal/transformation/linkchecker/LinkCheckerThreadTest.java M xwiki-rendering-transformations/xwiki-rendering-transformation-macro/src/main/java/org/xwiki/rendering/internal/macro/DefaultMacroManager.java M xwiki-rendering-transformations/xwiki-rendering-transformation-macro/src/test/java/org/xwiki/rendering/internal/macro/DefaultMacroManagerTest.java Log Message: ----------- [Misc] Apply the logging best practices: don't drop the caught exception in a warn() First pass of the xwiki-platform logging audit over xwiki-rendering. Two warn() calls inside a catch never mentioned the exception they were holding, so the reason the operation failed reached no log at all. warn() must not print a stack trace, so the cause goes into a placeholder as ExceptionUtils.getRootCauseMessage(e). Everything else the audit's detector reports in this repo is a non-violation and is recorded in the PR description: the four isDebugEnabled() guards in BlockStateChainingListener (they also skip a `new IllegalStateException()`, which captures a stack trace, so removing them would pay that on every event) and JspWikiSerializer's System.out (an output sink, not logging). Also fixes "continnue" in the comment right above the link-checker change. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 03 Aug '26

03 Aug '26

Branch: refs/heads/misc-typos-batch16 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 46b163: [Misc] Fix misspellings in the remaining front-end...
by XWiki Notifications 03 Aug '26

03 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 46b163a07c11c90ad0306527925790e07fb4716f https://github.com/xwiki/xwiki-platform/commit/46b163a07c11c90ad03065279257… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-03 (Mon, 03 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-blocknote/xwiki-platform-blocknote-webjar/src/main/node/src/services/macros/MacroWizard.ts M xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-test/xwiki-platform-export-pdf-test-content/pom.xml M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-designsystem-webjar/src/main/node/src/vue/style.css M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/less/edit.less M xwiki-platform-core/xwiki-platform-logging/pom.xml M xwiki-platform-core/xwiki-platform-node/src/main/node/core/attachments/attachments-default/src/__tests__/defaultAttachmentsService.test.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/collaboration/collaboration-xwiki/src/xwikiProviderWebSocket.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/fn-utils/src/index.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/link-modal/link-modal-ui/src/data/linkType.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/link-modal/link-modal-ui/src/vue/SearchBox.vue M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-api/src/logic.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-api/src/queryConstraint.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/LivedataPersistentConfiguration.vue M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/displayers/BaseDisplayer.test.js M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/filters/LivedataFilter.vue M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/filters/filterMixin.js M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/layouts/LivedataLayout.vue M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/layouts/table/LayoutTableRow.vue M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/panels/LivedataAdvancedPanelFilter.vue M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/services/jsonMerge.test.js M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/utilities/XWikiLoader.vue M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-xwiki/src/liveDataSource.test.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/macros/macros-api/src/index.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/macros/macros-ast-react-jsx/src/converter.tsx M xwiki-platform-core/xwiki-platform-node/src/main/node/editors/blocknote-react/src/__tests__/playwright-ct/BlockNote.spec.tsx M xwiki-platform-core/xwiki-platform-node/src/main/node/editors/blocknote-react/src/components/files/FilePanel.tsx M xwiki-platform-core/xwiki-platform-oldcore/pom.xml M xwiki-platform-core/xwiki-platform-oldcore/src/main/resources/xwiki.oracle.hbm.xml M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-webjar/src/main/webjar/saver.js M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-webjar/src/main/webjar/toolbar.js M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-wysiwyg/xwiki-platform-realtime-wysiwyg-webjar/src/main/webjar/wysiwygEditor.js M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-server/xwiki-platform-search-solr-server-core-search/pom.xml M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-server/xwiki-platform-search-solr-server-core-search/src/main/resources/conf/managed-schema.xml M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-webjar/src/main/webjar/searchSuggest.js M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/resources/logback.xml M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-test/xwiki-platform-wiki-test-docker/src/test/resources/logback-override.xml M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-test/xwiki-platform-wiki-test-docker/src/test/webapp/WEB-INF/classes/logback.xml M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-webjar/src/main/webjar/image/imageEditor.js M xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-data/pom.xml M xwiki-platform-tools/xwiki-platform-tool-xmldoc-update-plugin/pom.xml Log Message: ----------- [Misc] Fix misspellings in the remaining front-end sources, poms and XML configuration (#6082) Closes the source spelling sweep started in #6079: the 53 remaining sites, over the Vue/TypeScript packages of xwiki-platform-node, the webjar JavaScript, the LESS/CSS, the Maven poms and the non-XAR XML (logback, Hibernate mappings, the Solr schema). All but three are comments. The three string literals are two Vue/Playwright test titles and one assertion-failure message, none of them asserted on anywhere. Deliberately left alone: * the What's New blogrss fixtures, which are recorded captures of the real xwiki.org feed, so their "improvments" belongs to the captured blog post; * "SortableTextField generaly functions" in managed-schema.xml, which is Solr's own sentence in a file we sync from upstream (the two "XWiki:" comments in the same file are ours and are fixed). Three hand fixes the dictionary could not make: "doen't" is "doesn't" and not codespell's "done't", and the two "form fiels" next to the rewrapped comment in toolbar.js are "fields" (codespell drops that word as ambiguous). Two comment lines that a correction pushed past 120 characters were rewrapped. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki-contrib/cristal-integration] d8887c: CRISTALINT-33: Upgrade to Cristal 1.6.1 (#197)
by XWiki Notifications 03 Aug '26

03 Aug '26

Branch: refs/heads/main Home: https://github.com/xwiki-contrib/cristal-integration Commit: d8887c349c94ad2bbf00ac55ceca0ca776ac158e https://github.com/xwiki-contrib/cristal-integration/commit/d8887c349c94ad2… Author: Pierre Jeanjean <pierre.jeanjean(a)xwiki.com> Date: 2026-08-03 (Mon, 03 Aug 2026) Changed paths: M cristal-integration-webjar/src/main/node/package.json M cristal-integration-webjar/src/main/node/pnpm-lock.yaml Log Message: ----------- CRISTALINT-33: Upgrade to Cristal 1.6.1 (#197) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/cristal-integration/settings/notifications

1 0

[xwiki/xwiki-platform] 00d2d5: [Misc] Fix misspellings in the remaining front-end...
by XWiki Notifications 03 Aug '26

03 Aug '26

Branch: refs/heads/misc-typos-batch16 Home: https://github.com/xwiki/xwiki-platform Commit: 00d2d5bd8b0c4e3ca3bb7f8f9bf6edf5dd4a11c4 https://github.com/xwiki/xwiki-platform/commit/00d2d5bd8b0c4e3ca3bb7f8f9bf6… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-03 (Mon, 03 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-blocknote/xwiki-platform-blocknote-webjar/src/main/node/src/services/macros/MacroWizard.ts M xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-test/xwiki-platform-export-pdf-test-content/pom.xml M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-designsystem-webjar/src/main/node/src/vue/style.css M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/less/edit.less M xwiki-platform-core/xwiki-platform-logging/pom.xml M xwiki-platform-core/xwiki-platform-node/src/main/node/core/attachments/attachments-default/src/__tests__/defaultAttachmentsService.test.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/collaboration/collaboration-xwiki/src/xwikiProviderWebSocket.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/fn-utils/src/index.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/link-modal/link-modal-ui/src/data/linkType.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/link-modal/link-modal-ui/src/vue/SearchBox.vue M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-api/src/logic.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-api/src/queryConstraint.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/LivedataPersistentConfiguration.vue M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/displayers/BaseDisplayer.test.js M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/filters/LivedataFilter.vue M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/filters/filterMixin.js M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/layouts/LivedataLayout.vue M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/layouts/table/LayoutTableRow.vue M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/panels/LivedataAdvancedPanelFilter.vue M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/services/jsonMerge.test.js M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-ui/src/components/utilities/XWikiLoader.vue M xwiki-platform-core/xwiki-platform-node/src/main/node/core/livedata/livedata-xwiki/src/liveDataSource.test.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/macros/macros-api/src/index.ts M xwiki-platform-core/xwiki-platform-node/src/main/node/core/macros/macros-ast-react-jsx/src/converter.tsx M xwiki-platform-core/xwiki-platform-node/src/main/node/editors/blocknote-react/src/__tests__/playwright-ct/BlockNote.spec.tsx M xwiki-platform-core/xwiki-platform-node/src/main/node/editors/blocknote-react/src/components/files/FilePanel.tsx M xwiki-platform-core/xwiki-platform-oldcore/pom.xml M xwiki-platform-core/xwiki-platform-oldcore/src/main/resources/xwiki.oracle.hbm.xml M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-webjar/src/main/webjar/saver.js M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-webjar/src/main/webjar/toolbar.js M xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-wysiwyg/xwiki-platform-realtime-wysiwyg-webjar/src/main/webjar/wysiwygEditor.js M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-server/xwiki-platform-search-solr-server-core-search/pom.xml M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-server/xwiki-platform-search-solr-server-core-search/src/main/resources/conf/managed-schema.xml M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-webjar/src/main/webjar/searchSuggest.js M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/resources/logback.xml M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-test/xwiki-platform-wiki-test-docker/src/test/resources/logback-override.xml M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-test/xwiki-platform-wiki-test-docker/src/test/webapp/WEB-INF/classes/logback.xml M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-webjar/src/main/webjar/image/imageEditor.js M xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-data/pom.xml M xwiki-platform-tools/xwiki-platform-tool-xmldoc-update-plugin/pom.xml Log Message: ----------- [Misc] Fix misspellings in the remaining front-end sources, poms and XML configuration Closes the source spelling sweep started in #6079: the 53 remaining sites, over the Vue/TypeScript packages of xwiki-platform-node, the webjar JavaScript, the LESS/CSS, the Maven poms and the non-XAR XML (logback, Hibernate mappings, the Solr schema). All but three are comments. The three string literals are two Vue/Playwright test titles and one assertion-failure message, none of them asserted on anywhere. Deliberately left alone: * the What's New blogrss fixtures, which are recorded captures of the real xwiki.org feed, so their "improvments" belongs to the captured blog post; * "SortableTextField generaly functions" in managed-schema.xml, which is Solr's own sentence in a file we sync from upstream (the two "XWiki:" comments in the same file are ours and are fixed). Three hand fixes the dictionary could not make: "doen't" is "doesn't" and not codespell's "done't", and the two "form fiels" next to the rewrapped comment in toolbar.js are "fields" (codespell drops that word as ambiguous). Two comment lines that a correction pushed past 120 characters were rewrapped. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki-contrib/cristal-integration] 1bd556: CRISTALINT-33: Upgrade to Cristal 1.6.1
by XWiki Notifications 03 Aug '26

03 Aug '26

Branch: refs/heads/CRISTALINT-33 Home: https://github.com/xwiki-contrib/cristal-integration Commit: 1bd556b3b4fa44ed984db2a22982743cd9bda370 https://github.com/xwiki-contrib/cristal-integration/commit/1bd556b3b4fa44e… Author: Pierre Jeanjean <pierre.jeanjean(a)xwiki.com> Date: 2026-08-03 (Mon, 03 Aug 2026) Changed paths: M cristal-integration-webjar/src/main/node/package.json M cristal-integration-webjar/src/main/node/pnpm-lock.yaml Log Message: ----------- CRISTALINT-33: Upgrade to Cristal 1.6.1 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/cristal-integration/settings/notifications

1 0

[xwiki-contrib/cristal-integration] 36a446: Upgrade to Cristal 1.6.1
by XWiki Notifications 03 Aug '26

03 Aug '26

Branch: refs/heads/CRISTALINT-33 Home: https://github.com/xwiki-contrib/cristal-integration Commit: 36a446cd85a99b303d29814fe25db4b94fa32eaa https://github.com/xwiki-contrib/cristal-integration/commit/36a446cd85a99b3… Author: Pierre Jeanjean <pierre.jeanjean(a)xwiki.com> Date: 2026-08-03 (Mon, 03 Aug 2026) Changed paths: M cristal-integration-webjar/src/main/node/package.json M cristal-integration-webjar/src/main/node/pnpm-lock.yaml Log Message: ----------- Upgrade to Cristal 1.6.1 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/cristal-integration/settings/notifications

1 0

[xwiki/xwiki-platform] 0ee842: [Misc] Fix broken build after logging refactorings
by XWiki Notifications 03 Aug '26

03 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 0ee84274bfcda6e2d84f00f8bec5f9a009e2923b https://github.com/xwiki/xwiki-platform/commit/0ee84274bfcda6e2d84f00f8bec5… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-03 (Mon, 03 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-filter/xwiki-platform-filter-instance/xwiki-platform-filter-instance-api/src/main/java/org/xwiki/filter/instance/internal/output/InstanceOutputFilterStreamFactory.java Log Message: ----------- [Misc] Fix broken build after logging refactorings To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[[email protected]][Issue] Updates for CRISTALINT-33: Upgrade to Cristal 1.6.1
by XWiki Notifications 03 Aug '26

03 Aug '26

1 0