- notifications - lists.xwiki.org

[xwiki/xwiki-platform]
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-search Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] c968a9: [Misc] Apply the logging best practices to xwiki-p...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: c968a934eb7fe00a8d4c35e8ed8babf96bdc1ff4 https://github.com/xwiki/xwiki-platform/commit/c968a934eb7fe00a8d4c35e8ed8b… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/DefaultSolrIndexer.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/IndexingUserConfigurationInitializer.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/job/IndexerJob.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/reference/DefaultSolrReferenceResolver.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/reference/DocumentSolrReferenceResolver.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/reference/ObjectSolrReferenceResolver.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/reference/SpaceSolrReferenceResolver.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/reference/WikiSolrReferenceResolver.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/test/java/org/xwiki/search/solr/internal/job/IndexerJobTest.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-embedded/src/main/java/org/xwiki/search/solr/internal/EmbeddedSolr.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-query/src/main/java/org/xwiki/query/solr/internal/SolrQueryExecutor.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-query/src/main/java/org/xwiki/query/solr/internal/SolrSearchExclusionsQueryFilter.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-query/src/test/java/org/xwiki/query/solr/internal/SolrQueryExecutorTest.java Log Message: ----------- [Misc] Apply the logging best practices to xwiki-platform-search (#6058) Follows https://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HLo… Clears the 18 sites the logging audit found in xwiki-platform-search, of which 17 needed a change: * Replace string concatenation and String.format() in log messages with the parameterized SLF4J signatures. error() keeps its Throwable, so IndexingUserConfigurationInitializer still logs the stack trace it was using String.format() to preserve. * Surround placeholder values with [] so they are visually delimited. * Stop passing a Throwable to warn(), using ExceptionUtils.getRootCauseMessage() instead, so that stack traces stay reserved for errors. * Trim the trailing space before the stack trace logged by SolrSearchExclusionsQueryFilter. SolrQueryExecutorTest now distinguishes the two bad results it removes, since the root cause it logs names the failing document. AbstractSolrCoreInitializer is left alone: its unbracketed placeholder holds the " dynamic" sentence fragment rather than a datum. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-test Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] abb25f: [Misc] Apply the logging best practices to xwiki-p...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: abb25f5ac8f1aab19971c6afe48d6b2f8df194d1 https://github.com/xwiki/xwiki-platform/commit/abb25f5ac8f1aab19971c6afe48d… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/DockerTestUtils.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/StopFileWatcher.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/WARBuilder.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/XWikiDockerExtension.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/configuration/ConfigurationFilesGenerator.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/database/DatabaseContainerExecutor.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/servletengine/ServletContainerExecutor.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-integration/src/main/java/org/xwiki/test/integration/XWikiExecutorSuite.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-integration/src/main/java/org/xwiki/test/integration/maven/ArtifactResolver.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-integration/src/main/java/org/xwiki/test/integration/maven/DebuggingDependencyVisitor.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/TestDebugger.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/TestUtils.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/XWikiWebDriver.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/BasePage.java Log Message: ----------- [Misc] Apply the logging best practices to xwiki-platform-test (#6057) * [Misc] Apply the logging best practices to xwiki-platform-test Follows https://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HLo… Clears the 39 sites the logging audit found in xwiki-platform-test, of which 25 needed a change: * Surround placeholder values with [] so they are visually delimited. * Stop passing a Throwable to warn(), using ExceptionUtils.getRootCauseMessage() instead, so that stack traces stay reserved for errors. In XWikiWebDriver the warning logs a synthetic exception only to capture the wasteful findElement() caller, so the stack trace is the whole payload: it moves into a "Call stack is [{}]" placeholder via ExceptionUtils.getStackTrace() rather than being dropped. * Replace the indentation prefix concatenated into DebuggingDependencyVisitor's message with a leading {} placeholder. * Trim the trailing space before the stack trace logged by BasePage. DockerTestUtils used the Plexus ExceptionUtils, which has no getRootCauseMessage(); it now uses the Commons Lang one, whose getRootCause() serves the existing EOFException check just as well. The 14 remaining sites are deliberately left alone, per the audit's own exclusions: values that already bracket themselves (a List in WARBuilder, a Collection in RestExtensionInstaller, the script result in TestUtils, the [\n{}\n] blocks in LogCaptureValidator), the compound [{} : {}] and [{}/{}] identifiers in the WCAG classes and BasePage, MavenResolver's ModelProblem.getMessage() which is not an exception message, and the warn() with a stack trace in ValidateConsoleExtensionTest, which is the fixture the test validates. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> * [Misc] Keep the call stack in the two TestUtils warnings Both warnings are emitted from helpers that arbitrary test code calls, so the caller frame is what tells you which test tripped them. Reducing them to a root-cause message dropped exactly that. They now log the full trace through a "Call stack is [{}]" placeholder, like the wasteful-wait warning in XWikiWebDriver, so the location is still there while warn() keeps the SLF4J Throwable slot free. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 7a51e8: [Misc] Keep the call stack in the two TestUtils wa...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-test Home: https://github.com/xwiki/xwiki-platform Commit: 7a51e8cbc40a1c602d9d3471120094eea226a83d https://github.com/xwiki/xwiki-platform/commit/7a51e8cbc40a1c602d9d34711200… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/TestUtils.java Log Message: ----------- [Misc] Keep the call stack in the two TestUtils warnings Both warnings are emitted from helpers that arbitrary test code calls, so the caller frame is what tells you which test tripped them. Reducing them to a root-cause message dropped exactly that. They now log the full trace through a "Call stack is [{}]" placeholder, like the wasteful-wait warning in XWikiWebDriver, so the location is still there while warn() keeps the SLF4J Throwable slot free. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 493681: [Misc] Apply the logging best practices to xwiki-p...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-notifications Home: https://github.com/xwiki/xwiki-platform Commit: 493681f1bbe1f5caf24cb7a6bb325c34bdc32642 https://github.com/xwiki/xwiki-platform/commit/493681f1bbe1f5caf24cb7a6bb32… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/internal/DeletedDocumentCleanUpFilterProcessingQueue.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/internal/scope/ScopeNotificationFilter.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/internal/user/EventUserFilterPreferencesGetter.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/main/java/org/xwiki/notifications/filters/internal/migrators/ScopeNotificationFilterClassMigrator.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-watch/src/main/java/org/xwiki/notifications/filters/watch/internal/AutomaticWatchModeListener.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/main/java/org/xwiki/notifications/notifiers/internal/email/live/PrefilteringLiveNotificationEmailManager.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/main/java/org/xwiki/notifications/notifiers/internal/UserEventDispatcher.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/main/java/org/xwiki/notifications/notifiers/internal/UserEventManager.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/main/java/org/xwiki/notifications/notifiers/internal/email/AbstractMimeMessageIterator.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/main/java/org/xwiki/notifications/notifiers/internal/email/UserAvatarAttachmentExtractor.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-preferences/xwiki-platform-notifications-preferences-api/src/main/java/org/xwiki/notifications/preferences/internal/DefaultNotificationPreferenceManager.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-preferences/xwiki-platform-notifications-preferences-default/src/main/java/org/xwiki/notifications/preferences/internal/email/DefaultNotificationEmailUserPreferenceManager.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-sources/src/main/java/org/xwiki/notifications/sources/internal/TagNotificationFilter.java Log Message: ----------- [Misc] Apply the logging best practices to xwiki-platform-notifications Follows https://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HLo… Clears the 17 sites the logging audit found in xwiki-platform-notifications: * Stop passing a Throwable to warn(), using ExceptionUtils.getRootCauseMessage() instead, so that stack traces stay reserved for errors. * Surround placeholder values with [] so they are visually delimited. * Trim the trailing space before a logged value in ScopeNotificationFilter and before the stack trace in AbstractMimeMessageIterator. DefaultNotificationPreferenceManager passed the caught exception as a placeholder argument to error(), so it logged the exception's toString() and no stack trace at all; it now goes in the Throwable slot. The same message said "preference provide" rather than "preference provider". Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 8f99c0: [Misc] Apply the logging best practices to xwiki-p...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-search Home: https://github.com/xwiki/xwiki-platform Commit: 8f99c0b9831e33778d36de1af6a5de3fb4bc18ff https://github.com/xwiki/xwiki-platform/commit/8f99c0b9831e33778d36de1af6a5… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/DefaultSolrIndexer.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/IndexingUserConfigurationInitializer.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/job/IndexerJob.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/reference/DefaultSolrReferenceResolver.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/reference/DocumentSolrReferenceResolver.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/reference/ObjectSolrReferenceResolver.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/reference/SpaceSolrReferenceResolver.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/reference/WikiSolrReferenceResolver.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/test/java/org/xwiki/search/solr/internal/job/IndexerJobTest.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-embedded/src/main/java/org/xwiki/search/solr/internal/EmbeddedSolr.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-query/src/main/java/org/xwiki/query/solr/internal/SolrQueryExecutor.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-query/src/main/java/org/xwiki/query/solr/internal/SolrSearchExclusionsQueryFilter.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-query/src/test/java/org/xwiki/query/solr/internal/SolrQueryExecutorTest.java Log Message: ----------- [Misc] Apply the logging best practices to xwiki-platform-search Follows https://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HLo… Clears the 18 sites the logging audit found in xwiki-platform-search, of which 17 needed a change: * Replace string concatenation and String.format() in log messages with the parameterized SLF4J signatures. error() keeps its Throwable, so IndexingUserConfigurationInitializer still logs the stack trace it was using String.format() to preserve. * Surround placeholder values with [] so they are visually delimited. * Stop passing a Throwable to warn(), using ExceptionUtils.getRootCauseMessage() instead, so that stack traces stay reserved for errors. * Trim the trailing space before the stack trace logged by SolrSearchExclusionsQueryFilter. SolrQueryExecutorTest now distinguishes the two bad results it removes, since the root cause it logs names the failing document. AbstractSolrCoreInitializer is left alone: its unbracketed placeholder holds the " dynamic" sentence fragment rather than a datum. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 072679: [Misc] Apply the logging best practices to xwiki-p...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-test Home: https://github.com/xwiki/xwiki-platform Commit: 072679f55966dea5fb6c0513ce657390b728ed7d https://github.com/xwiki/xwiki-platform/commit/072679f55966dea5fb6c0513ce65… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/DockerTestUtils.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/StopFileWatcher.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/WARBuilder.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/XWikiDockerExtension.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/configuration/ConfigurationFilesGenerator.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/database/DatabaseContainerExecutor.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/servletengine/ServletContainerExecutor.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-integration/src/main/java/org/xwiki/test/integration/XWikiExecutorSuite.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-integration/src/main/java/org/xwiki/test/integration/maven/ArtifactResolver.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-integration/src/main/java/org/xwiki/test/integration/maven/DebuggingDependencyVisitor.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/TestDebugger.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/TestUtils.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/XWikiWebDriver.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/BasePage.java Log Message: ----------- [Misc] Apply the logging best practices to xwiki-platform-test Follows https://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HLo… Clears the 39 sites the logging audit found in xwiki-platform-test, of which 25 needed a change: * Surround placeholder values with [] so they are visually delimited. * Stop passing a Throwable to warn(), using ExceptionUtils.getRootCauseMessage() instead, so that stack traces stay reserved for errors. In XWikiWebDriver the warning logs a synthetic exception only to capture the wasteful findElement() caller, so the stack trace is the whole payload: it moves into a "Call stack is [{}]" placeholder via ExceptionUtils.getStackTrace() rather than being dropped. * Replace the indentation prefix concatenated into DebuggingDependencyVisitor's message with a leading {} placeholder. * Trim the trailing space before the stack trace logged by BasePage. DockerTestUtils used the Plexus ExceptionUtils, which has no getRootCauseMessage(); it now uses the Commons Lang one, whose getRootCause() serves the existing EOFException check just as well. The 14 remaining sites are deliberately left alone, per the audit's own exclusions: values that already bracket themselves (a List in WARBuilder, a Collection in RestExtensionInstaller, the script result in TestUtils, the [\n{}\n] blocks in LogCaptureValidator), the compound [{} : {}] and [{}/{}] identifiers in the WCAG classes and BasePage, MavenResolver's ModelProblem.getMessage() which is not an exception message, and the warn() with a stack trace in ValidateConsoleExtensionTest, which is the fixture the test validates. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/misc-logging-oldcore-finish Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 642bf7: [Misc] Finish applying the logging best practices ...
by XWiki Notifications 01 Aug '26

01 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 642bf7f4d32f91e2beaf4e36fe70248e610620ee https://github.com/xwiki/xwiki-platform/commit/642bf7f4d32f91e2beaf4e36fe70… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-01 (Sat, 01 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWikiContext.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/DeletedAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/DeletedDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/Document.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/rcs/XWikiRCSArchive.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/export/html/HtmlPackager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/DefaultCoreConfiguration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/context/XWikiContextContextStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/export/OfficeExporter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/fileupload/FileUploadUtils.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/mandatory/XWikiAllGroupDocumentInitializer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/pdf/FOPXSLFORenderer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/query/ConfiguredQueryExecutorProvider.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/render/DefaultOldRendering.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/sheet/AbstractSheetBinder.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/sheet/DefaultModelBridge.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/store/AbstractXWikiStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/monitor/api/MonitorData.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseCollection.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/DBTreeListClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/GroupsClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/UsersClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/FileSystemURLFactory.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/PdfExportImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/XWikiPluginManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/fileupload/FileUploadPlugin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/packaging/DocumentInfo.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/rightsmanager/RightsManagerListener.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/render/groovy/XWikiPageClassLoader.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/script/display/DisplayScriptService.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/stats/impl/StatsUtil.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/stats/impl/xwiki/RefererStatsStoreItem.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/stats/impl/xwiki/XWikiStatsStoreService.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateRecycleBinStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/hibernate/HibernateAttachmentRecycleBinStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/hibernate/HibernateAttachmentVersioningStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R140600000XWIKI19869DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R35102XWIKI7771DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R4359XWIKI1459DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/GroovyAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/util/Util.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/ObjectRemoveForm.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/UploadAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiMessageTool.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiURLFactoryServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/includeservletasstring/IncludeServletAsString.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/script/XWikiScriptContextInitializer.java Log Message: ----------- [Misc] Finish applying the logging best practices to xwiki-platform-oldcore (#6056) * [Misc] Finish applying the logging best practices to xwiki-platform-oldcore Follows https://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HLo… Clears the 112 remaining oldcore sites found by the logging audit: * Replace string concatenation and String.format() in log messages with the parameterized SLF4J signatures, which also removes the now-redundant isDebugEnabled()/isInfoEnabled()/isWarnEnabled()/isErrorEnabled() guards. * Surround placeholder values with [] so they are visually delimited. * Stop passing a Throwable to warn(), using ExceptionUtils.getRootCauseMessage() instead, so that stack traces stay reserved for errors. For the three warn() calls that log a synthetic exception only to capture the caller, the stack trace is the whole payload, so it moves into a "Call stack is [{}]" placeholder via ExceptionUtils.getStackTrace() rather than being dropped. * Replace e.getMessage() with ExceptionUtils.getRootCauseMessage(), which surfaces the underlying cause. * Trim the trailing space before a logged stack trace in XWikiAction. Along the way this fixes a few log statements that were wrong rather than just badly formatted: * XWikiAction and XWikiURLFactoryServiceImpl logged an unclosed "[" for the document being notified about. * XWikiURLFactoryServiceImpl and RefererStatsStoreItem swallowed the exception they had just caught; it is now passed to error(). * DeletedAttachment, DeletedDocument, api.XWiki, XWikiDocument, RightsManagerListener, FileUploadPlugin and UploadAction reported a failure without saying which entity it applied to; the identifier is now logged. * XWikiStatsStoreService logged the normal thread stop order at warn level inside an isInfoEnabled() guard, so it never showed; it is now a plain info(). * Typos: "Faield" -> "Failed", "statictics" -> "statistics", "versionning" -> "versioning". Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> * [Misc] Restore the isDebugEnabled() guards around the debug blocks that do work Follows https://dev.xwiki.org/xwiki/bin/view/Community/CodeStyle/JavaCodeStyle/#HLo… An isDebugEnabled() guard is redundant in front of a single parameterized log statement, but not in front of a block that computes something. Two such blocks lost their guard when the parameterized signatures were introduced: * MonitorData#log() iterates over all the timer summaries, so the iteration was paid on every call even with the debug level disabled. Also use a for-each loop instead of an explicit Iterator. * XWikiAuthServiceImpl#checkPassword() computes the elapsed validation time. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0