- notifications - lists.xwiki.org

[xwiki/xwiki-platform] a50c37: [Misc] Replace String concatenations with text blo...
by XWiki Notifications 23 Jul '26

23 Jul '26

Branch: refs/heads/claude/laughing-goodall-pklyu1-s6126 Home: https://github.com/xwiki/xwiki-platform Commit: a50c37fd2e17bd368607267e77b0d7cece9b775d https://github.com/xwiki/xwiki-platform/commit/a50c37fd2e17bd368607267e77b0… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-23 (Thu, 23 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-display/xwiki-platform-display-macro/src/test/java/org/xwiki/rendering/internal/macro/DisplayMacroTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-macros/xwiki-platform-rendering-macro-include/src/test/java/org/xwiki/rendering/internal/macro/include/IncludeMacroTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-store/src/test/java/org/xwiki/rendering/wikimacro/internal/DefaultWikiMacroTest.java Log Message: ----------- [Misc] Replace String concatenations with text blocks in tests (SonarCloud java:S6126) Convert multi-line String concatenations used as expected values in rendering macro unit tests to Java text blocks, as flagged by SonarCloud rule java:S6126. Purely a test-readability change: the produced strings are byte-identical (verified by the tests, which compare the exact expected output), and the now-redundant // @formatter:off / // @formatter:on markers wrapping only a converted literal are removed. 22 occurrences across IncludeMacroTest, DisplayMacroTest and DefaultWikiMacroTest. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 67c049: [Misc] Fix various SonarCloud issues (unused field...
by XWiki Notifications 23 Jul '26

23 Jul '26

Branch: refs/heads/claude/laughing-goodall-pklyu1 Home: https://github.com/xwiki/xwiki-platform Commit: 67c049b23952f65317fee5ca34f8f45a8be8ff39 https://github.com/xwiki/xwiki-platform/commit/67c049b23952f65317fee5ca34f8… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-23 (Thu, 23 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-io/src/main/java/org/xwiki/annotation/io/internal/DefaultIOService.java M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-io/src/main/java/org/xwiki/annotation/io/internal/migration/hibernate/R180600000XWIKI20699DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/filter/output/DocumentInstanceOutputFilterStream.java Log Message: ----------- [Misc] Fix various SonarCloud issues (unused field, collapsible if, Collectors.toList) Fix three SonarCloud issues: * java:S1068 - remove the unused private "currentLocaleParameters" field in DocumentInstanceOutputFilterStream * java:S1066 - merge a collapsible nested "if" in DefaultIOService * java:S6204 - replace Stream.collect(Collectors.toList()) with Stream.toList() in R180600000XWIKI20699DataMigration Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 22 Jul '26

22 Jul '26

Branch: refs/heads/backport/stable-18.4.x/misc-sonar-npe-guards Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 56fd0c: [Misc] Fix additional SonarQube-reported NPE risks...
by XWiki Notifications 22 Jul '26

22 Jul '26

Branch: refs/heads/stable-18.4.x Home: https://github.com/xwiki/xwiki-platform Commit: 56fd0c2206c1b11c28785dfb47c9f9f014e071d6 https://github.com/xwiki/xwiki-platform/commit/56fd0c2206c1b11c28785dfb47c9… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-22 (Wed, 22 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/FileSystemURLFactory.java M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-api/src/main/java/org/xwiki/wysiwyg/script/WysiwygEditorScriptService.java Log Message: ----------- [Misc] Fix additional SonarQube-reported NPE risks blocking the quality gate * FileSystemURLFactory: instead of null-checking the file mapping at each call site, make getFileMapping() lazily create and store the mapping in the context, so it's always non-null and callers' mutations still persist. * WysiwygEditorScriptService: handle the null source reference in a single place (the 4-arg overload) rather than short-circuiting in the deprecated 2-arg overload. (cherry picked from commit d33553c3cc47461cb9fc0d3a95b6b2369667c562) Co-authored-by: Claude Opus 4.8 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 13808c: [Misc] Fix additional SonarQube-reported NPE risks...
by XWiki Notifications 22 Jul '26

22 Jul '26

Branch: refs/heads/backport/stable-18.4.x/misc-sonar-npe-guards Home: https://github.com/xwiki/xwiki-platform Commit: 13808c8e6c141e2b9381ef8d3c3c8d3d1438f41b https://github.com/xwiki/xwiki-platform/commit/13808c8e6c141e2b9381ef8d3c3c… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-22 (Wed, 22 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/FileSystemURLFactory.java M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-api/src/main/java/org/xwiki/wysiwyg/script/WysiwygEditorScriptService.java Log Message: ----------- [Misc] Fix additional SonarQube-reported NPE risks blocking the quality gate * FileSystemURLFactory: instead of null-checking the file mapping at each call site, make getFileMapping() lazily create and store the mapping in the context, so it's always non-null and callers' mutations still persist. * WysiwygEditorScriptService: handle the null source reference in a single place (the 4-arg overload) rather than short-circuiting in the deprecated 2-arg overload. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply(a)anthropic.com> (cherry picked from commit d33553c3cc47461cb9fc0d3a95b6b2369667c562) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 22 Jul '26

22 Jul '26

Branch: refs/heads/advisor/006-webjars-docker-test Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 2944ef: [Misc] Migrate the WebJars functional test to the ...
by XWiki Notifications 22 Jul '26

22 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 2944efb01cbd9290e00ec2ddc9d341873736457c https://github.com/xwiki/xwiki-platform/commit/2944efb01cbd9290e00ec2ddc9d3… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-22 (Wed, 22 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/pom.xml A xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-docker/pom.xml A xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-docker/src/test/it/org/xwiki/webjars/test/ui/AllIT.java A xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-docker/src/test/it/org/xwiki/webjars/test/ui/WebJarsIT.java R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/pom.xml R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/src/test/it/org/xwiki/webjars/test/ui/WebJarsTest.java R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/src/test/resources/repository/org/sonatype/oss/oss-parent/7/oss-parent-7.pom R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/src/test/resources/repository/org/sonatype/oss/oss-parent/7/oss-parent-7.pom.sha1 R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/src/test/resources/repository/org/webjars/AjaxQ/0.0.2/AjaxQ-0.0.2.jar R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/src/test/resources/repository/org/webjars/AjaxQ/0.0.2/AjaxQ-0.0.2.jar.sha1 R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/src/test/resources/repository/org/webjars/AjaxQ/0.0.2/AjaxQ-0.0.2.pom R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/src/test/resources/repository/org/webjars/AjaxQ/0.0.2/AjaxQ-0.0.2.pom.sha1 Log Message: ----------- [Misc] Migrate the WebJars functional test to the JUnit5 Docker test framework Convert WebJarsTest (JUnit4, xwiki-platform-test-ui, packager plugin) to the JUnit5 Docker framework (@UITest) in a new xwiki-platform-webjars-test-docker module, and remove the old packager-based xwiki-platform-webjars-test-tests module. Both tests (webJars, pathTraversal) are preserved with identical assertions. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 22 Jul '26

22 Jul '26

Branch: refs/heads/misc-sonar-npe-guards Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] d33553: [Misc] Fix additional SonarQube-reported NPE risks...
by XWiki Notifications 22 Jul '26

22 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: d33553c3cc47461cb9fc0d3a95b6b2369667c562 https://github.com/xwiki/xwiki-platform/commit/d33553c3cc47461cb9fc0d3a95b6… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-22 (Wed, 22 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/FileSystemURLFactory.java M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-api/src/main/java/org/xwiki/wysiwyg/script/WysiwygEditorScriptService.java Log Message: ----------- [Misc] Fix additional SonarQube-reported NPE risks blocking the quality gate * FileSystemURLFactory: instead of null-checking the file mapping at each call site, make getFileMapping() lazily create and store the mapping in the context, so it's always non-null and callers' mutations still persist. * WysiwygEditorScriptService: handle the null source reference in a single place (the 4-arg overload) rather than short-circuiting in the deprecated 2-arg overload. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 891637: [Misc] Migrate the WebJars functional test to the ...
by XWiki Notifications 22 Jul '26

22 Jul '26

Branch: refs/heads/advisor/006-webjars-docker-test Home: https://github.com/xwiki/xwiki-platform Commit: 891637f5dc94a0aa0098d0a9ca1ce85b9b4e4cb7 https://github.com/xwiki/xwiki-platform/commit/891637f5dc94a0aa0098d0a9ca1c… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-22 (Wed, 22 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/pom.xml A xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-docker/pom.xml A xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-docker/src/test/it/org/xwiki/webjars/test/ui/AllIT.java A xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-docker/src/test/it/org/xwiki/webjars/test/ui/WebJarsIT.java R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/pom.xml R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/src/test/it/org/xwiki/webjars/test/ui/WebJarsTest.java R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/src/test/resources/repository/org/sonatype/oss/oss-parent/7/oss-parent-7.pom R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/src/test/resources/repository/org/sonatype/oss/oss-parent/7/oss-parent-7.pom.sha1 R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/src/test/resources/repository/org/webjars/AjaxQ/0.0.2/AjaxQ-0.0.2.jar R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/src/test/resources/repository/org/webjars/AjaxQ/0.0.2/AjaxQ-0.0.2.jar.sha1 R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/src/test/resources/repository/org/webjars/AjaxQ/0.0.2/AjaxQ-0.0.2.pom R xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-test/xwiki-platform-webjars-test-tests/src/test/resources/repository/org/webjars/AjaxQ/0.0.2/AjaxQ-0.0.2.pom.sha1 Log Message: ----------- [Misc] Migrate the WebJars functional test to the JUnit5 Docker test framework Convert WebJarsTest (JUnit4, xwiki-platform-test-ui, packager plugin) to the JUnit5 Docker framework (@UITest) in a new xwiki-platform-webjars-test-docker module, and remove the old packager-based xwiki-platform-webjars-test-tests module. Both tests (webJars, pathTraversal) are preserved with identical assertions. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0