- notifications - lists.xwiki.org

[xwiki/xwiki-platform] 5fe8e1: [Misc] Make JUnit5 test classes and methods packag...
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 5fe8e1bab60ae77ad2d1f65572b9184a5219dbec https://github.com/xwiki/xwiki-platform/commit/5fe8e1bab60ae77ad2d1f65572b9… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-15 (Wed, 15 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-core/src/test/java/org/xwiki/annotation/content/SpaceNormalizerContentAltererTest.java M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-core/src/test/java/org/xwiki/annotation/content/WhiteSpaceContentAltererTest.java M xwiki-platform-core/xwiki-platform-csrf/src/test/java/org/xwiki/csrf/CSRFTokenInvalidatorTest.java M xwiki-platform-core/xwiki-platform-csrf/src/test/java/org/xwiki/csrf/DefaultCSRFTokenConfigurationTest.java M xwiki-platform-core/xwiki-platform-display/xwiki-platform-display-html/src/test/java/org/xwiki/rendering/display/html/internal/DefaultTemplateHTMLDisplayerTest.java M xwiki-platform-core/xwiki-platform-display/xwiki-platform-display-html/src/test/java/org/xwiki/rendering/display/html/script/HTMLDisplayerScriptServiceTest.java M xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-livetable/src/test/java/org/xwiki/livedata/internal/livetable/LiveTableLiveDataSourceTest.java M xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-livetable/src/test/java/org/xwiki/livedata/internal/livetable/PropertyTypeSupplierTest.java M xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-sources/xwiki-platform-localization-source-jar/src/test/java/org/xwiki/localization/jar/internal/JARTranslationBundleFactoryTest.java M xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-sources/xwiki-platform-localization-source-jar/src/test/java/org/xwiki/localization/jar/internal/RootClassLoaderTranslationBundleTest.java M xwiki-platform-core/xwiki-platform-mentions/xwiki-platform-mentions-notifications/src/test/java/org/xwiki/mentions/internal/MentionsNotificationDisplayerTest.java M xwiki-platform-core/xwiki-platform-mentions/xwiki-platform-mentions-notifications/src/test/java/org/xwiki/mentions/internal/MentionsRecordableEventConverterTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-api/src/test/java/org/xwiki/notifications/internal/DefaultCompositeEventStatusManagerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-api/src/test/java/org/xwiki/notifications/internal/SimilarityCalculatorTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/test/java/org/xwiki/notifications/filters/internal/DocumentMovedListenerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/test/java/org/xwiki/notifications/filters/internal/UserAddedEventListenerTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/job/ReplaceUserJobTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/listener/UpdateObjectsOnClassRenameListenerTest.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-embedded/src/test/java/org/xwiki/search/solr/internal/DefaultSolrTest.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-embedded/src/test/java/org/xwiki/search/solr/internal/EmbeddedSolrInitializationTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/test/java/org/xwiki/security/authentication/internal/DefaultAuthenticationFailureManagerTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/test/java/org/xwiki/security/authentication/internal/DisableAccountFailureStrategyTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/SecurityReferenceTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/cache/internal/DefaultSecurityCacheTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/internal/DefaultAuthorizationSettlerTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-resource/src/test/java/org/xwiki/user/resource/internal/document/DocumentUserResourceReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-resource/src/test/java/org/xwiki/user/resource/internal/document/UserResourceReferenceTest.java Log Message: ----------- [Misc] Make JUnit5 test classes and methods package-private (SonarCloud java:S5786) Mechanical, behaviour-preserving cleanup of SonarCloud rule java:S5786 across 13 modules: JUnit5 no longer requires test classes or test methods to be public, package-private is the recommended visibility. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/claude/vigilant-dirac-vcdatr Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 9ef628: [Misc] Make JUnit5 test classes and methods packag...
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 9ef6288923f9c34315f0410731d5ca5d359499e3 https://github.com/xwiki/xwiki-platform/commit/9ef6288923f9c34315f0410731d5… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-15 (Wed, 15 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-captcha/xwiki-platform-captcha-jcaptcha/xwiki-platform-captcha-jcaptcha-api/src/test/java/org/xwiki/captcha/internal/JCaptchaResourceReferenceHandlerTest.java M xwiki-platform-core/xwiki-platform-captcha/xwiki-platform-captcha-jcaptcha/xwiki-platform-captcha-jcaptcha-api/src/test/java/org/xwiki/captcha/internal/JCaptchaResourceReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-captcha/xwiki-platform-captcha-jcaptcha/xwiki-platform-captcha-jcaptcha-api/src/test/java/org/xwiki/captcha/internal/script/JCaptchaInternalScriptServiceTest.java M xwiki-platform-core/xwiki-platform-diff/xwiki-platform-diff-xml/src/test/java/org/xwiki/diff/xml/internal/DefaultDataURIConverterTest.java M xwiki-platform-core/xwiki-platform-diff/xwiki-platform-diff-xml/src/test/java/org/xwiki/diff/xml/internal/ImageDownloaderTest.java M xwiki-platform-core/xwiki-platform-index/xwiki-platform-index-tree/xwiki-platform-index-tree-api/src/test/java/org/xwiki/index/tree/internal/nestedpages/ChildDocumentsTreeNodeGroupTest.java M xwiki-platform-core/xwiki-platform-index/xwiki-platform-index-tree/xwiki-platform-index-tree-api/src/test/java/org/xwiki/index/tree/internal/nestedpages/DocumentTreeNodeTest.java M xwiki-platform-core/xwiki-platform-index/xwiki-platform-index-tree/xwiki-platform-index-tree-api/src/test/java/org/xwiki/index/tree/internal/nestedpages/query/ExcludedDocumentFilterTest.java M xwiki-platform-core/xwiki-platform-index/xwiki-platform-index-tree/xwiki-platform-index-tree-api/src/test/java/org/xwiki/index/tree/internal/nestedpages/query/ExcludedSpaceFilterTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-model-api/src/test/java/org/xwiki/model/internal/reference/DeprecatedLocalReferenceEntityReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-model-api/src/test/java/org/xwiki/model/internal/reference/ReferencesTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-model-api/src/test/java/org/xwiki/model/internal/reference/StringsTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-api/src/test/java/org/xwiki/model/validation/AbstractEntityNameValidationTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-api/src/test/java/org/xwiki/model/validation/script/ModelValidationScriptServiceTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-async/xwiki-platform-rendering-async-default/src/test/java/org/xwiki/rendering/async/internal/AsyncRendererCacheTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-async/xwiki-platform-rendering-async-default/src/test/java/org/xwiki/rendering/async/internal/service/AsyncRendererResourceReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-async/xwiki-platform-rendering-async-default/src/test/java/org/xwiki/rendering/async/internal/service/AsyncRendererResourceReferenceTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-merge/xwiki-platform-store-merge-api/src/test/java/org/xwiki/store/merge/MergeDocumentResultTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-merge/xwiki-platform-store-merge-api/src/test/java/org/xwiki/store/merge/MergeManagerResultTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-merge/xwiki-platform-store-merge-default/src/test/java/org/xwiki/store/merge/MergeDocumentResultScriptTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-merge/xwiki-platform-store-merge-default/src/test/java/org/xwiki/store/merge/internal/DefaultMergeConflictDecisionManagerTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-merge/xwiki-platform-store-merge-default/src/test/java/org/xwiki/store/merge/internal/DefaultMergeManagerTest.java M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-default/src/test/java/org/xwiki/uiextension/WikiUIExtensionParametersTest.java M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-default/src/test/java/org/xwiki/uiextension/WikiUIExtensionTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-schemes/xwiki-platform-url-scheme-standard/src/test/java/org/xwiki/url/internal/standard/ContextAndActionURLNormalizerTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-schemes/xwiki-platform-url-scheme-standard/src/test/java/org/xwiki/url/internal/standard/StandardURLStringEntityReferenceResolverTest.java Log Message: ----------- [Misc] Make JUnit5 test classes and methods package-private (SonarCloud java:S5786) Mechanical, behaviour-preserving cleanup of SonarCloud rule java:S5786 across 10 modules: JUnit5 test classes and their test/lifecycle methods do not need to be public and should be package-private. Only test class declarations and JUnit-annotated methods were changed; no production code touched. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/claude/vigilant-dirac-d5hd3s Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] ce509b: [Misc] Use assertEquals/assertNotEquals instead of...
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: ce509be1144324d46501d813bdffee986c785d92 https://github.com/xwiki/xwiki-platform/commit/ce509be1144324d46501d813bdff… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-15 (Wed, 15 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-bridge/src/test/java/org/xwiki/bridge/ActionExecutingEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/AbstractRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/SimpleEventQueryTest.java Log Message: ----------- [Misc] Use assertEquals/assertNotEquals instead of boolean assertions in bridge and eventstream-api tests (SonarCloud java:S5785) Replace assertTrue(a.equals(b))/assertFalse(a.equals(b)) and assertTrue(x == 0)/assertTrue(x != 0) with assertEquals/assertNotEquals so that a failure reports the actual and expected values. The receiver is kept as the first argument to preserve the exact equals() direction (matters for the cross-type comparison against ActionExecutedEvent). To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/claude/vigilant-dirac-d9tl91 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] d5ac2b: [Misc] Use assertEquals/assertNotEquals instead of...
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: d5ac2bd37e0c83dda92d7b20bb099c7fdc3da432 https://github.com/xwiki/xwiki-platform/commit/d5ac2bd37e0c83dda92d7b20bb09… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-15 (Wed, 15 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/RegexEntityReferenceTest.java Log Message: ----------- [Misc] Use assertEquals/assertNotEquals instead of boolean assertions in model-api tests (SonarCloud java:S5785) Mechanical, behaviour-preserving cleanup of SonarCloud rule java:S5785 in the xwiki-platform-model-api module (27 issues across 2 test files). Using a dedicated equality assertion reports the actual and expected values on failure instead of just "expected: <true> but was: <false>". For RegexEntityReference the equals() override is asymmetric (a regex reference matches a concrete one, not vice-versa), so the original receiver is kept as the first argument to preserve the tested direction. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] ed51b0: [Misc] Use pattern matching for instanceof in vari...
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/claude/vigilant-dirac-7r6hua Home: https://github.com/xwiki/xwiki-platform Commit: ed51b0bd4b74914af211cf0ec8917d829df1a6a7 https://github.com/xwiki/xwiki-platform/commit/ed51b0bd4b74914af211cf0ec891… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-15 (Wed, 15 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-events-hibernate/xwiki-platform-legacy-events-hibernate-api/src/main/java/org/xwiki/eventstream/store/internal/LegacyEventDeleter.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-events-hibernate/xwiki-platform-legacy-events-hibernate-api/src/main/java/org/xwiki/eventstream/store/internal/LegacyEventStatus.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-events-hibernate/xwiki-platform-legacy-events-hibernate-api/src/main/java/org/xwiki/notifications/sources/internal/ExpressionNodeToHQLConverter.java M xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-api/src/main/java/org/xwiki/livedata/BaseDescriptor.java M xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-api/src/main/java/org/xwiki/livedata/LiveData.java M xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-api/src/main/java/org/xwiki/livedata/WithParameters.java M xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-api/src/main/java/org/xwiki/livedata/internal/DefaultLiveDataSourceManager.java M xwiki-platform-core/xwiki-platform-query/xwiki-platform-query-xwql/src/main/java/org/xwiki/query/xwql/internal/QueryAnalyzer.java M xwiki-platform-core/xwiki-platform-query/xwiki-platform-query-xwql/src/main/java/org/xwiki/query/xwql/internal/XWQLQueryExecutor.java M xwiki-platform-core/xwiki-platform-query/xwiki-platform-query-xwql/src/main/java/org/xwiki/query/xwql/internal/hql/TreePrinter.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/WikiDocument.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractCopyOrMoveJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractEntityJobWithChecks.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/listener/BackLinkUpdaterListener.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/listener/LegacyParentFieldUpdaterListener.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/splitter/criterion/HeadingLevelSplittingCriterion.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/plugin/skinx/AbstractDocumentSkinExtensionPlugin.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/web/JsxAction.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/org/xwiki/skinx/internal/DefaultRequiredSkinExtensionsRecorder.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/org/xwiki/skinx/internal/async/SkinExtensionAsyncContextHandler.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-container/src/main/java/org/xwiki/url/internal/container/ContextAndActionURLNormalizer.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-container/src/main/java/org/xwiki/url/internal/container/ContextExtendedURLURLNormalizer.java Log Message: ----------- [Misc] Use pattern matching for instanceof in various modules (SonarCloud java:S6201) Replaces instanceof checks followed by an explicit cast with instanceof pattern variables (Java 16+), as flagged by SonarCloud rule java:S6201. Mechanical, behaviour-preserving cleanup across six modules. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[[email protected]][Issue] Updates for HELM-106: Persistency not reflected in Configuration
by XWiki Notifications 15 Jul '26

15 Jul '26

1 0

[xwiki/xwiki-platform] b1a4c1: XWIKI-24538: Wrong author used in toAnnotatedXHTML...
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/stable-16.10.x Home: https://github.com/xwiki/xwiki-platform Commit: b1a4c1be2876e5e3c3a8a85d4179921e554e9302 https://github.com/xwiki/xwiki-platform/commit/b1a4c1be2876e5e3c3a8a85d4179… Author: Michael Hamann <michael.hamann(a)xwiki.com> Date: 2026-07-15 (Wed, 15 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-ui/src/main/resources/CKEditor/SyntaxContentEditor.xml M xwiki-platform-core/xwiki-platform-ckeditor/xwiki-platform-ckeditor-ui/src/main/resources/CKEditor/VelocityMacros.xml M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/TextAreaClass.java M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-api/pom.xml M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-api/src/main/java/org/xwiki/wysiwyg/script/WysiwygEditorScriptService.java M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-api/src/test/java/org/xwiki/wysiwyg/script/WysiwygEditorScriptServiceTest.java Log Message: ----------- XWIKI-24538: Wrong author used in toAnnotatedXHTML in edge cases for object properties * Properly pass the object property reference from text area properties to the WYSIWYG editor script service. * Convert WysiwygEditorScriptServiceTest to OldcoreTest and add tests. (cherry picked from commit 16b11c95eabee174dba08b019cec0431836e0200) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0