- notifications - lists.xwiki.org

[xwiki/xwiki-platform] 57052b: [Misc] Use assertEquals/assertNotEquals instead of...
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/claude/vigilant-dirac-d9tl91 Home: https://github.com/xwiki/xwiki-platform Commit: 57052b2d6472c1a2ae71100331435df8858b1206 https://github.com/xwiki/xwiki-platform/commit/57052b2d6472c1a2ae7110033143… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-12 (Sun, 12 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/RegexEntityReferenceTest.java Log Message: ----------- [Misc] Use assertEquals/assertNotEquals instead of boolean assertions in model-api tests (SonarCloud java:S5785) Mechanical, behaviour-preserving cleanup of SonarCloud rule java:S5785 in the xwiki-platform-model-api module (27 issues across 2 test files). Using a dedicated equality assertion reports the actual and expected values on failure instead of just "expected: <true> but was: <false>". For RegexEntityReference the equals() override is asymmetric (a regex reference matches a concrete one, not vice-versa), so the original receiver is kept as the first argument to preserve the tested direction. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/claude/vigilant-dirac-y0yrqg Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 9aac8e: [Misc] Use assertEquals/assertNotEquals/assertNull...
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 9aac8edf6b1311decccb9d375f5c709376ed83fc https://github.com/xwiki/xwiki-platform/commit/9aac8edf6b1311decccb9d375f5c… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-12 (Sun, 12 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-chart/xwiki-platform-chart-macro/src/test/java/org/xwiki/rendering/internal/macro/chart/ImageIdTest.java M xwiki-platform-core/xwiki-platform-chart/xwiki-platform-chart-macro/src/test/java/org/xwiki/rendering/internal/macro/chart/source/table/RangeParserTest.java M xwiki-platform-core/xwiki-platform-chart/xwiki-platform-chart-macro/src/test/java/org/xwiki/rendering/internal/macro/chart/source/table/TableCategoryDatasetBuilderTest.java M xwiki-platform-core/xwiki-platform-chart/xwiki-platform-chart-macro/src/test/java/org/xwiki/rendering/internal/macro/chart/source/table/TablePieDatasetBuilderTest.java M xwiki-platform-core/xwiki-platform-chart/xwiki-platform-chart-macro/src/test/java/org/xwiki/rendering/internal/macro/chart/source/table/TableTimeTableXYBuilderTest.java Log Message: ----------- [Misc] Use assertEquals/assertNotEquals/assertNull instead of boolean assertions in chart-macro tests (SonarCloud java:S5785) Replace assertTrue(a.equals(b)) with assertEquals(b, a), assertFalse(a.equals(b)) with assertNotEquals(b, a), assertTrue(x == n) with assertEquals(n, x) and assertTrue(x == null) with assertNull(x) so that failures report the compared values, as reported by SonarCloud rule java:S5785. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/claude/vigilant-dirac-t3ygwz Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 9861ac: [Misc] Merge collapsible nested if statements and ...
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 9861accea89aca55674699b4664fc16d5b97da15 https://github.com/xwiki/xwiki-platform/commit/9861accea89aca55674699b4664f… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-12 (Sun, 12 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/plugin/rightsmanager/UserIterator.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/velocity/DefaultVelocityEvaluator.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseCollection.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseObject.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/ListClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/FileSystemURLFactory.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/packaging/Package.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/security/XWikiSecurityManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiRightServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/ActionFilter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/SkinAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/UploadAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/Utils.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/plugin/packaging/AbstractPackageTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/test/MockitoOldcore.java Log Message: ----------- [Misc] Merge collapsible nested if statements and remove unused code (SonarCloud) * Merge collapsible nested if statements (java:S1066) * Add missing @Override, remove unused field/variable and dead store (java:S1161, java:S1481, java:S1854) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/claude/vigilant-dirac-24j48u Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] a1e26f: [Misc] Make JUnit5 test classes and methods packag...
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: a1e26f79d4613884ae59a52749e21e7565eb90ce https://github.com/xwiki/xwiki-platform/commit/a1e26f79d4613884ae59a52749e2… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-12 (Sun, 12 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/api/XWikiTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/DefaultXWikiStubContextProviderTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/XWikiStubContextInitializerTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/context/XWikiContextContextStoreTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/doc/BaseObjectsTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/filter/output/DocumentInstanceOutputFilterStreamTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/model/reference/CurrentEntityReferenceProviderTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/model/reference/CurrentReferenceEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/model/reference/CurrentStringEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/model/reference/SpaceReferenceConverterTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/objects/classes/DefaultPageQueryBuilderTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/objects/classes/ExplicitlyAllowedValuesDBListQueryBuilderTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/objects/classes/ImplicitlyAllowedValuesPageQueryBuilderTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/objects/classes/XClassMigratorListenerTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/render/ScriptXWikiServletRequestTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/resource/DefaultEntityResourceActionListerTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/store/PropertyConverterTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/store/hibernate/query/HqlQueryUtilsTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/BaseStringPropertyTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/GroupsClassTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/LevelsClassTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/pdf/impl/FileSystemURLFactoryTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/plugin/packaging/ImportTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/plugin/packaging/PackageTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/store/hibernate/query/HqlQueryExecutorTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/store/hibernate/query/VersioningStoreQueryFactoryTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/internal/script/XWikiScriptContextInitializerTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/internal/template/ActionTemplateRequirementTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/internal/velocity/XWikiVelocityManagerTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/query/hql/internal/DefaultHQLStatementValidatorTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/security/authservice/internal/AuthServiceConfigurationTest.java Log Message: ----------- [Misc] Make JUnit5 test classes and methods package-private (SonarCloud java:S5786) Remove redundant public visibility modifiers from JUnit5 test classes and their test/lifecycle methods in xwiki-platform-oldcore, as reported by SonarCloud rule java:S5786. Behaviour-preserving, test code only. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/claude/vigilant-dirac-ntg5oh Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 311415: [Misc] Make JUnit5 test classes and methods packag...
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 311415d6fc9b32833bea0aebb0928327ce974ffe https://github.com/xwiki/xwiki-platform/commit/311415d6fc9b32833bea0aebb092… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-12 (Sun, 12 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-api/src/test/java/org/xwiki/like/internal/DefaultLikeConfigurationTest.java M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-api/src/test/java/org/xwiki/like/internal/LikeExistCacheEntryListenerTest.java M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-api/src/test/java/org/xwiki/like/internal/LikeRightTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/internal/AddressConverterTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/internal/AddressesConverterTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/internal/DefaultEmailAddressObfuscatorTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/internal/InternetAddressConverterTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/internal/configuration/DefaultGeneralMailConfigurationTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/script/GeneralMailScriptServiceTest.java M xwiki-platform-core/xwiki-platform-observation/xwiki-platform-observation-remote/src/test/java/org/xwiki/observation/remote/RemoteEventDataTest.java M xwiki-platform-core/xwiki-platform-observation/xwiki-platform-observation-remote/src/test/java/org/xwiki/observation/remote/internal/converter/LogEventConverterTest.java M xwiki-platform-core/xwiki-platform-observation/xwiki-platform-observation-remote/src/test/java/org/xwiki/observation/remote/internal/converter/SerializableEventConverterTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/DefaultRatingTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/RatingDeletedEntityListenerTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/RatingMovedEntityListenerTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/SolrRatingsManagerTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/averagerating/AbstractAverageRatingManagerTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/averagerating/AverageRatingProtectionListenerTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/averagerating/DefaultAverageRatingTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/script/RatingsScriptServiceTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem/src/test/java/org/xwiki/store/FileDeleteTransactionRunnableTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem/src/test/java/org/xwiki/store/FileSaveTransactionRunnableTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem/src/test/java/org/xwiki/store/FileSystemStoreUtilsTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-container/src/test/java/org/xwiki/url/internal/container/ContextAndActionURLNormalizerTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-container/src/test/java/org/xwiki/url/internal/container/ContextExtendedURLURLNormalizerTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-container/src/test/java/org/xwiki/url/internal/container/URLURLNormalizerTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-api/src/test/java/org/xwiki/user/CurrentUserReferenceTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-api/src/test/java/org/xwiki/user/EditorTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-api/src/test/java/org/xwiki/user/GuestUserReferenceTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-api/src/test/java/org/xwiki/user/SuperAdminUserReferenceTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-api/src/test/java/org/xwiki/user/UserTypeTest.java Log Message: ----------- [Misc] Make JUnit5 test classes and methods package-private (SonarCloud java:S5786) Remove redundant public visibility modifiers from JUnit5 test classes and their test/lifecycle methods across 7 modules, as reported by SonarCloud rule java:S5786. Test code only, behaviour-preserving. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/claude/vigilant-dirac-a09nbj Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0