- notifications - lists.xwiki.org

[xwiki/xwiki-platform] 4c0dbf: [Misc] Make JUnit5 test classes and methods packag...
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 4c0dbf3be35f576e73eaac322a39f8adf5a93b7a https://github.com/xwiki/xwiki-platform/commit/4c0dbf3be35f576e73eaac322a39… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-12 (Sun, 12 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/AbstractRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/EqualEventQueryTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/EventGroupTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/internal/DefaultEventStoreNoLegacyTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/internal/DefaultEventStoreNoStoreTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/internal/DefaultEventStoreTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/internal/events/EventStatusAddOrUpdatedEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/internal/events/EventStatusDeletedEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/internal/events/MailEntityAddedEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/internal/events/MailEntityDeleteEventTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/DefaultAsyncNotificationRendererTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/DefaultNotificationCacheManagerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/DefaultNotificationDisplayerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/InternalHtmlNotificationRendererTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/NotificationAsyncRendererConfigurationTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/email/live/MissingLiveNotificationMailsJobTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/email/live/PrefilteringLiveNotificationEmailDispatcherTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/email/live/PrefilteringLiveNotificationEmailManagerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/email/live/PrefilteringLiveNotificationEmailSenderTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/rss/DefaultNotificationRSSRendererTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/test/java/org/xwiki/notifications/notifiers/internal/UserEventManagerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/test/java/org/xwiki/notifications/notifiers/internal/email/live/LiveNotificationEmailEventFilterTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/ConfiguredStringUserReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/DefaultConfiguredStringUserReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/DefaultUserPropertiesResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/DefaultUserPropertiesTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/CurrentUserReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/DocumentDocumentReferenceUserReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/DocumentDocumentReferenceUserReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/DocumentStringUserReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/NormalUserPreferencesConfigurationSourceTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/SecureUserDocumentUserPropertiesResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/UserDocumentUserPropertiesResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/UserPreferencesConfigurationSourceTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/XWikiUserUserReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/group/GroupsCacheTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/group/UsersCacheTest.java Log Message: ----------- [Misc] Make JUnit5 test classes and methods package-private (SonarCloud java:S5786) JUnit5 no longer requires test classes and methods to be public; the recommended visibility is package-private. This removes the redundant public modifiers reported by SonarCloud rule java:S5786 across the eventstream-api, notifications-notifiers and user-default modules. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/claude/vigilant-dirac-lbmtom Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] ea1802: [Misc] Make JUnit5 test classes and methods packag...
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: ea180214b597ef0d7a883983dec28404bed434a9 https://github.com/xwiki/xwiki-platform/commit/ea180214b597ef0d7a883983dec2… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-12 (Sun, 12 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/DefaultModelConfigurationTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/DefaultDocumentReferenceProviderTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/DefaultEntityReferenceProviderTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/DefaultPageReferenceProviderTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/DefaultSpaceReferenceProviderTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/DefaultStringEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/ExplicitReferenceEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/ExplicitStringAttachmentReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/ExplicitStringDocumentReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/ExplicitStringEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/FSPathStringEntityReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/LocalStringEntityReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/LocalUidStringEntityReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/PathStringDocumentReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/UidStringEntityReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/comparator/DocumentReferenceComparatorTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/AttachmentReferenceConverterTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/AttachmentReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/BlockReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/ClassPropertyReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTreeTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/LocalDocumentReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/LocalPageReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/ObjectPropertyReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/ObjectReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/PageAttachmentReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/PageClassPropertyReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/PageObjectPropertyReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/PageObjectReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/PageReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/RegexEntityReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/SpaceReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/WikiReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/script/ModelScriptServiceTest.java Log Message: ----------- [Misc] Make JUnit5 test classes and methods package-private (SonarCloud java:S5786) * Remove redundant public visibility modifiers from JUnit5 test classes and their test/lifecycle methods in xwiki-platform-model-api, as reported by SonarCloud rule java:S5786. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 8dea37: [Misc] Use assertEquals/assertNotEquals/assertNull...
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/claude/vigilant-dirac-y0yrqg Home: https://github.com/xwiki/xwiki-platform Commit: 8dea372f0202642f21950a84572ab56708c9659d https://github.com/xwiki/xwiki-platform/commit/8dea372f0202642f21950a84572a… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-12 (Sun, 12 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-chart/xwiki-platform-chart-macro/src/test/java/org/xwiki/rendering/internal/macro/chart/ImageIdTest.java M xwiki-platform-core/xwiki-platform-chart/xwiki-platform-chart-macro/src/test/java/org/xwiki/rendering/internal/macro/chart/source/table/RangeParserTest.java M xwiki-platform-core/xwiki-platform-chart/xwiki-platform-chart-macro/src/test/java/org/xwiki/rendering/internal/macro/chart/source/table/TableCategoryDatasetBuilderTest.java M xwiki-platform-core/xwiki-platform-chart/xwiki-platform-chart-macro/src/test/java/org/xwiki/rendering/internal/macro/chart/source/table/TablePieDatasetBuilderTest.java M xwiki-platform-core/xwiki-platform-chart/xwiki-platform-chart-macro/src/test/java/org/xwiki/rendering/internal/macro/chart/source/table/TableTimeTableXYBuilderTest.java Log Message: ----------- [Misc] Use assertEquals/assertNotEquals/assertNull instead of boolean assertions in chart-macro tests (SonarCloud java:S5785) Replace assertTrue(a.equals(b)) with assertEquals(b, a), assertFalse(a.equals(b)) with assertNotEquals(b, a), assertTrue(x == n) with assertEquals(n, x) and assertTrue(x == null) with assertNull(x) so that failures report the compared values, as reported by SonarCloud rule java:S5785. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] c3a736: [Misc] Merge collapsible nested if statements and ...
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/claude/vigilant-dirac-t3ygwz Home: https://github.com/xwiki/xwiki-platform Commit: c3a73660ba4bc5df594eca69de3dba1ffa01d4d8 https://github.com/xwiki/xwiki-platform/commit/c3a73660ba4bc5df594eca69de3d… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-12 (Sun, 12 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/plugin/rightsmanager/UserIterator.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/velocity/DefaultVelocityEvaluator.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseCollection.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseObject.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/ListClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/FileSystemURLFactory.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/packaging/Package.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/security/XWikiSecurityManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiRightServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/ActionFilter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/SkinAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/UploadAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/Utils.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/plugin/packaging/AbstractPackageTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/test/MockitoOldcore.java Log Message: ----------- [Misc] Merge collapsible nested if statements and remove unused code (SonarCloud) * Merge collapsible nested if statements (java:S1066) * Add missing @Override, remove unused field/variable and dead store (java:S1161, java:S1481, java:S1854) Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 013659: [Misc] Make JUnit5 test classes and methods packag...
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/claude/vigilant-dirac-24j48u Home: https://github.com/xwiki/xwiki-platform Commit: 013659c07babcf5560dca3effabd46b6972355ba https://github.com/xwiki/xwiki-platform/commit/013659c07babcf5560dca3effabd… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-12 (Sun, 12 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/api/XWikiTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/DefaultXWikiStubContextProviderTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/XWikiStubContextInitializerTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/context/XWikiContextContextStoreTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/doc/BaseObjectsTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/filter/output/DocumentInstanceOutputFilterStreamTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/model/reference/CurrentEntityReferenceProviderTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/model/reference/CurrentReferenceEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/model/reference/CurrentStringEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/model/reference/SpaceReferenceConverterTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/objects/classes/DefaultPageQueryBuilderTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/objects/classes/ExplicitlyAllowedValuesDBListQueryBuilderTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/objects/classes/ImplicitlyAllowedValuesPageQueryBuilderTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/objects/classes/XClassMigratorListenerTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/render/ScriptXWikiServletRequestTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/resource/DefaultEntityResourceActionListerTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/store/PropertyConverterTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/store/hibernate/query/HqlQueryUtilsTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/BaseStringPropertyTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/GroupsClassTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/classes/LevelsClassTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/pdf/impl/FileSystemURLFactoryTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/plugin/packaging/ImportTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/plugin/packaging/PackageTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/store/hibernate/query/HqlQueryExecutorTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/store/hibernate/query/VersioningStoreQueryFactoryTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/internal/script/XWikiScriptContextInitializerTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/internal/template/ActionTemplateRequirementTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/internal/velocity/XWikiVelocityManagerTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/query/hql/internal/DefaultHQLStatementValidatorTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/security/authservice/internal/AuthServiceConfigurationTest.java Log Message: ----------- [Misc] Make JUnit5 test classes and methods package-private (SonarCloud java:S5786) Remove redundant public visibility modifiers from JUnit5 test classes and their test/lifecycle methods in xwiki-platform-oldcore, as reported by SonarCloud rule java:S5786. Behaviour-preserving, test code only. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 95c9b7: [Misc] Make JUnit5 test classes and methods packag...
by XWiki Notifications 12 Jul '26

12 Jul '26

Branch: refs/heads/claude/vigilant-dirac-ntg5oh Home: https://github.com/xwiki/xwiki-platform Commit: 95c9b7a2effb3d763f985066872198d9672c9b6f https://github.com/xwiki/xwiki-platform/commit/95c9b7a2effb3d763f9850668721… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-12 (Sun, 12 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-api/src/test/java/org/xwiki/like/internal/DefaultLikeConfigurationTest.java M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-api/src/test/java/org/xwiki/like/internal/LikeExistCacheEntryListenerTest.java M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-api/src/test/java/org/xwiki/like/internal/LikeRightTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/internal/AddressConverterTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/internal/AddressesConverterTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/internal/DefaultEmailAddressObfuscatorTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/internal/InternetAddressConverterTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/internal/configuration/DefaultGeneralMailConfigurationTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-general/src/test/java/org/xwiki/mail/script/GeneralMailScriptServiceTest.java M xwiki-platform-core/xwiki-platform-observation/xwiki-platform-observation-remote/src/test/java/org/xwiki/observation/remote/RemoteEventDataTest.java M xwiki-platform-core/xwiki-platform-observation/xwiki-platform-observation-remote/src/test/java/org/xwiki/observation/remote/internal/converter/LogEventConverterTest.java M xwiki-platform-core/xwiki-platform-observation/xwiki-platform-observation-remote/src/test/java/org/xwiki/observation/remote/internal/converter/SerializableEventConverterTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/DefaultRatingTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/RatingDeletedEntityListenerTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/RatingMovedEntityListenerTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/SolrRatingsManagerTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/averagerating/AbstractAverageRatingManagerTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/averagerating/AverageRatingProtectionListenerTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/internal/averagerating/DefaultAverageRatingTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/test/java/org/xwiki/ratings/script/RatingsScriptServiceTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem/src/test/java/org/xwiki/store/FileDeleteTransactionRunnableTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem/src/test/java/org/xwiki/store/FileSaveTransactionRunnableTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem/src/test/java/org/xwiki/store/FileSystemStoreUtilsTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-container/src/test/java/org/xwiki/url/internal/container/ContextAndActionURLNormalizerTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-container/src/test/java/org/xwiki/url/internal/container/ContextExtendedURLURLNormalizerTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-container/src/test/java/org/xwiki/url/internal/container/URLURLNormalizerTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-api/src/test/java/org/xwiki/user/CurrentUserReferenceTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-api/src/test/java/org/xwiki/user/EditorTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-api/src/test/java/org/xwiki/user/GuestUserReferenceTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-api/src/test/java/org/xwiki/user/SuperAdminUserReferenceTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-api/src/test/java/org/xwiki/user/UserTypeTest.java Log Message: ----------- [Misc] Make JUnit5 test classes and methods package-private (SonarCloud java:S5786) Remove redundant public visibility modifiers from JUnit5 test classes and their test/lifecycle methods across 7 modules, as reported by SonarCloud rule java:S5786. Test code only, behaviour-preserving. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 268e00: [Misc] Make JUnit5 test classes and methods packag...
by XWiki Notifications 11 Jul '26

11 Jul '26

Branch: refs/heads/claude/vigilant-dirac-a09nbj Home: https://github.com/xwiki/xwiki-platform Commit: 268e0007805427c7a7de848712353ae9df4b2a39 https://github.com/xwiki/xwiki-platform/commit/268e0007805427c7a7de84871235… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-11 (Sat, 11 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/AbstractRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/EqualEventQueryTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/EventGroupTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/internal/DefaultEventStoreNoLegacyTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/internal/DefaultEventStoreNoStoreTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/internal/DefaultEventStoreTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/internal/events/EventStatusAddOrUpdatedEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/internal/events/EventStatusDeletedEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/internal/events/MailEntityAddedEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/internal/events/MailEntityDeleteEventTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/DefaultAsyncNotificationRendererTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/DefaultNotificationCacheManagerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/DefaultNotificationDisplayerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/InternalHtmlNotificationRendererTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/NotificationAsyncRendererConfigurationTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/email/live/MissingLiveNotificationMailsJobTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/email/live/PrefilteringLiveNotificationEmailDispatcherTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/email/live/PrefilteringLiveNotificationEmailManagerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/email/live/PrefilteringLiveNotificationEmailSenderTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/test/java/org/xwiki/notifications/notifiers/internal/rss/DefaultNotificationRSSRendererTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/test/java/org/xwiki/notifications/notifiers/internal/UserEventManagerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/test/java/org/xwiki/notifications/notifiers/internal/email/live/LiveNotificationEmailEventFilterTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/ConfiguredStringUserReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/DefaultConfiguredStringUserReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/DefaultUserPropertiesResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/DefaultUserPropertiesTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/CurrentUserReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/DocumentDocumentReferenceUserReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/DocumentDocumentReferenceUserReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/DocumentStringUserReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/NormalUserPreferencesConfigurationSourceTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/SecureUserDocumentUserPropertiesResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/UserDocumentUserPropertiesResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/UserPreferencesConfigurationSourceTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/document/XWikiUserUserReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/group/GroupsCacheTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-default/src/test/java/org/xwiki/user/internal/group/UsersCacheTest.java Log Message: ----------- [Misc] Make JUnit5 test classes and methods package-private (SonarCloud java:S5786) JUnit5 no longer requires test classes and methods to be public; the recommended visibility is package-private. This removes the redundant public modifiers reported by SonarCloud rule java:S5786 across the eventstream-api, notifications-notifiers and user-default modules. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 0c825f: [Misc] Make JUnit5 test classes and methods packag...
by XWiki Notifications 11 Jul '26

11 Jul '26

Branch: refs/heads/claude/vigilant-dirac-lbmtom Home: https://github.com/xwiki/xwiki-platform Commit: 0c825f7635a734c1c6f2e401c96011ca627eed8d https://github.com/xwiki/xwiki-platform/commit/0c825f7635a734c1c6f2e401c960… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-11 (Sat, 11 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/DefaultModelConfigurationTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/DefaultDocumentReferenceProviderTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/DefaultEntityReferenceProviderTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/DefaultPageReferenceProviderTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/DefaultSpaceReferenceProviderTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/DefaultStringEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/ExplicitReferenceEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/ExplicitStringAttachmentReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/ExplicitStringDocumentReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/ExplicitStringEntityReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/FSPathStringEntityReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/LocalStringEntityReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/LocalUidStringEntityReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/PathStringDocumentReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/UidStringEntityReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/internal/reference/comparator/DocumentReferenceComparatorTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/AttachmentReferenceConverterTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/AttachmentReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/BlockReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/ClassPropertyReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTreeTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/LocalDocumentReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/LocalPageReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/ObjectPropertyReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/ObjectReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/PageAttachmentReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/PageClassPropertyReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/PageObjectPropertyReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/PageObjectReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/PageReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/RegexEntityReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/SpaceReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/WikiReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/script/ModelScriptServiceTest.java Log Message: ----------- [Misc] Make JUnit5 test classes and methods package-private (SonarCloud java:S5786) * Remove redundant public visibility modifiers from JUnit5 test classes and their test/lifecycle methods in xwiki-platform-model-api, as reported by SonarCloud rule java:S5786. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 11 Jul '26

11 Jul '26

Branch: refs/heads/claude/vigilant-dirac-mq9fj1 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0