- notifications - lists.xwiki.org

[[email protected]][Issue] Updates for LLMAI-169: MCP Add delete_attachment tool
by XWiki Notifications 25 Aug '26

25 Aug '26

1 0

[xwiki/xwiki-dev-llm] 19af3b: [Misc] Correct the java:S6213 denylist entry: only...
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/claude/cool-tesla-6a1n0j Home: https://github.com/xwiki/xwiki-dev-llm Commit: 19af3b500441f7ee8e2a31139b17031dce763b6f https://github.com/xwiki/xwiki-dev-llm/commit/19af3b500441f7ee8e2a31139b170… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M .claude-plugin/marketplace.json M kimi.plugin.json M opencode.jsonc M xwiki/.claude-plugin/plugin.json M xwiki/okf/sonarqube/index.md M xwiki/okf/sonarqube/syntax-rules.md Log Message: ----------- [Misc] Correct the java:S6213 denylist entry: only the method half is an API change * The entry rejects the whole rule because "a rename of a public method or field is an API change", but that is only true of the "Rename this method" half. "Rename this variable" is a parameter/local rename that changes no signature, and the message alone classifies each site. * Documented the variable half in syntax-rules with the two mechanics that make it scriptable (the look-behind that spares method calls, and skipping comment lines so the rename doesn't mangle prose). Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0

[xwiki/xwiki-rendering] 0b8c1c: [Misc] Compile a regex outside a loop and use Java...
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/claude/peaceful-archimedes-6a1n0j Home: https://github.com/xwiki/xwiki-rendering Commit: 0b8c1c31790327bc8ae138f18caa33b012222c48 https://github.com/xwiki/xwiki-rendering/commit/0b8c1c31790327bc8ae138f18ca… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki20/src/main/java/org/xwiki/rendering/internal/renderer/xwiki20/XWikiSyntaxChainingRenderer.java M xwiki-rendering-wikimodel/src/test/java/org/xwiki/rendering/wikimodel/ReferenceHandlerTest.java Log Message: ----------- [Misc] Compile a regex outside a loop and use Javadoc syntax (SonarQube) * java:S9142: hoist the parameter-value escaping regex of XWikiSyntaxChainingRenderer into a compiled Pattern constant instead of calling String#replaceAll() inside the parameter loop. * java:S9355: remove the two "(non-Javadoc)" block comments of ReferenceHandlerTest, which hold Javadoc tags without being Javadoc; the @Override annotations already say the methods are inherited. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-commons] 715d7c: [Misc] Rename the variables named "record" in the ...
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/claude/nifty-bell-6a1n0j Home: https://github.com/xwiki/xwiki-commons Commit: 715d7cb1285bb4dba0241729caccccf161aba122 https://github.com/xwiki/xwiki-commons/commit/715d7cb1285bb4dba0241729caccc… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/job/history/ExtensionJobHistory.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/job/history/ExtensionJobHistorySerializer.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/job/history/internal/DefaultExtensionJobHistory.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/job/history/internal/DefaultExtensionJobHistorySerializer.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/job/history/internal/ReplayJob.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/test/java/org/xwiki/extension/job/history/internal/DefaultExtensionJobHistoryTest.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/test/java/org/xwiki/extension/job/history/internal/ExtensionJobHistoryRecorderTest.java Log Message: ----------- [Misc] Rename the variables named "record" in the extension job history (SonarQube) * "record" is a restricted identifier in Java, so java:S6213 asks for a different name; renamed the 16 variables and parameters holding an ExtensionJobHistoryRecord to "historyRecord". * The two flagged *methods* named "record()" are left untouched: renaming QuestionRecorder#record(T) would break the public API. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-platform] 4c43d1: [Misc] Compile regular expressions outside of loop...
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/claude/clever-feynman-6a1n0j-s9142 Home: https://github.com/xwiki/xwiki-platform Commit: 4c43d1ef4db0a60a1b168fce7b498fde0b6567cf https://github.com/xwiki/xwiki-platform/commit/4c43d1ef4db0a60a1b168fce7b49… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-csrf/src/test/java/org/xwiki/csrf/DefaultCSRFTokenTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/main/java/org/xwiki/notifications/filters/migration/R160500000XWIKI22271DataMigration.java M xwiki-platform-core/xwiki-platform-query/xwiki-platform-query-manager/src/main/java/org/xwiki/query/internal/EscapeLikeParametersQuery.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-ui/src/test/java/org/xwiki/search/ui/SearchSuggestSourceSheetPageTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-transaction/src/main/java/org/xwiki/store/TransactionException.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-integration/src/main/java/org/xwiki/test/integration/XWikiExecutorSuite.java M xwiki-platform-tools/xwiki-platform-tool-standards-validator/src/main/java/org/xwiki/validator/HTML5DutchWebGuidelinesValidator.java Log Message: ----------- [Misc] Compile regular expressions outside of loops (SonarQube) * java:S9142: extract the regular expressions that were compiled on every iteration of a loop (through String#matches() or String#replaceAll()) into static Pattern constants. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] a3923c: [Misc] Explain why these code blocks are empty and...
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/claude/clever-feynman-6a1n0j Home: https://github.com/xwiki/xwiki-platform Commit: a3923c18589042084d3d66f1778040e401fdf026 https://github.com/xwiki/xwiki-platform/commit/a3923c18589042084d3d66f17780… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-feed/xwiki-platform-feed-api/src/main/java/com/xpn/xwiki/plugin/feed/FeedPlugin.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-api/src/main/java/org/xwiki/mail/MailStatus.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/main/java/org/xwiki/notifications/filters/internal/livedata/custom/NotificationCustomFiltersQueryHelper.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/Document.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/render/groovy/ParseGroovyFromString.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/monitor/api/MonitorPlugin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/monitor/api/MonitorTimer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/XWikiPluginManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/packaging/Package.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/GroovyAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiRightServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/ObjectRemoveAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/Utils.java Log Message: ----------- [Misc] Explain why these code blocks are empty and fix comment syntax (SonarQube) * java:S108: document the 80 empty blocks reported in 19 files with a comment saying why they are empty, and remove two blocks that are empty and useless (an empty finally and an empty else in XWiki). * java:S9355: turn the block comments that carry Javadoc tags into real Javadoc comments (MailStatus fields and XWiki#getUserTimeZone). Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 9803f2: [Misc] Fix Checkstyle violations in BaseCollection...
by XWiki Notifications 24 Aug '26

24 Aug '26

Branch: refs/heads/stable-17.10.x Home: https://github.com/xwiki/xwiki-platform Commit: 9803f26fb575e77dc454c63272bec6abd7668ed0 https://github.com/xwiki/xwiki-platform/commit/9803f26fb575e77dc454c63272be… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2026-08-24 (Mon, 24 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/pom.xml M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseCollection.java Log Message: ----------- [Misc] Fix Checkstyle violations in BaseCollection (#6100) Add missing Javadoc (class type param, @return/@param tags), fix DeclarationOrder by reordering fields by visibility, rename locals/parameters hiding fields or using snake_case, and extract helper methods in getDiff() and merge() to bring their complexity and parameter count back under the Checkstyle limits. Co-authored-by: Claude Sonnet 5 <noreply(a)anthropic.com> (cherry picked from commit 97b3fc2e4ee6ab633b6aed0a159f41bd310fe35f) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 059b8d: [Misc] Fix Checkstyle violations in BaseCollection...
by XWiki Notifications 24 Aug '26

24 Aug '26

Branch: refs/heads/stable-18.4.x Home: https://github.com/xwiki/xwiki-platform Commit: 059b8d895c61367cb3babcaf1671d646a432ba1f https://github.com/xwiki/xwiki-platform/commit/059b8d895c61367cb3babcaf1671… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2026-08-24 (Mon, 24 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/pom.xml M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseCollection.java Log Message: ----------- [Misc] Fix Checkstyle violations in BaseCollection (#6100) Add missing Javadoc (class type param, @return/@param tags), fix DeclarationOrder by reordering fields by visibility, rename locals/parameters hiding fields or using snake_case, and extract helper methods in getDiff() and merge() to bring their complexity and parameter count back under the Checkstyle limits. Co-authored-by: Claude Sonnet 5 <noreply(a)anthropic.com> (cherry picked from commit 97b3fc2e4ee6ab633b6aed0a159f41bd310fe35f) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki-contrib/ai-llm] 83f9ef: LLMAI-167: Add get_attachment tool (text/metadata/...
by XWiki Notifications 24 Aug '26

24 Aug '26

Branch: refs/heads/main Home: https://github.com/xwiki-contrib/ai-llm Commit: 83f9ef0d172c611c3f7ce2ed46d632948da7b8a3 https://github.com/xwiki-contrib/ai-llm/commit/83f9ef0d172c611c3f7ce2ed46d6… Author: Paul Pantiru <paul.pantiru(a)xwiki.com> Date: 2026-08-18 (Tue, 18 Aug 2026) Changed paths: A application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPAttachmentSupport.java A application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPGetAttachmentTool.java M application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPGetDocumentTool.java M application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/resources/META-INF/components.txt A application-ai-llm-mcp/application-ai-llm-mcp-server/src/test/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPAttachmentSupportTest.java A application-ai-llm-mcp/application-ai-llm-mcp-server/src/test/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPGetAttachmentToolTest.java M application-ai-llm-mcp/application-ai-llm-mcp-server/src/test/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPGetDocumentToolTest.java Log Message: ----------- LLMAI-167: Add get_attachment tool (text/metadata/download paths) * New get_attachment read tool: metadata header (mimetype, size, attachment version, author, date, document version, download URL), text-mimetype content inlined under the ~6000-token cap with line-offset continuation, other types answered with metadata plus the download URL; exact filename matching (no fuzzy extension fallback); metadata=true probes without opening content * Streaming reads are heap-bounded: a single line longer than the budget is hard-cut and drained (mid-line cut note; the skip phase stores nothing), so newline-less text attachments cannot blow the output cap or memory * get_document header gains an Attachments: line (10 entries then +K more, human sizes, mimetypes) across all response shapes * Filenames and mimetypes are wiki-authored data: every echo is fragment-guarded (line breaks stripped, 200-char clamp) * New MCPAttachmentSupport helper holds text-mimetype detection, human sizes, header/list lines and the bounded window reader * mcp-server 941 tests, checkstyle 0, jacoco met Commit: 2935efeee2f8dbffdb9b707bfbadf53e19a4ecf9 https://github.com/xwiki-contrib/ai-llm/commit/2935efeee2f8dbffdb9b707bfbad… Author: Paul Pantiru <paul.pantiru(a)xwiki.com> Date: 2026-08-18 (Tue, 18 Aug 2026) Changed paths: M application-ai-llm-mcp/application-ai-llm-mcp-server/pom.xml M application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPAttachmentSupport.java M application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPGetAttachmentTool.java M application-ai-llm-mcp/application-ai-llm-mcp-server/src/test/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPAttachmentSupportTest.java M application-ai-llm-mcp/application-ai-llm-mcp-server/src/test/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPGetAttachmentToolTest.java Log Message: ----------- LLMAI-167: get_attachment Tika extraction and inline image content * PDF/office/RTF attachments (incl. text/rtf) answer with Tika-extracted text, windowed under the same token cap and offset continuation as raw text; extraction failures degrade to the metadata header and download URL (store failures stay errors, like the text path); when extraction hits Tika's string cap the final window says the document continues beyond it * png/jpeg/gif/webp attachments up to 2 MB return a real image content block after the metadata header, so the model sees the image; larger or other image types fall back to metadata plus the download URL; reads are cap-bounded even when the declared size lies, with right-sized buffers for small images * image/svg+xml inlines as text (it is XML, not a vision format) * New dependency xwiki-platform-tika-detect for the shared platform TikaUtils (parsers ship in the XWiki WAR) * mcp-server 961 tests, checkstyle 0, jacoco met Commit: 4b7a81d987bc3f325702771579736215960a93f0 https://github.com/xwiki-contrib/ai-llm/commit/4b7a81d987bc3f32570277157973… Author: Paul Pantiru <paul.pantiru(a)xwiki.com> Date: 2026-08-18 (Tue, 18 Aug 2026) Changed paths: M application-ai-llm-mcp/application-ai-llm-mcp-server/pom.xml A application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPAttachmentWriteSupport.java A application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPWriteAttachmentTool.java M application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/resources/META-INF/components.txt A application-ai-llm-mcp/application-ai-llm-mcp-server/src/test/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPWriteAttachmentToolTest.java Log Message: ----------- LLMAI-168: Add write_attachment tool * Attaches a file to a document or overwrites an existing attachment: content (verbatim UTF-8 text - no trimming or line-ending normalization, content="" creates an empty file) XOR content_base64 (small binaries), both capped at 1M chars as the honest small-file ceiling; filenames refuse separators, semicolons and control characters * base_version discipline mirrors write_object: required when the document exists, omitted creates the document carrying the attachment; per-document lock and save-race recovery apply * Enforces the wiki's attachment policy via AttachmentValidator (Provider-injected, fail-closed refusal when the flavor-shipped implementation is absent); resets the stored mimetype after every write and clears the charset on binary overwrites of text files * Echoes attachment version (revisions kept in its history), document version with the base_version hint, size, mimetype, download URL and review line; [AI]-prefixed comment on document and attachment * New dependency xwiki-platform-attachment-validation-api * mcp-server 998 tests, checkstyle 0, jacoco met Commit: 8381b2202ca9c7f6c8530ace63583588795daec6 https://github.com/xwiki-contrib/ai-llm/commit/8381b2202ca9c7f6c8530ace6358… Author: Paul Pantiru <paul.pantiru(a)xwiki.com> Date: 2026-08-18 (Tue, 18 Aug 2026) Changed paths: M application-ai-llm-mcp/application-ai-llm-mcp-api/src/main/java/org/xwiki/contrib/llm/mcp/MCPToolSupport.java M application-ai-llm-mcp/application-ai-llm-mcp-api/src/test/java/org/xwiki/contrib/llm/mcp/MCPToolSupportTest.java M application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPWriteAttachmentTool.java M application-ai-llm-mcp/application-ai-llm-mcp-server/src/test/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPGetDocumentToolTest.java M application-ai-llm-mcp/application-ai-llm-mcp-server/src/test/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPWriteAttachmentToolTest.java Log Message: ----------- [Misc] Neutralize Unicode bidi controls in echoes and filenames * The shared line-break strip in MCPToolSupport also removes the 11 bidirectional formatting code points (U+202A-202E, U+2066-2069, U+200E/200F), closing intra-line spoofing of wiki-authored values in metadata lines (a filename whose bytes end .exe rendering as .txt); ZWJ/ZWNJ are deliberately kept for emoji and Indic/Persian text - hardens every tool's echoes at once * write_attachment refuses filenames containing directional formatting characters alongside the existing separator and control-character rule * mcp-api 66 tests, mcp-server checks green, checkstyle 0 in both Commit: 7332bf7c43870ae1858d42ee8a018ef0a7eefc4f https://github.com/xwiki-contrib/ai-llm/commit/7332bf7c43870ae1858d42ee8a01… Author: Paul Pantiru <paul.pantiru(a)xwiki.com> Date: 2026-08-18 (Tue, 18 Aug 2026) Changed paths: M application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPAttachmentSupport.java A application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPDeleteAttachmentTool.java M application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPGetAttachmentTool.java M application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPManTool.java M application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPWriteDocumentTool.java M application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/resources/META-INF/components.txt A application-ai-llm-mcp/application-ai-llm-mcp-server/src/test/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPDeleteAttachmentToolTest.java Log Message: ----------- LLMAI-169: Add delete_attachment tool * Deletes an attachment from a document behind Right.EDIT (the platform's own delattachment mapping), required base_version, the per-document lock and the sensitive-document denylist; refuses when the wiki has no attachment recycle bin, so deletion is always restorable via the UI; a miss lists the document's attachments * The removal stages through api.Document.removeAttachment so the attachmentsToRemove queue survives to the saved instance - XWikiDocument.clone() does not copy it, and staging on a manual pre-clone would silently drop the deletion at save time (adds are clone-safe, removals are not); the store contract is pinned by capturing the saved document's queued removal * Removals are recorded as minor versions with an [AI]-prefixed comment; echo carries size, mimetype, the restore note, the document version transition with the base_version hint and a Compare link * Man cross-link sweep: get/write/delete_attachment SEE ALSO chains, write_document NOTES points at the attachment tools, and the xwiki-syntax page links attach:/image: to get/write_attachment * mcp-server 1018 tests, checkstyle 0, jacoco met Commit: d4733419ed462021d4eddb5ec149b3d86b237fb8 https://github.com/xwiki-contrib/ai-llm/commit/d4733419ed462021d4eddb5ec149… Author: Paul Pantiru <paul.pantiru(a)xwiki.com> Date: 2026-08-18 (Tue, 18 Aug 2026) Changed paths: M application-ai-llm-mcp/application-ai-llm-mcp-server/src/main/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPWriteAttachmentTool.java M application-ai-llm-mcp/application-ai-llm-mcp-server/src/test/java/org/xwiki/contrib/llm/mcp/internal/tool/MCPWriteAttachmentToolTest.java Log Message: ----------- LLMAI-168: Fix stale attachment version in the overwrite echo * The real store bumps the attachment version on the api wrapper's internal save clone, never on the tool's staged copy, so the overwrite echo reported the pre-bump version while its own Download URL carried the new one; found in live validation * The echoed version, size, mimetype and Download URL now all come from the reloaded post-save document (with a staged-instance fallback that cannot fail a successful save); the overwrite test simulates the store's archive bump so the stale read fails it * mcp-server 1018 tests, checkstyle 0, jacoco met Compare: https://github.com/xwiki-contrib/ai-llm/compare/afc16b237f3c...d4733419ed46 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/ai-llm/settings/notifications

1 0

[[email protected]][Issue] Updates for XWIKI-24732: The fact that the page titles can be changed in edit mode is not so visible anymore
by XWiki Notifications 24 Aug '26

24 Aug '26

1 0