- notifications - lists.xwiki.org

[xwiki/xwiki-platform] 8c3fca: XWIKI-22978: Comments are not ordered by date (#4015)
by XWiki Notifications 01 Apr '25

01 Apr '25

Branch: refs/heads/backport/stable-17.2.x/pr-4015 Home: https://github.com/xwiki/xwiki-platform Commit: 8c3fca9f2f96087ac8b80ecf111e7d162f2529fd https://github.com/xwiki/xwiki-platform/commit/8c3fca9f2f96087ac8b80ecf111e… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2025-04-01 (Tue, 01 Apr 2025) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/commentsinline.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/CommentsIT.java A xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentElement.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentsTab.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/comments2.vm Log Message: ----------- XWIKI-22978: Comments are not ordered by date (#4015) Provide a quickfix for ordering the comments directly in commentsinline.vm. Since we cannot call directly $collectiontool.sort because the Object property cannot be accessed by beanutils, we build a sorted map indexed by date, taking into account the rare possibility that 2 comments have been added at exact same date. Also all this work is duplicated in comments2.vm for fixing it in old PDF export. Note that ideally all this work should be refactored with a proper Java API for comments, see also XWIKI-23049. (cherry picked from commit 7afb957e90c71f106ccbb06f9eed657cb6c8ec4a) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] fd71dd: XWIKI-22978: Comments are not ordered by date (#4015)
by XWiki Notifications 01 Apr '25

01 Apr '25

Branch: refs/heads/stable-16.4.x Home: https://github.com/xwiki/xwiki-platform Commit: fd71dd610fa6351e4fce3a260ea94054f1a84d8b https://github.com/xwiki/xwiki-platform/commit/fd71dd610fa6351e4fce3a260ea9… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2025-04-01 (Tue, 01 Apr 2025) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/commentsinline.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/CommentsIT.java A xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentElement.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentsTab.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/comments2.vm Log Message: ----------- XWIKI-22978: Comments are not ordered by date (#4015) Provide a quickfix for ordering the comments directly in commentsinline.vm. Since we cannot call directly $collectiontool.sort because the Object property cannot be accessed by beanutils, we build a sorted map indexed by date, taking into account the rare possibility that 2 comments have been added at exact same date. Also all this work is duplicated in comments2.vm for fixing it in old PDF export. Note that ideally all this work should be refactored with a proper Java API for comments, see also XWIKI-23049. (cherry picked from commit 7afb957e90c71f106ccbb06f9eed657cb6c8ec4a) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 01 Apr '25

01 Apr '25

Branch: refs/heads/backport/stable-16.4.x/pr-4015 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] f0651b: XWIKI-22978: Comments are not ordered by date (#4015)
by XWiki Notifications 01 Apr '25

01 Apr '25

Branch: refs/heads/stable-16.10.x Home: https://github.com/xwiki/xwiki-platform Commit: f0651b98ed094f800a5e36e7babab5c5354dacba https://github.com/xwiki/xwiki-platform/commit/f0651b98ed094f800a5e36e7baba… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2025-04-01 (Tue, 01 Apr 2025) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/commentsinline.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/CommentsIT.java A xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentElement.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentsTab.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/comments2.vm Log Message: ----------- XWIKI-22978: Comments are not ordered by date (#4015) Provide a quickfix for ordering the comments directly in commentsinline.vm. Since we cannot call directly $collectiontool.sort because the Object property cannot be accessed by beanutils, we build a sorted map indexed by date, taking into account the rare possibility that 2 comments have been added at exact same date. Also all this work is duplicated in comments2.vm for fixing it in old PDF export. Note that ideally all this work should be refactored with a proper Java API for comments, see also XWIKI-23049. (cherry picked from commit 7afb957e90c71f106ccbb06f9eed657cb6c8ec4a) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] d54033: XWIKI-22978: Comments are not ordered by date (#4015)
by XWiki Notifications 01 Apr '25

01 Apr '25

Branch: refs/heads/backport/stable-16.4.x/pr-4015 Home: https://github.com/xwiki/xwiki-platform Commit: d540339024db34ef24757fdba6d743b1d4bf9a77 https://github.com/xwiki/xwiki-platform/commit/d540339024db34ef24757fdba6d7… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2025-04-01 (Tue, 01 Apr 2025) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/commentsinline.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/CommentsIT.java A xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentElement.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentsTab.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/comments2.vm Log Message: ----------- XWIKI-22978: Comments are not ordered by date (#4015) Provide a quickfix for ordering the comments directly in commentsinline.vm. Since we cannot call directly $collectiontool.sort because the Object property cannot be accessed by beanutils, we build a sorted map indexed by date, taking into account the rare possibility that 2 comments have been added at exact same date. Also all this work is duplicated in comments2.vm for fixing it in old PDF export. Note that ideally all this work should be refactored with a proper Java API for comments, see also XWIKI-23049. (cherry picked from commit 7afb957e90c71f106ccbb06f9eed657cb6c8ec4a) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 68defd: XWIKI-22978: Comments are not ordered by date (#4015)
by XWiki Notifications 01 Apr '25

01 Apr '25

Branch: refs/heads/backport/stable-16.10.x/pr-4015 Home: https://github.com/xwiki/xwiki-platform Commit: 68defd50b780999ad885f365eecdc5d134649dca https://github.com/xwiki/xwiki-platform/commit/68defd50b780999ad885f365eecd… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2025-04-01 (Tue, 01 Apr 2025) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/commentsinline.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/CommentsIT.java A xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentElement.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentsTab.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/comments2.vm Log Message: ----------- XWIKI-22978: Comments are not ordered by date (#4015) Provide a quickfix for ordering the comments directly in commentsinline.vm. Since we cannot call directly $collectiontool.sort because the Object property cannot be accessed by beanutils, we build a sorted map indexed by date, taking into account the rare possibility that 2 comments have been added at exact same date. Also all this work is duplicated in comments2.vm for fixing it in old PDF export. Note that ideally all this work should be refactored with a proper Java API for comments, see also XWIKI-23049. (cherry picked from commit 7afb957e90c71f106ccbb06f9eed657cb6c8ec4a) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 01 Apr '25

01 Apr '25

Branch: refs/heads/XWIKI-22978-2 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 7afb95: XWIKI-22978: Comments are not ordered by date (#4015)
by XWiki Notifications 01 Apr '25

01 Apr '25

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 7afb957e90c71f106ccbb06f9eed657cb6c8ec4a https://github.com/xwiki/xwiki-platform/commit/7afb957e90c71f106ccbb06f9eed… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2025-04-01 (Tue, 01 Apr 2025) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/commentsinline.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/CommentsIT.java A xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentElement.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentsTab.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/comments2.vm Log Message: ----------- XWIKI-22978: Comments are not ordered by date (#4015) Provide a quickfix for ordering the comments directly in commentsinline.vm. Since we cannot call directly $collectiontool.sort because the Object property cannot be accessed by beanutils, we build a sorted map indexed by date, taking into account the rare possibility that 2 comments have been added at exact same date. Also all this work is duplicated in comments2.vm for fixing it in old PDF export. Note that ideally all this work should be refactored with a proper Java API for comments, see also XWIKI-23049. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 96c76a: XWIKI-22978: Comments are not ordered by date
by XWiki Notifications 01 Apr '25

01 Apr '25

Branch: refs/heads/XWIKI-22978-2 Home: https://github.com/xwiki/xwiki-platform Commit: 96c76adfdb8b193307e268635a3169a3349f86b1 https://github.com/xwiki/xwiki-platform/commit/96c76adfdb8b193307e268635a31… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2025-04-01 (Tue, 01 Apr 2025) Changed paths: M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/commentsinline.vm M xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-test/xwiki-platform-flamingo-skin-test-docker/src/test/it/org/xwiki/flamingo/test/docker/CommentsIT.java A xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentElement.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/po/CommentsTab.java M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/comments2.vm Log Message: ----------- XWIKI-22978: Comments are not ordered by date * Improve a bit the solution by using a sorted map * Provide integration tests and better PO to test comments To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[[email protected]][Issue] Updates for SHMACRO-11: Update the macro description to clarify its purpose
by XWiki Notifications 01 Apr '25

01 Apr '25

1 0