- notifications - lists.xwiki.org

[xwiki/xwiki-commons]
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/stable-18.6.x Home: https://github.com/xwiki/xwiki-commons To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[[email protected]][Issue] Updates for XRENDERING-812: PrintTextListener duplicates the no-op listener callbacks of EmptyWemListener
by XWiki Notifications 25 Aug '26

25 Aug '26

1 0

[xwiki/xwiki-rendering] 1922fe: XRENDERING-812: PrintTextListener duplicates the n...
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/XRENDERING-812 Home: https://github.com/xwiki/xwiki-rendering Commit: 1922fe051b62cee18c58edf430e327cf8e88e476 https://github.com/xwiki/xwiki-rendering/commit/1922fe051b62cee18c58edf430e… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M pom.xml M xwiki-rendering-wikimodel/src/main/java/org/xwiki/rendering/wikimodel/PrintTextListener.java Log Message: ----------- XRENDERING-812: PrintTextListener duplicates the no-op listener callbacks of EmptyWemListener * Make PrintTextListener extend EmptyWemListener instead of implementing IWemListener directly, and drop the 34 no-op callbacks it no longer needs to declare, so that the empty implementations of the listener interface exist in one place only. * Keep beginDocument(WikiParameters) as an explicit no-op override: EmptyWemListener forwards it to the no-arg beginDocument(), which would otherwise start invoking a subclass override of it that was never called before. * Add justified Revapi ignores for the java.class.nonFinalClassInheritsFromNewClass difference the new supertype introduces on PrintTextListener, EventDumpListener, PrintInlineListener and PrintListener. Nothing is removed from the public API: the methods that stop being declared stay reachable through the superclass, and the only members the supertype adds are the no-arg beginDocument() and endDocument() no-ops. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[[email protected]][Issue] Updates for XINFRA-479: Update and Convert Documentation for WebSphere
by XWiki Notifications 25 Aug '26

25 Aug '26

1 0

[[email protected]][Issue] Updates for XWIKI-23660: Convert users.less to CSS
by XWiki Notifications 25 Aug '26

25 Aug '26

1 0

[xwiki/xwiki-dev-llm] 3c3b4d: [Misc] Scope the TODO rule to swallowed exceptions...
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/claude/cool-tesla-6a1n0j Home: https://github.com/xwiki/xwiki-dev-llm Commit: 3c3b4d68308de2517dcee0be11cca577d6d54820 https://github.com/xwiki/xwiki-dev-llm/commit/3c3b4d68308de2517dcee0be11cca… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki/okf/conventions/code-comments.md Log Message: ----------- [Misc] Scope the TODO rule to swallowed exceptions, not to every empty block Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0

[xwiki/xwiki-dev-llm] 9ef09d: [Misc] Record two comment conventions enforced in ...
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/claude/cool-tesla-6a1n0j Home: https://github.com/xwiki/xwiki-dev-llm Commit: 9ef09dc7a93ed6fabd9937a81272538c7f515118 https://github.com/xwiki/xwiki-dev-llm/commit/9ef09dc7a93ed6fabd9937a812725… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki/okf/conventions/code-comments.md M xwiki/okf/conventions/code-style.md Log Message: ----------- [Misc] Record two comment conventions enforced in review * An empty catch needs a "// TODO:" asking to log a warning or to change the logic, not just a rationale comment: a catch that neither rethrows nor logs is a bug to fix later, not a decision to document. * A Javadoc comment is always multi-line, never the one-line form, and a file still using the one-line form gets converted when it is touched. Neither rule is on the dev wiki CodeStyle page. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0

[xwiki/xwiki-platform] 8c674a: [Misc] Use the multi-line Javadoc format in Defaul...
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/claude/clever-feynman-6a1n0j-s9142 Home: https://github.com/xwiki/xwiki-platform Commit: 8c674ad6925092b219c6bf0f21d2f66c92960b62 https://github.com/xwiki/xwiki-platform/commit/8c674ad6925092b219c6bf0f21d2… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-csrf/src/test/java/org/xwiki/csrf/DefaultCSRFTokenTest.java Log Message: ----------- [Misc] Use the multi-line Javadoc format in DefaultCSRFTokenTest * Following review: the single-line /** xxx */ form is not the house style, so the comment added by the previous commit and the three the file already had are converted to the multi-line form. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 9e3be4: [Misc] Turn the empty-block comments into TODOs (S...
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/claude/clever-feynman-6a1n0j Home: https://github.com/xwiki/xwiki-platform Commit: 9e3be4c2f387887552170c3974d34f1410566ca9 https://github.com/xwiki/xwiki-platform/commit/9e3be4c2f387887552170c3974d3… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-feed/xwiki-platform-feed-api/src/main/java/com/xpn/xwiki/plugin/feed/FeedPlugin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/Document.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/render/groovy/ParseGroovyFromString.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/monitor/api/MonitorPlugin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/monitor/api/MonitorTimer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/XWikiPluginManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/packaging/Package.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/GroovyAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiRightServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/ObjectRemoveAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/Utils.java Log Message: ----------- [Misc] Turn the empty-block comments into TODOs (SonarQube) * Following review: a catch that neither rethrows nor logs is a bug to fix later, so each comment now starts with a "// TODO:" asking either to log a warning, or (where an exception is the expected outcome) to change the logic so the case isn't signalled by an exception. * The two blocks that are not exception handling (dropping XML control characters, an empty switch default) keep their plain comment. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-commons]
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/backport/stable-18.4.x/XCOMMONS-3661 Home: https://github.com/xwiki/xwiki-commons To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0