- notifications - lists.xwiki.org

[xwiki/xwiki-platform] 270510: [Misc] Keep || rather than ?? for the default assi...
by XWiki Notifications 20 Aug '26

20 Aug '26

Branch: refs/heads/claude/clever-feynman-kebkgq-js Home: https://github.com/xwiki/xwiki-platform Commit: 2705107345f2e32e73f306cd36e7b74c7d6e7d77 https://github.com/xwiki/xwiki-platform/commit/2705107345f2e32e73f306cd36e7… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-20 (Thu, 20 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/table/livetable.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/xwiki.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/model/entityReference.js Log Message: ----------- [Misc] Keep || rather than ?? for the default assignments The flagged conditional expressions tested truthiness, so || is the exact translation and ?? would be a behaviour change for a falsy-but-not-nullish operand. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] f85848: [Misc] Keep the mono-source comment inside the els...
by XWiki Notifications 20 Aug '26

20 Aug '26

Branch: refs/heads/claude/clever-feynman-kebkgq-js Home: https://github.com/xwiki/xwiki-platform Commit: f85848a3fa0eb0198a77abeb66fea127f3d3f1a0 https://github.com/xwiki/xwiki-platform/commit/f85848a3fa0eb0198a77abeb66fe… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-20 (Thu, 20 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/suggest.js Log Message: ----------- [Misc] Keep the mono-source comment inside the else if body Trailing comments on a condition line are not the house style, so the comment goes back to the first line of the merged branch, which is what the rest of the code base does. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] a4eeac: [Misc] Address the review feedback on the JavaScri...
by XWiki Notifications 20 Aug '26

20 Aug '26

Branch: refs/heads/claude/clever-feynman-kebkgq-js Home: https://github.com/xwiki/xwiki-platform Commit: a4eeac637cd096d06fb4f9f4f0b8f0249b1b10b4 https://github.com/xwiki/xwiki-platform/commit/a4eeac637cd096d06fb4f9f4f0b8… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-20 (Thu, 20 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/table/livetable.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/xwiki.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/model/entityReference.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/suggest.js Log Message: ----------- [Misc] Address the review feedback on the JavaScript SonarQube fixes * Use `??` instead of `||` for the three javascript:S6644 default assignments, as requested: `??` falls back only on `null`/`undefined` rather than on every falsy value. In `entityReference.js` this also removes a latent trap, because `parentType` can legitimately be `EntityType.WIKI`, which is `0`. * Move the relocated comment in `suggest.js` onto the `else if` line it describes, since "if present" is now expressed by the condition itself. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[[email protected]][Issue] Updates for OIDC-308: The extension doesn't work on version 2.25.3
by XWiki Notifications 20 Aug '26

20 Aug '26

1 0

[[email protected]][Issue] Updates for OIDC-308: The extension doesn't work on version 2.25.3
by XWiki Notifications 20 Aug '26

20 Aug '26

1 0

[[email protected]][Issue] Updates for SHMACRO-12: Stored cross-site scripting in XWiki ShowHide Macro through an unescaped showmessage
by XWiki Notifications 20 Aug '26

20 Aug '26

1 0

[xwiki/xwiki-platform] 274efe: [Misc] Fix SonarQube javascript:S6582 issues needi...
by XWiki Notifications 20 Aug '26

20 Aug '26

Branch: refs/heads/claude/clever-feynman-jjfq8h-js-judgement Home: https://github.com/xwiki/xwiki-platform Commit: 274efe97201350a9cef25b77f9465b05bbfe324a https://github.com/xwiki/xwiki-platform/commit/274efe97201350a9cef25b77f946… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-20 (Thu, 20 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/widgets/buttonGroup.js Log Message: ----------- [Misc] Fix SonarQube javascript:S6582 issues needing a judgement call * Use optional chaining instead of an && guard on the five sites where the result is assigned to a variable rather than used as a condition, so the equivalence relies on the left operand never being a falsy primitive Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 175b02: [Misc] Fix various JavaScript SonarQube issues rep...
by XWiki Notifications 20 Aug '26

20 Aug '26

Branch: refs/heads/claude/clever-feynman-jjfq8h-js Home: https://github.com/xwiki/xwiki-platform Commit: 175b022f81996209bf14c255edfa71d2c123992f https://github.com/xwiki/xwiki-platform/commit/175b022f81996209bf14c255edfa… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-20 (Thu, 20 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-tree/xwiki-platform-tree-war/src/main/webapp/resources/uicomponents/widgets/tree.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/editors/dataeditors.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/eventsBridge.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/widgets/jumpToPage.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/attachments/icons.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/exporter/exporter.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/extension/distribution.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/extension/history.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/lock/lock.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/logging/logging.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/suggestAttachments.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/suggestPages.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/tools/formAsyncValidation.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/widgets/buttonGroup.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/widgets/gallery/gallery.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/widgets/select/select.js M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/widgets/sortPicker.js Log Message: ----------- [Misc] Fix various JavaScript SonarQube issues reported by SonarCloud * javascript:S6582 (31): use optional chaining instead of an && guard, where the rewrite is provably equivalent (result used only for truthiness, or the receiver can only be an object or null/undefined, or it is a string) * javascript:S7765 (12): use String/Array includes() instead of comparing indexOf() against -1 Vendored third-party scripts and files claimed by other open pull requests were left untouched. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] b06db5: [Misc] Fix printf-style format string issues repor...
by XWiki Notifications 20 Aug '26

20 Aug '26

Branch: refs/heads/claude/clever-feynman-jjfq8h Home: https://github.com/xwiki/xwiki-platform Commit: b06db53b57d4a0257e7c6bf5cc282421f587416b https://github.com/xwiki/xwiki-platform/commit/b06db53b57d4a0257e7c6bf5cc28… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-20 (Thu, 20 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-chart/xwiki-platform-chart-macro/src/main/java/org/xwiki/rendering/internal/macro/chart/source/table/DocumentTableBlockDataSource.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-events-hibernate/xwiki-platform-legacy-events-hibernate-api/src/main/java/org/xwiki/notifications/sources/internal/ExpressionNodeToHQLConverter.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/main/java/org/xwiki/notifications/notifiers/internal/email/NotificationEmailJob.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/FileSystemURLFactory.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/objects/NumberPropertyParser.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/main/java/org/xwiki/rest/internal/resources/classes/DefaultClassPropertyValuesProvider.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/DefaultSolrIndexer.java Log Message: ----------- [Misc] Fix printf-style format string issues reported by SonarQube (java:S3457) * Use %s instead of the SLF4J {} placeholder in three String.format() calls where the argument was silently dropped from the produced message * Chain the caught exception instead of passing it as an unused format argument * Remove an unused third argument of a two-specifier format string * Pass a File and an enum directly to the logger instead of calling toString() Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[[email protected]][Issue] Updates for XWIKI-24689: Wrong javadoc on LikeRight: it does not imply Login and View rights
by XWiki Notifications 19 Aug '26

19 Aug '26

1 0