- notifications - lists.xwiki.org

[xwiki/xwiki-platform] 5b90f1: XWIKI-24702: Create/check for automated tests for ...
by XWiki Notifications 14 Aug '26

14 Aug '26

Branch: refs/heads/backport/stable-18.4.x/pr-6168 Home: https://github.com/xwiki/xwiki-platform Commit: 5b90f119953063b4f523fb8be6931fb8825bc612 https://github.com/xwiki/xwiki-platform/commit/5b90f119953063b4f523fb8be693… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-14 (Fri, 14 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/DefaultAuthorizationManagerIntegrationTest.java A xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/resources/testwikis/userDenyEditAtDocumentLevel.xml Log Message: ----------- XWIKI-24702: Create/check for automated tests for "Deny Edit Rights for an user" (#6168) * Add DefaultAuthorizationManagerIntegrationTest#userDenyEditAtDocumentLevel and its testwikis fixture: denying the edit right to a user on a document takes that right away from that user on that document only, leaving its other rights and the other users untouched. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> (cherry picked from commit 0b87cfd53df1f741d6020fdf632f0916e3227858) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 0863c1: XWIKI-24587: Create/check for automated tests for ...
by XWiki Notifications 14 Aug '26

14 Aug '26

Branch: refs/heads/stable-17.10.x Home: https://github.com/xwiki/xwiki-platform Commit: 0863c155e956711a37ac5debf85db8fda5d97063 https://github.com/xwiki/xwiki-platform/commit/0863c155e956711a37ac5debf85d… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-14 (Fri, 14 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-docker/src/test/it/org/xwiki/administration/test/ui/UsersGroupsRightsManagementIT.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/DefaultAuthorizationManagerIntegrationTest.java A xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/resources/testwikis/groupRightsAtSpaceLevelVersusUserDenyAtWikiLevel.xml Log Message: ----------- XWIKI-24587: Create/check for automated tests for "Deny the rights for a user at wiki level and give rights to a group at page level" The manual test denies the "edit" right to a user at wiki level, then grants view, comment and edit to a group that user belongs to at page level, and expects the user to have no Edit option on the wiki but to have one on that page. No existing test covered that combination: tieResolutionPolicy() pits a user DENY against a group ALLOW but with both rules at the same (wiki) level, the inheritancePolicyFor*() tests do override a wiki-level DENY at a lower level but with user rules only, and UsersGroupsRightsManagementIT.groupRights() sets a page-level group DENY with no wiki-level rule. Add the functional test driving the same UI path as the manual test: deny from Administer Wiki > Users & Rights > Rights > Users, then grant from Administer Page > Users & Rights > Rights: Page & Children. It asserts the Edit option is absent on a page outside the space and present on the granted page. The two assertions cross-validate each other, so the test cannot pass vacuously: the first one proves the wiki-level deny is really in effect, hence the second one can only pass if the page-level group rules override it. Also pin the underlying authorization semantics at the settler level with a testwiki fixture, so that a regression in the rule resolution fails in under a second rather than only inside the Selenium run. A velocity hasAccess() probe against the running instance confirmed both levels agree: the user genuinely holds the edit right on the granted page, so the visible Edit option is not a side effect of the comment right. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> (cherry picked from commit 46c1457a74674458dd0e9c2e3cdb43b3ce347e67) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] c66320: XWIKI-24587: Create/check for automated tests for ...
by XWiki Notifications 14 Aug '26

14 Aug '26

Branch: refs/heads/stable-18.4.x Home: https://github.com/xwiki/xwiki-platform Commit: c66320d68192abe4acffd5d3bdbccf6ece201f2c https://github.com/xwiki/xwiki-platform/commit/c66320d68192abe4acffd5d3bdbc… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-14 (Fri, 14 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-docker/src/test/it/org/xwiki/administration/test/ui/UsersGroupsRightsManagementIT.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/DefaultAuthorizationManagerIntegrationTest.java A xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/resources/testwikis/groupRightsAtSpaceLevelVersusUserDenyAtWikiLevel.xml Log Message: ----------- XWIKI-24587: Create/check for automated tests for "Deny the rights for a user at wiki level and give rights to a group at page level" The manual test denies the "edit" right to a user at wiki level, then grants view, comment and edit to a group that user belongs to at page level, and expects the user to have no Edit option on the wiki but to have one on that page. No existing test covered that combination: tieResolutionPolicy() pits a user DENY against a group ALLOW but with both rules at the same (wiki) level, the inheritancePolicyFor*() tests do override a wiki-level DENY at a lower level but with user rules only, and UsersGroupsRightsManagementIT.groupRights() sets a page-level group DENY with no wiki-level rule. Add the functional test driving the same UI path as the manual test: deny from Administer Wiki > Users & Rights > Rights > Users, then grant from Administer Page > Users & Rights > Rights: Page & Children. It asserts the Edit option is absent on a page outside the space and present on the granted page. The two assertions cross-validate each other, so the test cannot pass vacuously: the first one proves the wiki-level deny is really in effect, hence the second one can only pass if the page-level group rules override it. Also pin the underlying authorization semantics at the settler level with a testwiki fixture, so that a regression in the rule resolution fails in under a second rather than only inside the Selenium run. A velocity hasAccess() probe against the running instance confirmed both levels agree: the user genuinely holds the edit right on the granted page, so the visible Edit option is not a side effect of the comment right. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> (cherry picked from commit 46c1457a74674458dd0e9c2e3cdb43b3ce347e67) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 7b34a8: XCOMMONS-3743: Upgrade to Apache Commons Collectio...
by XWiki Notifications 14 Aug '26

14 Aug '26

Branch: refs/heads/XCOMMONS-3743 Home: https://github.com/xwiki/xwiki-platform Commit: 7b34a8c65e16a54b0c28ba950814dfb43b14311f https://github.com/xwiki/xwiki-platform/commit/7b34a8c65e16a54b0c28ba950814… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-14 (Fri, 14 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightSetTest.java Log Message: ----------- XCOMMONS-3743: Upgrade to Apache Commons Collections 4.6.0 * Fix the test compilation of xwiki-platform-security-authorization-api, broken by the upgrade: AbstractSetTest#testSetEquals() is package private in Commons Collections 4.6.0 and can no longer be overridden by RightSetTest, which lives in another package. * Make RightSetTest extend AbstractCollectionTest instead of AbstractSetTest, and reproduce there the set specific verifications and tests over Right elements: the inherited ones add a String to the collection under test, which a RightSet cannot hold. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[[email protected]][Issue] Updates for XWIKI-24702: Create/check for automated tests for "Deny Edit Rights for an user"
by XWiki Notifications 14 Aug '26

14 Aug '26

1 0

[[email protected]][Issue] Updates for XWIKI-24704: Create/check for automated tests for "Deny Comment Rights for an user"
by XWiki Notifications 14 Aug '26

14 Aug '26

1 0

[[email protected]][Issue] Updates for XWIKI-24703: Create/check for automated tests for "Deny Edit Rights for a group"
by XWiki Notifications 14 Aug '26

14 Aug '26

1 0

[xwiki/xwiki-platform] 99d8af: XWIKI-24704: Create/check for automated tests for ...
by XWiki Notifications 14 Aug '26

14 Aug '26

Branch: refs/heads/backport/stable-18.4.x/pr-6170 Home: https://github.com/xwiki/xwiki-platform Commit: 99d8af4346bd706174311b10966d0849604899c8 https://github.com/xwiki/xwiki-platform/commit/99d8af4346bd706174311b10966d… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-14 (Fri, 14 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/DefaultAuthorizationManagerIntegrationTest.java A xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/resources/testwikis/userDenyCommentAtDocumentLevel.xml Log Message: ----------- XWIKI-24704: Create/check for automated tests for "Deny Comment Rights for an user" (#6170) * Add DefaultAuthorizationManagerIntegrationTest#userDenyCommentAtDocumentLevel and its testwikis fixture: denying the comment right to a user on a document takes that right away from that user on that document only, leaving its other rights, the edit right included, and the other users untouched. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> (cherry picked from commit 9fe8814de8921abfca2df80d576138ecbf8c92f7) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 84df03: XWIKI-24704: Create/check for automated tests for ...
by XWiki Notifications 14 Aug '26

14 Aug '26

Branch: refs/heads/backport/stable-17.10.x/pr-6170 Home: https://github.com/xwiki/xwiki-platform Commit: 84df03a54013aee12d1e7f030daf7548b0e5e847 https://github.com/xwiki/xwiki-platform/commit/84df03a54013aee12d1e7f030daf… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-14 (Fri, 14 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/DefaultAuthorizationManagerIntegrationTest.java A xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/resources/testwikis/userDenyCommentAtDocumentLevel.xml Log Message: ----------- XWIKI-24704: Create/check for automated tests for "Deny Comment Rights for an user" (#6170) * Add DefaultAuthorizationManagerIntegrationTest#userDenyCommentAtDocumentLevel and its testwikis fixture: denying the comment right to a user on a document takes that right away from that user on that document only, leaving its other rights, the edit right included, and the other users untouched. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> (cherry picked from commit 9fe8814de8921abfca2df80d576138ecbf8c92f7) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 23aedb: XWIKI-24703: Create/check for automated tests for ...
by XWiki Notifications 14 Aug '26

14 Aug '26

Branch: refs/heads/backport/stable-18.4.x/pr-6169 Home: https://github.com/xwiki/xwiki-platform Commit: 23aedb35a5f0453f4504f0f4e00cb3fe6bedb54a https://github.com/xwiki/xwiki-platform/commit/23aedb35a5f0453f4504f0f4e00c… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-14 (Fri, 14 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/DefaultAuthorizationManagerIntegrationTest.java A xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/resources/testwikis/groupDenyEditAtDocumentLevel.xml Log Message: ----------- XWIKI-24703: Create/check for automated tests for "Deny Edit Rights for a group" (#6169) * Add DefaultAuthorizationManagerIntegrationTest#groupDenyEditAtDocumentLevel and its testwikis fixture: denying the edit right to a group on a document takes that right away from the members of that group on that document only, leaving their other rights and the non members untouched. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> (cherry picked from commit 9192489304fea5226357bcd3c2ad541bc7c47f83) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0