- notifications - lists.xwiki.org

[xwiki/xwiki-rendering] d8ce0b: XWIKI-24665: Apply the logging best practices acro...
by XWiki Notifications 06 Aug '26

06 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-rendering Commit: d8ce0b9f62066655864588b4b76f0a95006d0466 https://github.com/xwiki/xwiki-rendering/commit/d8ce0b9f62066655864588b4b76… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-06 (Thu, 06 Aug 2026) Changed paths: M xwiki-rendering-transformations/xwiki-rendering-transformation-macro/src/main/java/org/xwiki/rendering/internal/macro/DefaultMacroManager.java M xwiki-rendering-transformations/xwiki-rendering-transformation-macro/src/test/java/org/xwiki/rendering/internal/macro/DefaultMacroManagerTest.java Log Message: ----------- XWIKI-24665: Apply the logging best practices across commons, rendering and platform * Rewrite the invalid-macro-hint warning of DefaultMacroManager#getMacroIds so that the message states the consequence and the guidance only. The caught exception comes from DefaultMacroIdFactory one frame away, where the single reachable throw already says the hint format is invalid, so the previous message duplicated its own root cause. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[[email protected]][Issue] Updates for XWIKI-24628: Rename of page should be blocked when name strategy validation is enabled and not complied with
by XWiki Notifications 06 Aug '26

06 Aug '26

1 0

[[email protected]][Issue] Updates for CONFLUENCE-534: Endless loop when converting complex content combining several features involving queued listeners
by XWiki Notifications 06 Aug '26

06 Aug '26

1 0

[[email protected]][Issue] Updates for XWIKI-24630: Location of page should be transformed following name strategy in rename UI
by XWiki Notifications 06 Aug '26

06 Aug '26

1 0

[[email protected]][Issue] Updates for CONFLUENCE-533: Endless Loop in ConfluenceConverterListener / ConfluenceWrappingListener
by XWiki Notifications 06 Aug '26

06 Aug '26

1 0

[[email protected]][Issue] Updates for XLIT-24: LiveTable filter fails for dotted usernames
by XWiki Notifications 06 Aug '26

06 Aug '26

1 0

[xwiki/xwiki-platform] 5a8a88: [Misc] Fix Checkstyle violations in BaseCollection
by XWiki Notifications 06 Aug '26

06 Aug '26

Branch: refs/heads/fix/basecollection-checkstyle Home: https://github.com/xwiki/xwiki-platform Commit: 5a8a88d45ce8edf07d9c2e5bd2ceaafdb59f3672 https://github.com/xwiki/xwiki-platform/commit/5a8a88d45ce8edf07d9c2e5bd2ce… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2026-08-06 (Thu, 06 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/pom.xml M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseCollection.java Log Message: ----------- [Misc] Fix Checkstyle violations in BaseCollection Add missing Javadoc (class type param, @return/@param tags), fix DeclarationOrder by reordering fields by visibility, rename locals/parameters hiding fields or using snake_case, add a hashCode() matching equals(), and extract helper methods in getDiff() and merge() to bring their complexity and parameter count back under the Checkstyle limits. Co-Authored-By: Claude Sonnet 5 <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[[email protected]][Issue] Updates for NCAPP-93: Closing brackets not displayed in TOC
by XWiki Notifications 06 Aug '26

06 Aug '26

1 0

[xwiki/xwiki-platform] 09ccd6: XWIKI-24665: Apply the logging best practices acro...
by XWiki Notifications 06 Aug '26

06 Aug '26

Branch: refs/heads/XWIKI-24665-warn-throwable Home: https://github.com/xwiki/xwiki-platform Commit: 09ccd64ab0309e3b8ad866ae43260f890fab33ad https://github.com/xwiki/xwiki-platform/commit/09ccd64ab0309e3b8ad866ae4326… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-06 (Thu, 06 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-io/src/main/java/org/xwiki/annotation/rights/internal/XWikiAnnotationRightService.java M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-maintainer/src/main/java/org/xwiki/annotation/maintainer/internal/DocumentContentAnnotationUpdateListener.java M xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-wiki/src/main/java/org/xwiki/component/wiki/internal/bridge/WikiObjectComponentManagerEventListenerProxy.java M xwiki-platform-core/xwiki-platform-display/xwiki-platform-display-api/src/main/java/org/xwiki/display/internal/AbstractDocumentTitleDisplayer.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/main/java/org/xwiki/eventstream/AbstractRecordableEventDescriptor.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/main/java/org/xwiki/eventstream/internal/AbstractAsynchronousEventStore.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/AbstractRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-default/src/main/java/org/xwiki/eventstream/internal/DefaultUntypedRecordableEventDescriptor.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-default/src/main/java/org/xwiki/eventstream/internal/UntypedEventListener.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-default/src/test/java/org/xwiki/eventstream/internal/DefaultUntypedRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-stores/xwiki-platform-eventstream-store-common/src/main/java/org/xwiki/eventstream/store/internal/RecordableEventListener.java M xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-api/src/main/java/org/xwiki/export/pdf/browser/AbstractBrowserPDFPrinter.java M xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-api/src/test/java/org/xwiki/export/pdf/browser/BrowserPDFPrinterTest.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/XarExtensionJobFinishedListener.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/job/RepairXarJob.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-versioncheck/src/main/java/org/xwiki/extension/versioncheck/internal/VersionCheckInitializer.java M xwiki-platform-core/xwiki-platform-filter/xwiki-platform-filter-streams/xwiki-platform-filter-stream-xar/src/main/java/org/xwiki/filter/xar/internal/input/WikiReader.java M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-processing/xwiki-platform-image-processing-plugin/src/main/java/com/xpn/xwiki/plugin/image/ImagePlugin.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-notifications/xwiki-platform-legacy-notifications-notifiers/xwiki-platform-legacy-notifications-notifiers-api/src/main/java/org/xwiki/notifications/notifiers/internal/email/live/LiveNotificationEmailListener.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/web/TempResourceAction.java M xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-script/src/main/java/org/xwiki/localization/script/LocalizationScriptService.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/internal/DeletedDocumentCleanUpFilterProcessingQueue.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/internal/user/EventUserFilterPreferencesGetter.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/main/java/org/xwiki/notifications/filters/internal/migrators/ScopeNotificationFilterClassMigrator.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-watch/src/main/java/org/xwiki/notifications/filters/watch/internal/AutomaticWatchModeListener.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-api/src/main/java/org/xwiki/notifications/notifiers/internal/email/live/PrefilteringLiveNotificationEmailManager.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/main/java/org/xwiki/notifications/notifiers/internal/email/AbstractMimeMessageIterator.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/main/java/org/xwiki/notifications/notifiers/internal/email/UserAvatarAttachmentExtractor.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-preferences/xwiki-platform-notifications-preferences-default/src/main/java/org/xwiki/notifications/preferences/internal/email/DefaultNotificationEmailUserPreferenceManager.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-sources/src/main/java/org/xwiki/notifications/sources/internal/TagNotificationFilter.java M xwiki-platform-core/xwiki-platform-observation/xwiki-platform-observation-remote/src/main/java/org/xwiki/observation/remote/internal/jgroups/JGroupsNetworkChannel.java M xwiki-platform-core/xwiki-platform-office/xwiki-platform-office-importer/src/main/java/org/xwiki/officeimporter/internal/server/DefaultOfficeServer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/DeletedAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/DeletedDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/User.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/DefaultCoreConfiguration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/context/XWikiContextContextStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/export/OfficeExporter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/query/ConfiguredQueryExecutorProvider.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/sheet/AbstractSheetBinder.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/sheet/DefaultModelBridge.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/store/PropertyConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/GroupsClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/UsersClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/FileSystemURLFactory.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/PdfExportImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/fileupload/FileUploadPlugin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/rightsmanager/RightsManagerListener.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/script/display/DisplayScriptService.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateRecycleBinStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/hibernate/HibernateAttachmentRecycleBinStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R140600000XWIKI19869DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/UploadAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/script/XWikiScriptContextInitializer.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultModelBridge.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/DefaultModelBridgeTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-store/src/main/java/org/xwiki/rendering/wikimacro/internal/RegisterMacrosOnImportListener.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-api/src/main/java/org/xwiki/search/solr/internal/DefaultSolrIndexer.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-query/src/main/java/org/xwiki/query/solr/internal/SolrQueryExecutor.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-query/src/test/java/org/xwiki/query/solr/internal/SolrQueryExecutorTest.java M xwiki-platform-core/xwiki-platform-sheet/xwiki-platform-sheet-api/src/main/java/org/xwiki/sheet/internal/SheetDocumentDisplayer.java M xwiki-platform-core/xwiki-platform-sheet/xwiki-platform-sheet-api/src/test/java/org/xwiki/sheet/internal/SheetDocumentDisplayerTest.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/web/sx/CssExtension.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/main/java/org/xwiki/store/legacy/store/internal/FilesystemAttachmentStore.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/DockerTestUtils.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-docker/src/main/java/org/xwiki/test/docker/internal/junit5/StopFileWatcher.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-script/src/main/java/org/xwiki/user/script/GroupScriptService.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-script/src/test/java/org/xwiki/user/script/GroupScriptServiceTest.java M xwiki-platform-core/xwiki-platform-websocket/src/main/java/org/xwiki/websocket/AbstractXWikiEndpoint.java M xwiki-platform-core/xwiki-platform-websocket/src/main/java/org/xwiki/websocket/internal/DefaultWebSocketContext.java M xwiki-platform-core/xwiki-platform-websocket/src/main/java/org/xwiki/websocket/internal/StaticEchoEndpoint.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-default/src/main/java/org/xwiki/wiki/internal/descriptor/properties/DefaultWikiPropertyGroupManager.java M xwiki-platform-core/xwiki-platform-xml/xwiki-platform-xml-script/src/main/java/org/xwiki/xml/script/XMLScriptService.java M xwiki-platform-core/xwiki-platform-xml/xwiki-platform-xml-script/src/test/java/org/xwiki/xml/script/XMLScriptServiceTest.java Log Message: ----------- XWIKI-24665: Apply the logging best practices across commons, rendering and platform * Restore the throwable as the trailing SLF4J argument in the 106 warn() calls where it had been replaced by ExceptionUtils.getRootCauseMessage(e) formatted into the message * A throwable passed as the last argument lands in a structured field: ILoggingEvent's throwable proxy, XWiki's own LogEvent throwable, and the stack trace field of the ECS and OpenTelemetry encoders. Whoever renders the log then decides whether to show the trace, the way the job log displayer shows the root cause and keeps the trace one click away. A cause formatted into the message is only text: the trace is lost for every consumer and no renderer can offer it * The message improvements are kept — {} placeholders instead of %s or {0}, values in brackets, placeholders that were missing — so only the root-cause clause and the trailing argument change * FileSystemURLFactory: the clause is stripped from the shared SAVE_IMAGE_ERROR constant, so both of its call sites log the throwable * Update the five tests that asserted a removed clause, and drop the ExceptionUtils imports left unused Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[[email protected]][Issue] Updates for XWIKI-24666: Wrong version index when some version pages already exist
by XWiki Notifications 06 Aug '26

06 Aug '26

1 0