There are 4 comments.
 
 
XWiki Platform / cid:jira-generated-image-avatar-c829d3f4-f282-4a0e-b5b2-2245d5bcb593 XWIKI-21286 Reopened

Upgrade to JSqlParser 5.3

 
View issue   ·   Add comment
 

4 comments

 
cid:jira-generated-image-avatar-605065c2-da3d-4ed9-93fb-a289b690f1d8 Thomas Mortagne on 06/Aug/26 19:09
 
There is unfortunately a serious regression introduce in 4.8 , see https://github.com/JSQLParser/JSqlParser/pull/1794#issuecomment-5207687883.
 
cid:jira-generated-image-avatar-605065c2-da3d-4ed9-93fb-a289b690f1d8 Thomas Mortagne on 06/Aug/26 19:09
 
There is unfortunately a serious regression introduce introduced in 4.8, see https://github.com/JSQLParser/JSqlParser/pull/1794#issuecomment-5207687883.
 
cid:jira-generated-image-avatar-605065c2-da3d-4ed9-93fb-a289b690f1d8 Thomas Mortagne on 06/Aug/26 19:11
 
There is unfortunately a serious regression introduced in 4.8, see https://github.com/JSQLParser/JSqlParser/pull/1794#issuecomment-5207687883.

For next time (if that regression is indeed fixed):
bq. f3f9259ef52 still holds the complete 4.6→5.3 API migration for when you come back to this. It won't be sufficient on its own, though: 5.4-SNAPSHOT removes SimpleNode (there's a new Tree class), and StandardHQLCompleteStatementValidator.isNodeSafe() walks the AST via SimpleNode.jjtGetValue() — so that upgrade will need an extra migration step beyond what's in the reverted commit.
 
cid:jira-generated-image-avatar-605065c2-da3d-4ed9-93fb-a289b690f1d8 Thomas Mortagne on 06/Aug/26 19:11
 
There is unfortunately a serious regression introduced in 4.8, see https://github.com/JSQLParser/JSqlParser/pull/1794#issuecomment-5207687883.

For next time (if that regression is indeed fixed)
, from claude :
bq. f3f9259ef52 still holds the complete 4.6→5.3 API migration for when you come back to this. It won't be sufficient on its own, though: 5.4-SNAPSHOT removes SimpleNode (there's a new Tree class), and StandardHQLCompleteStatementValidator.isNodeSafe() walks the AST via SimpleNode.jjtGetValue() — so that upgrade will need an extra migration step beyond what's in the reverted commit.