This issue has been created
There are 2 updates.
 
 
OpenId Connect / cid:jira-generated-image-avatar-0eda952c-fa30-4a51-b304-49a64fc0c2eb OIDC-339 Open

Make the xwiki.cfg authenticator forward the calls to the OpenID Connect authenticator component

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-3d4009a6-1733-4cb3-87b1-6a818bf28d12 Thomas Mortagne created this issue on 17/Nov/26 19:52
 
Summary: Make the xwiki.cfg authenticator forward the calls to the OpenID Connect authenticator component
Issue Type: cid:jira-generated-image-avatar-0eda952c-fa30-4a51-b304-49a64fc0c2eb Improvement
Assignee: Unassigned
Components: Authenticator
Created: 17/Nov/26 19:52
Priority: cid:jira-generated-image-static-major-5c0df786-fd57-4194-bd1b-a13f77e1499a Major
Reporter: Thomas Mortagne
Description:

The authenticator configured through xwiki.authentication.authclass in xwiki.cfg (org.xwiki.contrib.oidc.auth.OIDCAuthServiceImpl) holds the implementation of the OpenID Connect authentication and gets the components it needs once, when it's created. Since XWiki keeps the same instance as long as the class itself does not change, it keeps using those component instances even when they are registered again (for example when the Extension Manager reloads extensions), and then works with disposed components (see OIDC-323).

The idea is to invert the current logic:

  • move the implementation to the oidc authenticator component (OIDCAuthService), which gets its dependencies injected
  • make OIDCAuthServiceImpl forward each call to the oidc authenticator component currently registered
 
 

2 updates

 
cid:jira-generated-image-avatar-3d4009a6-1733-4cb3-87b1-6a818bf28d12 Changes by Thomas Mortagne on 17/Nov/26 19:52
 
Fix Version: 2.30.2
Assignee: Thomas Mortagne