There is 1 comment.
 
 
XWiki Platform / cid:jira-generated-image-avatar-74fb5481-2fe4-4380-9ce3-30c4565c2fa4 XWIKI-20757 Open

CK Editor loading form element doesn't have a label
 
View issue   ·   Add comment
 

1 comment

 
cid:jira-generated-image-avatar-4d97cc67-b535-493e-a6f2-3c8719a3906f LinShaoning on 14/Jul/26 17:25
 

Hi Charpentier Lucas and Marius Dumitru Florea , I just opened the PR for XWIKI-20757: XWIKI-20757: Fix label association for Menu content field in edit mode by Derawaze · Pull Request #5842 · xwiki/xwiki-platform

Root cause: the label's for attribute points to Menu.MenuClass_0_content1, but the actual textarea DOM id is content because the WYSIWYG service ignores the id parameter and uses name instead.

Short-term fixes: removed the for attribute in MenuSheet.xml, and added a customDisplay check in ClassSheetGenerator.xml to skip generating for for custom-displayed properties.

Long-term: WYSIWYG service should respect the id parameter, and CKEditor could update labels when replacing textareas.

Local testing: I couldn't run MenuIT due to Docker-in-Docker networking issues on Windows, but both changed modules build successfully with -Pquality -DskipTests. CI should handle the integration tests.

Looking forward to your review. Thanks!biggrin.png
 
 
This message was sent by Atlassian Jira (v9.3.0#930000-sha1:287aeb6) Atlassian logo
If image attachments aren't displayed, see this article.