This issue has been created
 
 
XWiki Platform / cid:jira-generated-image-avatar-b7453571-91c6-4bf3-a427-365be39a8798 XWIKI-25763 Open

Remove the use of the color theme Velocity variables from the Invitation application

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-d9564e37-7d7c-47c7-9b87-ba223aa09e64 Charpentier Lucas created this issue on 13/Nov/26 16:04
 
Summary: Remove the use of the color theme Velocity variables from the Invitation application
Issue Type: cid:jira-generated-image-avatar-b7453571-91c6-4bf3-a427-365be39a8798 Improvement
Affects Versions: 17.10.15
Assignee: Unassigned
Components: Invitation
Created: 13/Nov/26 16:04
Priority: cid:jira-generated-image-static-major-204d9e3a-4fc6-4a54-8c50-47ab0fc01f80 Major
Reporter: Charpentier Lucas
Description:

Part of the removal of the color theme Velocity variables ($theme, loaded with colorThemeInit.vm) from the stylesheets of XWiki Standard, following XWIKI-25649. The CSS variables introduced by XWIKI-22667 expose the same colors.

The Invitation application loads colorThemeInit.vm in three places to read colors from the $theme Velocity variable:

  • The mail body templates of Invitation.InvitationCommon and Invitation.InvitationConfig, for the color of the links (linkColor) and of the decline link (notificationErrorColor). Both already define fallback values, #4791BC and #ca302c, for when $theme is empty.
  • The stylesheet of Invitation.InvitationCommon, for a border (menuSelectedEntryBackgroundColor) and a background (pageContentBackgroundColor).

We should remove every use of $theme and of colorThemeInit.vm from the application:

  • In the mail templates, use the two fallback colors directly. A mail client cannot resolve CSS variables, so fixed colors are the only option there.
  • In the stylesheet, use the CSS variables -navbar-default-link-active-bg and -xwiki-page-content-bg, and disable its Velocity parsing.

Visible change: the links of the invitation mails no longer follow the color theme of the wiki, they always use the two fixed colors.