Do you think that the external link icon inside the button will provide a nice L&F for a button? I don't think so.
Customizations on instance can decide to remove it, but I believe the information this icon brings to the user is not useless and we should by default make it clear when they click on an external link.
The solution that was used on extensions.xwiki.org was to hide it for the sake of the design, which is completely alright.
Here's a quickly put together prototype to get an idea of what it would look like with the icon in the button:
IMO the L&F is good enough and it has the advantage of not regressing feature-wise.
Styling an external link into a button is already a pretty advanced use case (on xwiki extension it's done by adding bootstrap classes on the link with XWiki Syntax), so IMO it's alright to expect the advanced user to also hide the icon if that doesn't fit their use case.
WDYT? Do you have a better idea on how to handle this? We can open a discussion about it on the forum to gather more insight on the topic too
This message was sent by Atlassian Jira (v9.3.0#930000-sha1:287aeb6)
If image attachments aren't displayed, see this article.
