This issue has been created
 
 
Document Accordion Macro / cid:jira-generated-image-avatar-2bf12625-f2c4-4f00-9072-3ac10b6611c1 DOCACCORDI-16 Open

Excluding the hidden pages compares their hidden flag with a number

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-da88fa38-8374-4d09-9e31-fcd12f3b4ae6 Thomas Mortagne created this issue on 17/Nov/26 15:11
 
Summary: Excluding the hidden pages compares their hidden flag with a number
Issue Type: cid:jira-generated-image-avatar-2bf12625-f2c4-4f00-9072-3ac10b6611c1 Bug
Affects Versions: 1.1.4
Assignee: Unassigned
Created: 17/Nov/26 15:11
Priority: cid:jira-generated-image-static-major-cb3baf92-fa40-4b14-befb-c5f36babaf57 Major
Reporter: Thomas Mortagne
Description:

DocAccordionMacro excludes the hidden pages by comparing their hidden flag with a number:

AND doc.hidden=0

Since Hibernate 6, HQL checks the types of both sides of a comparison when the query is parsed, and rejects incompatible ones (SemanticException: Cannot compare left expression of type ... with right expression of type ...). XWiki is moving to Hibernate 7 (XWIKI-19708), where these queries will fail on every database. With Hibernate 5 the literal is copied as is in the SQL, so the queries rely on the database converting it implicitly, which not all databases do.

This probably already fails on PostgreSQL, where the hidden flag is stored in a boolean column which can't be compared with an integer.

Compare it with a boolean instead (doc.hidden = false). This works with all the databases and all the Hibernate versions.