[xwiki-notifications] [xwiki/xwiki-commons] 0354b8: XCOMMONS-2276 Upgrade to HtmlCleaner 2.25

Branch: refs/heads/feature-deploy-html-cleaner-upgrade Home: https://github.com/xwiki/xwiki-commons Commit: 0354b858cc08f39b2385254b57a938c86aefb69b https://github.com/xwiki/xwiki-commons/commit/0354b858cc08f39b2385254b57a93… Author: Clemens Robbenhaar <c.robbenhaar(a)green-meadows.de> Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/pom.xml M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/DefaultHTMLCleaner.java M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276 Upgrade to HtmlCleaner 2.25 - update to the release done today - the "setRecognizeUnicodeChars" does no longer needed to be set to "false", but kept at the default value of "true" after https://sourceforge.net/p/htmlcleaner/bugs/221/ is fixed - also update the tests to reflect the current behavior; most of them are likely improvenents, but also add a few cases where this is not so clear - especially the test keeping entitiy encoded curly braces had to be disabled, as this no longer works that way Commit: 0c011bc789ebfd1644e077ace0d0a8d0756ba07e https://github.com/xwiki/xwiki-commons/commit/0c011bc789ebfd1644e077ace0d0a… Author: Clemens Robbenhaar <c.robbenhaar(a)green-meadows.de> Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/html/HTMLUtils.java Log Message: ----------- XCOMMONS-2265 HTML Encoded Line Feed character transformed in whitespace - remove the "clean double ampersand escape" workaround which is no longer necessary with HTMLCleaner 2.25 and even harmful in the use case where users want to have their amperand encoded, e.g. when displaying the encoded form in wiki pages Commit: 703ecd316f0fae357e3e01d93d8711bc6c447bd6 https://github.com/xwiki/xwiki-commons/commit/703ecd316f0fae357e3e01d93d871… Author: Clemens Robbenhaar <c.robbenhaar(a)green-meadows.de> Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/DefaultHTMLCleaner.java Log Message: ----------- XCOMMONS-2276 Upgrade to HtmlCleaner 2.25 - put back the ecplicit call to "setRecognizeUnicodeChars(true)" and add a comment why Commit: 9d6f41c4eb1e9a9e596bad940b514e1ef934efcb https://github.com/xwiki/xwiki-commons/commit/9d6f41c4eb1e9a9e596bad940b514… Author: Clemens Robbenhaar <c.robbenhaar(a)green-meadows.de> Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276 Upgrade to HtmlCleaner 2.25 - add more comments to tests to explain what they actually test and why - changed one test to use different test text to attribute values and text nodes - also fixed typos in test comments Commit: 3a48206ed534cdb6ef558cd5db31e8ca00530fbe https://github.com/xwiki/xwiki-commons/commit/3a48206ed534cdb6ef558cd5db31e… Author: Clemens Robbenhaar <c.robbenhaar(a)green-meadows.de> Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276 Upgrade to HtmlCleaner 2.25 - removed one test that only documents the behavior of the html cleaner Commit: be0d9ad13b9f2ff6e4f4b3402fc973f3f48edf0a https://github.com/xwiki/xwiki-commons/commit/be0d9ad13b9f2ff6e4f4b3402fc97… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/pom.xml M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276 Upgrade to HtmlCleaner 2.29 * Upgrade to HtmlCleaner 2.29 and update tests Commit: a4fb27764202b56ff1991ff7a169b7152c5fd178 https://github.com/xwiki/xwiki-commons/commit/a4fb27764202b56ff1991ff7a169b… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276 Upgrade to HtmlCleaner 2.29 * Clarify the test using @mflorea's comment information Commit: e21759700d321c12eef33389daab5016fd6b06b0 https://github.com/xwiki/xwiki-commons/commit/e21759700d321c12eef33389daab5… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276 Upgrade to HtmlCleaner 2.29 * Change remaining tests Commit: 0baa8497fe92fa720bbcde4e15bc9470cc3f0187 https://github.com/xwiki/xwiki-commons/commit/0baa8497fe92fa720bbcde4e15bc9… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/DefaultHTMLCleaner.java Log Message: ----------- XCOMMONS-2276: Upgrade to HtmlCleaner 2.29 * Remove unnecessary comment Commit: 50ccd16f51ddc5ba1dbf7ac77c4d073d48c41719 https://github.com/xwiki/xwiki-commons/commit/50ccd16f51ddc5ba1dbf7ac77c4d0… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/DefaultHTMLCleaner.java R xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/filter/ControlCharactersFilter.java M xwiki-commons-core/xwiki-commons-xml/src/main/resources/META-INF/components.txt M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/html/DefaultHTMLCleanerComponentList.java M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/html/HTMLUtilsTest.java M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276: Upgrade to HtmlCleaner 2.29 * Remove now unnecessary filter Commit: b16090307a1a244d01edb19fd2a1e019c0ce9516 https://github.com/xwiki/xwiki-commons/commit/b16090307a1a244d01edb19fd2a1e… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/XWikiHTML5TagProvider.java M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/HTML5HTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276: Upgrade to HtmlCleaner 2.29 * Remove now unnecessary workarounds and fix template test Co-authored-by: Michael Hamann <michael.hamann(a)xwiki.com> Commit: 839b732a7c044382fd22f797b8c3357cfbf631bb https://github.com/xwiki/xwiki-commons/commit/839b732a7c044382fd22f797b8c33… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/HTML5HTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276: Upgrade to HtmlCleaner 2.29 * Revert experiment in test Commit: d0188b732676b81af3ee317b5b1dea4e9a260db3 https://github.com/xwiki/xwiki-commons/commit/d0188b732676b81af3ee317b5b1de… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-25 (Mon, 25 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/XWikiHTML5TagProvider.java Log Message: ----------- XCOMMONS-2276: Upgrade to HtmlCleaner 2.29 * Update comments and minor style refactoring Compare: https://github.com/xwiki/xwiki-commons/compare/ac6715e4b1e7...d0188b732676 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications