[xwiki-notifications] [xwiki/xwiki-commons] 68c14a: XCOMMONS-2276: Upgrade to HtmlCleaner 2.29 (#799)

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-commons Commit: 68c14af155a3decbab6a9af71eaf3119d04c5d73 https://github.com/xwiki/xwiki-commons/commit/68c14af155a3decbab6a9af71eaf3… Author: Simon Urli <simon.urli(a)xwiki.com> Date: 2024-03-28 (Thu, 28 Mar 2024) Changed paths: M xwiki-commons-core/xwiki-commons-xml/pom.xml M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/html/HTMLUtils.java M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/DefaultHTMLCleaner.java M xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/XWikiHTML5TagProvider.java R xwiki-commons-core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/filter/ControlCharactersFilter.java M xwiki-commons-core/xwiki-commons-xml/src/main/resources/META-INF/components.txt M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/html/DefaultHTMLCleanerComponentList.java M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/html/HTMLUtilsTest.java M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/DefaultHTMLCleanerTest.java M xwiki-commons-core/xwiki-commons-xml/src/test/java/org/xwiki/xml/internal/html/HTML5HTMLCleanerTest.java Log Message: ----------- XCOMMONS-2276: Upgrade to HtmlCleaner 2.29 (#799) * XCOMMONS-2276 Upgrade to HtmlCleaner 2.25 * XCOMMONS-2265 HTML Encoded Line Feed character transformed in whitespace - update to the release done today - the "setRecognizeUnicodeChars" does no longer needed to be set to "false", but kept at the default value of "true" after https://sourceforge.net/p/htmlcleaner/bugs/221/ is fixed - also update the tests to reflect the current behavior; most of them are likely improvenents, but also add a few cases where this is not so clear - especially the test keeping entitiy encoded curly braces had to be disabled, as this no longer works that way - remove the "clean double ampersand escape" workaround which is no longer necessary with HTMLCleaner 2.25 and even harmful in the use case where users want to have their amperand encoded, e.g. when displaying the encoded form in wiki pages - put back the ecplicit call to "setRecognizeUnicodeChars(true)" and add a comment why - add more comments to tests to explain what they actually test and why - changed one test to use different test text to attribute values and text nodes - also fixed typos in test comments - removed one test that only documents the behavior of the html cleaner * Upgrade to HtmlCleaner 2.29 and update tests * Clarify the test using @mflorea's comment information * Change remaining tests * Remove unnecessary comment * Remove now unnecessary filter * Remove now unnecessary workarounds and fix template test * Revert experiment in test * Update comments and minor style refactoring --------- Co-authored-by: Clemens Robbenhaar <c.robbenhaar(a)green-meadows.de> Co-authored-by: Michael Hamann <michael.hamann(a)xwiki.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications