Upgrading the extension can bring the instance down

Issue created

Raluca Stavro created this issue on 18/Jul/25 16:41

Summary:	Upgrading the extension can bring the instance down
Issue Type:	Bug
Affects Versions:	1.23
Assignee:	Unassigned
Created:	18/Jul/25 16:41
Priority:	Critical
Reporter:	Raluca Stavro
Description:	The cause is around https://github.com/xwiki-contrib/book-versions/blob/c81acdd94aa054388e27d1e6d908e12f05406376/application-book-versions-api/src/main/java/org/xwiki/contrib/bookversions/internal/PublishBookRightInitializer.java#L89 and it is related to the fact that every `Right` has a value, and that value needs to be below `64` because of the way we store right sets. And when you unregister a right that is not the last registered right, you break that whole system. So, basically, unregistering of rights is only supported when you unregister the last registered right. Plus, the values that are associated with rights need to be continuous.

1 update

Changes by Raluca Stavro on 18/Jul/25 16:41

Assignee:

Raluca Stavro

Issue deleted

Raluca Stavro has deleted this issue on 18/Jul/25 16:46

1 comment

Raluca Stavro on 18/Jul/25 16:45

One workaround is to :

1. Not unregister the right.
2. Only register the right when it hasn't been registered yet. The actual right is not tied to the PublishBookRight instance in any way so there shouldn't be any problem that the PublishBookRight instance isn't the same anymore.

The only side effect is that uninstalling the extension won't remove the right from the UI anymore, but it will be gone after the next restart.

The only problem could be if someone wants to change any properties of the right, but even in that case it might be totally acceptable that the updated properties are only applied on the next restart.

This message was sent by Atlassian Jira (v9.3.0#930000-sha1:287aeb6)

If image attachments aren't displayed, see this article.