This issue has been created
There is 1 update.
 
 
XWiki Platform / cid:jira-generated-image-avatar-b89b3134-99c5-45cc-87a7-c6f7fa2d7fb6 XWIKI-25700 Open

Starting or stopping the edition of a Live Data cell re-renders every cell

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-1bb3563e-3f0c-463a-80d5-78e8ec93ccef Manuel Leduc created this issue on 09/Nov/26 14:55
 
Summary: Starting or stopping the edition of a Live Data cell re-renders every cell
Issue Type: cid:jira-generated-image-avatar-b89b3134-99c5-45cc-87a7-c6f7fa2d7fb6 Improvement
Affects Versions: 17.10.0
Assignee: Unassigned
Components: Live Data
Created: 09/Nov/26 14:55
Priority: cid:jira-generated-image-static-major-24180561-992c-49c0-9d97-2a4f25d46a33 Major
Reporter: Manuel Leduc
Description:

Each Live Data cell decides whether it can be edited by calling the edit bus's isEditable(), which iterates over the edit state of every cell. All cells therefore depend on the whole edit state: when one cell starts or stops being edited, every cell and its tooltip re-render, twice per edit. Each cell also registers an edit bus listener that walks the edit states again on every event.

Proposal

  • Keep a single reactive "a cell is being edited" flag in EditBusService, updated on the start, cancel and save events, and read by isEditable().
  • Remove the per-cell edit bus listeners, which become useless.

This also removes the listener leak on master (see the related issue).

 
 

1 update

 
cid:jira-generated-image-avatar-1bb3563e-3f0c-463a-80d5-78e8ec93ccef Changes by Manuel Leduc on 09/Nov/26 14:55
 
Fix Version: 18.10.0-rc-1