This issue has been created
There is 1 update.
 
 
XWiki Commons / cid:jira-generated-image-avatar-f892ed77-2d03-4368-9369-dab0039a2cbe XCOMMONS-3458 Open

HTMLCleaner should use a securely configured document builder

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-65d0c6ee-712a-4834-bdb9-12b268190149 Michael Hamann created this issue on 24/Oct/25 10:52
 
Summary: HTMLCleaner should use a securely configured document builder
Issue Type: cid:jira-generated-image-avatar-f892ed77-2d03-4368-9369-dab0039a2cbe Bug
Affects Versions: 16.10.0
Assignee: Unassigned
Components: XML
Created: 24/Oct/25 10:52
Priority: cid:jira-generated-image-static-major-50d74dda-35c3-4f68-938d-0faee2f23a61 Major
Reporter: Michael Hamann
Description:

The document builder that is used by HTMLCleaner currently isn't configured in any way. While this may be safe as we control the DTD, it would still be better to configure it directly. Further, we recently noticed in a unit test that even with a known DTD, the document builder will try downloading this DTD without further configuration. From what I understand, this shouldn't happen in the actual production code as we never parse any content with this document builder but we should better be safe and configure the document builder appropriately.

I don't expect any behavior changes from fixing this, I'm opening this issue mainly to document the change and to have something to reference in case it should turn out that I was wrong and it makes a difference.

 
 

1 update

 
cid:jira-generated-image-avatar-65d0c6ee-712a-4834-bdb9-12b268190149 Changes by Michael Hamann on 24/Oct/25 10:52
 
Assignee: Michael Hamann