I started to work on the upgrade on this branch https://github.com/xwiki/xwiki-platform/tree/XWIKI-20490 but I had to put in on hold because I discovered *3 important regressions*:
* The {{data-data}} attribute on the {{option}} element is not taken into account any more. See https://github.com/selectize/selectize.js/issues/ 2036 (and https://github.com/selectize/selectize.js/issues/ 1976 ) . We use it on the class picker for instance https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/macros.vm#L2846 .
* Any change listeners added before creating the selectize widget are lost. See https://github.com/selectize/selectize.js/issues/1969 . We rely on this here https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.js#L282 . Changing the order (i.e. adding the event listener after creating the selectize widget) fixes the problem, but I cannot expect all our extensions that use the selectize widget to update their code.
* Any custom (jQuery) data set on the select element before creating the selectize widget is lost. See https://github.com/selectize/selectize.js/issues/1958 . We rely on this here https://github.com/xwiki/xwiki-platform/blob/master/xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/uicomponents/suggest/xwiki.selectize.js#L278 . |
|
