This issue has been created
There are 2 updates, 1 comment.
 
 
XWiki Platform / cid:jira-generated-image-avatar-29668f46-2f8d-4e97-aa1b-af8e1c98665e XWIKI-25040 Open

The Share Page email templates are inconsistent between languages

 
View issue   ·   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-eb3a7af1-5ce0-41eb-9102-796d3952d76c Vincent Massol created this issue on 28/Sep/26 16:57
 
Summary: The Share Page email templates are inconsistent between languages
Issue Type: cid:jira-generated-image-avatar-29668f46-2f8d-4e97-aa1b-af8e1c98665e Bug
Affects Versions: 17.10.13
Assignee: Unassigned
Components: Share Page
Created: 28/Sep/26 16:57
Priority: cid:jira-generated-image-static-major-d6281e44-a7f4-4f5f-8576-62df2c5aff56 Major
Reporter: Vincent Massol
Description:

The "Share page by email" mail templates (XWiki.SharePage, one XWiki.Mail object per language) have drifted apart: some fixes were applied to the English version only, and the German version was never aligned with the others.

Problems

  • French and German: the "add this document to your WatchList" link is still shown when the Watchlist is disabled (XWIKI-15043 was only applied to the English template).
  • English HTML mail: the footer reads "generated by XWiki at <request server name> on behalf of <server name>" instead of "at <server name> on behalf of <user>", unlike the English plain-text mail and all the other languages. It also still uses the request server name, which can be 127.0.0.1 behind a proxy (see XWIKI-16006).
  • German:
    • every line of the plain-text mail is indented with two tabs, and the shared message is indented inside the HTML mail too;
    • the HTML mail doesn't compute the server name from the wiki home page URL as the other languages do (XWIKI-16006), and the intro sentence doesn't say on which wiki the document is;
    • uses the deprecated $context binding instead of $xcontext;
    • some grammar mistakes ("Dies Nachricht ist generiert worden", "in Ihren Browser", "in die Abonnementsliste hinzufügen").
  • French: small grammar mistakes ("à votre favoris", "Pour faire ça").

Expected

All languages render the same information with the same Velocity logic, only the text being translated.

 
 

2 updates

 
cid:jira-generated-image-avatar-eb3a7af1-5ce0-41eb-9102-796d3952d76c Changes by Vincent Massol on 28/Sep/26 16:57
 
Fix Version: 18.9.0-rc-1
Assignee: Vincent Massol
 
 

1 comment

 
cid:jira-generated-image-avatar-eb3a7af1-5ce0-41eb-9102-796d3952d76c Vincent Massol on 28/Sep/26 16:58
 

See also https://forum.xwiki.org/t/xwiki-sharepage-deprecated-usage-of-getter-com-xpn-xwiki-api-deprecatedcontext-getuser/18891