Implementation details of the pull request that are not in its description:
An empty string content, as in {{box}}{{/box}}, already rendered an empty box. Only the calls without any content, such as {{box/}} or {{info/}}, rendered nothing.
The generic mandatory-content error of AbstractBoxMacro is unchanged and still covered by macrobox9.test. Keeping the fix out of AbstractBoxMacro also preserves the behaviour of contrib macros that may rely on a missing content rendering nothing.
Nothing in xwiki-platform needs updating: no page or test calls these macros without content, and the "The required content is missing." message is not used there. The Edit Macro dialog reads the mandatory flag from the macro descriptor. The CKEditor quick actions of the message macros insert a default text, and the content of the box macro was already optional.
Behaviour change: a literally empty {{error/}} now renders an empty error box instead of the error message. A script-generated content, such as {{error}}$message{{/error}}, is not affected.
Implementation details of the pull request that are not in its description: * An empty string content, as in {{{{box}}{{/box}}}}, already rendered an empty box. Only the calls without any content, such as {{{{box/}}}} or {{{{info/}}}}, rendered nothing. * The generic mandatory-content error of {{AbstractBoxMacro}} is unchanged and still covered by {{macrobox9.test}}. Keeping the The fix out of in {{AbstractBoxMacro}} also preserves the behaviour of contrib macros applies to its subclasses that may rely keep {{isContentChecked()}} true: {{CodeMacro}} in xwiki-platform sets it to false, and {{RssMacro}} in xwiki-contrib, the only other subclass found on GitHub, already passes an empty string for a missing content rendering nothing. * Nothing in xwiki-platform needs updating: no page or test calls these macros without content, and the "The required content is missing." message is not used there. The Edit Macro dialog reads the mandatory flag from the macro descriptor. The CKEditor quick actions of the message macros insert a default text, and the content of the box macro was already optional. * Behaviour change: a literally empty {{{{error/}}}} now renders an empty error box instead of the error message. A script-generated content, such as {{{{error}}$message{{/error}}}}, is not affected.
This message was sent by Atlassian Jira (v9.3.0#930000-sha1:287aeb6)
If image attachments aren't displayed, see this article.