This issue has been created
There is 1 update.
 
 
Kubernetes Helm Charts for XWiki / cid:jira-generated-image-avatar-c9ed3f23-a29b-45d2-9659-70e840e93265 HELM-127 Open

Hardcoded image for curl in solr initContainer

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-98f00318-cae5-4562-ae2d-1fbaa0afda73 Feathers Mcgraw created this issue on 13/Oct/26 16:26
 
Summary: Hardcoded image for curl in solr initContainer
Issue Type: cid:jira-generated-image-avatar-c9ed3f23-a29b-45d2-9659-70e840e93265 Improvement
Affects Versions: 1.7.3
Assignee: Unassigned
Created: 13/Oct/26 16:26
Priority: cid:jira-generated-image-static-minor-faf781fb-8722-43c3-82ff-b6b8b89d7993 Minor
Reporter: Feathers Mcgraw
Description:

Hi, I am setting up XWiki in an Openshift environment with internet restrictions, pulling images through our internal registry.

In templates/solr-statefulset.yaml, the download-cores init container uses a hardcoded image:

    spec:
      {{- if .Values.solr.downloadCores.enabled }}
      initContainers:
        - name: download-cores
          image: curlimages/curl
          env:
          {{- range .Values.solr.extraEnvVars }}
            - name: {{ .name  }}
              value: {{ .value | quote }}
          {{- end }}
          command: ['/bin/sh', '-c']

This hard coding of curlimages/curl will directly reference to docker.io.

Perhaps this would be a better solution in templates/solr-statefulset.yaml

{{}}

        - name: download-cores
          image: {{ .Values.solr.downloadCores.image | quote }}

defaulting with:{}

 

solr:
  downloadCores:
    enabled: true
    image: "curlimages/curl:latest" 

It would also be an improvement for on premise installations with internet restrictions to allow the 2 variables: SOLR_CORE_URL and SOLR_MINIMAL_CORE_URL be overwritable via an internal maven repository

Thanks!

 

 
 

1 update

 
cid:jira-generated-image-avatar-98f00318-cae5-4562-ae2d-1fbaa0afda73 Changes by Feathers Mcgraw on 13/Oct/26 16:33
 
Description: Hi, I am setting up XWiki in an Openshift environment with internet restrictions, pulling images through our internal registry.

In {{{}templates/solr-statefulset.yaml{}}}, the {{download-cores}} init container uses a hardcoded image:
{code:java}
    spec:
      {{- if .Values.solr.downloadCores.enabled }}
      initContainers:
        - name: download-cores
          image: curlimages/curl
          env:
          {{- range .Values.solr.extraEnvVars }}
            - name: {{ .name  }}
              value: {{ .value | quote }}
          {{- end }}
          command: ['/bin/sh', '-c']{code}
This hard coding of curlimages/curl will directly reference to docker.io.

Perhaps this would be a better solution in templates/solr-statefulset.yaml

{ {}}
{
code:java}
        - name: download-cores
          image: {{ .Values.solr.downloadCores.image | quote }}{code}
defaulting with:
{{{}{}}}

 
{code:java}
solr:
  downloadCores:
    enabled: true
    image: "curlimages/curl:latest" {code}
It would also be an improvement for on premise installations with internet restrictions to allow the 2 variables: SOLR_CORE_URL and SOLR_MINIMAL_CORE_URL be
overwritable configurable via an internal maven repository values

Thanks!