17 Oct
2025
17 Oct
'25
4:35 p.m.
Branch: refs/heads/XWIKI-2470
Home: https://github.com/xwiki/xwiki-platform
Commit: d2bf06b4961611a1bb2176def44abb346ad8d712
https://github.com/xwiki/xwiki-platform/commit/d2bf06b4961611a1bb2176def44a…
Author: Marius Dumitru Florea <marius(a)xwiki.com>
Date: 2025-10-17 (Fri, 17 Oct 2025)
Changed paths:
M
xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/SaveAction.java
M
xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/SaveAndContinueAction.java
M
xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/web/SaveActionTest.java
R
xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-test-pageobjects/src/main/java/org/xwiki/realtime/test/po/Coeditor.java
A
xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-test-pageobjects/src/main/java/org/xwiki/realtime/test/po/CoeditorElement.java
M
xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-test-pageobjects/src/main/java/org/xwiki/realtime/test/po/CoeditorsDropdown.java
A
xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-test-pageobjects/src/main/java/org/xwiki/realtime/test/po/HistoryDropdown.java
M
xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-test-pageobjects/src/main/java/org/xwiki/realtime/test/po/RealtimeEditToolbar.java
M
xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-test-pageobjects/src/main/java/org/xwiki/realtime/test/po/SummaryModal.java
A
xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-test-pageobjects/src/main/java/org/xwiki/realtime/test/po/VersionElement.java
M
xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-ui/src/main/resources/XWiki/Realtime/Configuration.xml
M
xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-webjar/src/main/webjar/saver.js
M
xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-webjar/src/main/webjar/toolbar.js
M
xwiki-platform-core/xwiki-platform-realtime/xwiki-platform-realtime-wysiwyg/xwiki-platform-realtime-wysiwyg-test/xwiki-platform-realtime-wysiwyg-test-docker/src/test/it/org/xwiki/realtime/wysiwyg/test/ui/RealtimeWYSIWYGEditorIT.java
M
xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/js/xwiki/actionbuttons/actionButtons.js
Log Message:
-----------
XWIKI-2470: Improve saving to not save data that has not changed
* Remove duplicated code between SaveAction and SaveAndContinueAction that builds the JSON
response. Put the "JSON" map object on the XWiki context and let various parts
of the code add stuff that needs to be returned to the editor.
* Remove the redirect object before updating the authors, in order to be able to detect if
the document is dirty before the authors are set.
* Move the line that sets the metadata dirty right before saving, because it is needed
only to force incrementing the version.
* Small code improvements and more comments added.
* Let the editor know when the save doesn't create a new revision in order to not show
the "Saved" notification because it can mislead the user into thinking that a
new version was created.
* Add page objects for the history dropdown from the realtime toolbar.
* Add functional test.
* Don't propagate the version on save (to the other collaborators) if there's no
new version.
* Bulletproof the history dropdown to not duplicate versions.
To unsubscribe from these emails, change your notification settings at
https://github.com/xwiki/xwiki-platform/settings/notifications