There are 5 updates, 1 comment.
 
 
Release Notes Application / cid:jira-generated-image-avatar-21549510-572c-4ce2-8da0-bd35ae472c69 RN-110 Closed

The 1.x migration can be run by any user who can view its page

 
View issue   ยท   Add comment
 

5 updates

 
cid:jira-generated-image-avatar-e8534c1c-758c-4040-9972-7fcda3c9c01b Changes by Vincent Massol on 05/Sep/26 22:12
 
Documentation in Release Notes: N/A
Documentation: N/A
Resolution: Fixed
Tests: Unit
Status: Open Closed
 
 

1 comment

 
cid:jira-generated-image-avatar-e8534c1c-758c-4040-9972-7fcda3c9c01b Vincent Massol on 05/Sep/26 22:04
 

The fix now also enforces wiki_admin as a required right on the migration page, on top of the right check in its content.

The check alone lives in the page content, so it lasts only as long as nobody rewrites that content. Measured on XWiki 17.10.9 with a user holding wiki-level edit + script but not admin:

required rights on the page can that user edit it, i.e. delete the check?
enforce + level wiki_admin no - HTTP 401, "Access denied in edit mode on document xwiki:ReleaseNotes.Code.MigrationFrom1x"
enforce + level script yes
none yes

Without it, that user could remove the check and run the migration - in the measurement two fixture documents were irreversibly converted to the 2.x format. Enforcement denies edit on the document itself rather than only limiting what the script may do, which is what makes it a boundary. Level script is not sufficient; only wiki_admin matches what the check tests for.

The administrator path is unchanged: with enforcement on, the page still lists the pending documents and still offers Start Migration, so wiki_admin alone is enough to execute the Velocity.

Required rights are available since 16.10.0RC1, below this extension's 17.10 minimum, and the same pattern is used by xwiki-platform-annotation-ui.