This issue has been created
There is 1 update.
 
 
XWiki Platform / cid:jira-generated-image-avatar-1ab428c0-6abb-43ee-ad54-03672f6257e8 XWIKI-24691 Open

Flamingo skin uses jQuery UI without dependency or path declaration

 
View issue   ·   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-8c297971-b052-47d9-87c9-5ff034fb2f0e Michael Hamann created this issue on 12/Aug/26 17:48
 
Summary: Flamingo skin uses jQuery UI without dependency or path declaration
Issue Type: cid:jira-generated-image-avatar-1ab428c0-6abb-43ee-ad54-03672f6257e8 Bug
Affects Versions: 17.3.0-rc-1
Assignee: Unassigned
Components: Flamingo Skin
Created: 12/Aug/26 17:48
Priority: cid:jira-generated-image-static-major-4d6fa856-9051-4918-a825-64fc52080f1f Major
Reporter: Michael Hamann
Description:

This issue cannot be reproduced in a regular XWiki instance but on an integration test instance, e.g., for xwiki-platform-notifications-test-docker and xwiki-platform-xclass-test-docker that doesn't include the Panel UI extension, an error like

Loading failed for the <script> with source “http://localhost:8080/xwiki/bin/view/Main/jquery-ui.js 

or also

Uncaught Error: Script error for "jquery-ui"
  https://requirejs.org/docs/errors.html#scripterror
      makeError require.min.js:5
      onScriptError require.min.js:5
      load require.min.js:5
      load require.min.js:5
      load require.min.js:5
      fetch require.min.js:5
      check require.min.js:5
      enable require.min.js:5
      enable require.min.js:5
      enable require.min.js:5
      bind require.min.js:5
      each require.min.js:5
      enable require.min.js:5
      init require.min.js:5
      s require.min.js:5
      setTimeout handler*req.nextTick< require.min.js:5
      s require.min.js:5
      requirejs require.min.js:5
      <anonymous> flamingo.js:128 

is shown. This also causes test failures, e.g., of org.xwiki.platform.notifications.test.ui.AllIT$NestedNotificationsIT#notificationDisplayerClass, in particular with Firefox 153 as there is a race between dataeditors.js and flamingo.js, while the former correctly declares the path, the latter doesn't and thus causes a load failure for jQuery which is persisted and then makes the object editor fail to load.

 
 

1 update

 
cid:jira-generated-image-avatar-8c297971-b052-47d9-87c9-5ff034fb2f0e Changes by Michael Hamann on 12/Aug/26 17:49
 
Description: This issue cannot be reproduced in a regular XWiki instance but on an integration test instance, e.g., for xwiki-platform-notifications-test-docker and xwiki-platform-xclass-test-docker that doesn't include the Panel UI extension, an error like
{noformat}
Loading failed for the <script> with source “http://localhost:8080/xwiki/bin/view/Main/jquery-ui.js {noformat}
or also
{noformat}
Uncaught Error: Script error for "jquery-ui"
  https://requirejs.org/docs/errors.html#scripterror
      makeError require.min.js:5
      onScriptError require.min.js:5
      load require.min.js:5
      load require.min.js:5
      load require.min.js:5
      fetch require.min.js:5
      check require.min.js:5
      enable require.min.js:5
      enable require.min.js:5
      enable require.min.js:5
      bind require.min.js:5
      each require.min.js:5
      enable require.min.js:5
      init require.min.js:5
      s require.min.js:5
      setTimeout handler*req.nextTick< require.min.js:5
      s require.min.js:5
      requirejs require.min.js:5
      <anonymous> flamingo.js:128 {noformat}
is shown. This also causes test failures, e.g., of {{org.xwiki.platform.notifications.test.ui.AllIT$NestedNotificationsIT#notificationDisplayerClass}}, in particular with Firefox 153 as there is a race between dataeditors.js and flamingo.js, while the former correctly declares the path, the latter doesn't and thus causes a load failure for jQuery which is persisted and then makes the object editor fail to load.


This issue is solved by XWIKI-23979 for XWiki versions starting with 18.2.0RC1, this issue is only about backporting the changes that are independent of the jQuery upgrade to 17.10.x.