This issue has been created
There is 1 update.
 
 
XWiki Platform / cid:jira-generated-image-avatar-4130968c-8355-4c02-a3f9-2eabd53a6928 XWIKI-25177 Open

Modal titles no longer use a heading font size

 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-6c29d033-a726-4bb9-9a31-67d2fee58d2a Charpentier Lucas created this issue on 05/Oct/26 17:17
 
Summary: Modal titles no longer use a heading font size
Issue Type: cid:jira-generated-image-avatar-4130968c-8355-4c02-a3f9-2eabd53a6928 Improvement
Affects Versions: 15.9
Assignee: Unassigned
Components: Flamingo Skin
Created: 05/Oct/26 17:17
Priority: cid:jira-generated-image-static-major-868216c8-3722-4e38-b4f0-1616805e81e0 Major
Reporter: Charpentier Lucas
Description:

Since XWIKI-15726, modal titles are div}}s styled with a fixed {{font-size so that they don't break the headings hierarchy. That size was picked to match the H4 size of the time, around 20px.

XWIKI-21333 later changed the heading sizes and made them fluid with the window width, but the modal title size stayed fixed. Modal titles now render at about 20px while H4 is about 16-17px, so they don't match any heading size anymore.

Possible ways to make them consistent again:

  • use the H3 size, which reaches about 20px on a wide window, so the change would be barely visible
  • use the H4 size, which would make every modal title visibly smaller
  • keep a dedicated size and document it as a design decision

This came up in the review of https://github.com/xwiki/xwiki-platform/pull/6598#discussion_r4185225108. A forum proposal will settle which option to choose.

 
 

1 update

 
cid:jira-generated-image-avatar-6c29d033-a726-4bb9-9a31-67d2fee58d2a Changes by Charpentier Lucas on 05/Oct/26 17:19
 
Description: Since XWIKI-15726, modal titles are {{ div}}s divs styled with a fixed {{ font-size}} so that they don't break the headings hierarchy. That size was picked to match the H4 size of the time, around 20px.

XWIKI-21333 later changed the heading sizes and made them fluid with the window width, but the modal title size stayed fixed. Modal titles now render at about 20px while H4 is about 16-17px, so they don't match any heading size anymore.

Possible ways to make them consistent again:
* use the H3 size, which reaches about 20px on a wide window, so the change would be barely visible
* use the H4 size, which would make every modal title visibly smaller
* keep a dedicated size and document it as a design decision

This came up in the review of
[ https://github.com/xwiki/xwiki-platform/pull/6598#discussion_r4185225108 ] . A forum proposal will settle which option to choose.