|
| Description: |
Several queries compare integer properties with a string ({{Code.InvoicesResults}}, {{Code.NewsletterSheet}}, {{Code.SendNewsletterInstances}}) and date properties with an empty string ({{Code.NewsletterLiveTableResultsMacros}}, {{Code.NewsletterSheet}}):
{noformat} published.value='1' active.value='1' invoiceDate.value<>'' unsubDate.value<>'' {noformat}
Since Hibernate 6, HQL checks the types of both sides of a comparison when the query is parsed, and rejects incompatible ones ({{SemanticException: Cannot compare left expression of type ... with right expression of type ...}}). XWiki is moving to Hibernate 7 (XWIKI-19708), where these queries will fail on every database. With Hibernate 5 the literal is copied as is in the SQL, so the queries rely on the database converting it implicitly, which not all databases do.
Comparing a date with an empty string already fails on PostgreSQL, and never matches on Oracle (where an empty string is {{NULL}}).
Compare the integer properties with numbers ({{published.value = 1}}) and check that the date properties are set with {{is not null}}. This works with all the databases and all the Hibernate versions.
PS: This post was co-written with Claude Code. |
|