There are 4 updates, 2 comments.
 
 
XWiki Commons / cid:jira-generated-image-avatar-c94c7b97-e9dd-43a7-8f26-58919626f78c XCOMMONS-2184 Open

Removing a table row leads to a hard to understand HTML diff

 
View issue   ยท   Add comment
 

4 updates

 
cid:jira-generated-image-avatar-c631b819-f399-45e8-a802-dbbeb08e04dc Changes by Charpentier Lucas on 05/Dec/24 15:02
 
Attachment: screenshot-1.png
Attachment: Screenshot from 2024-12-05 15-03-38.png
Attachment: Screenshot from 2024-12-05 15-06-16.png
Attachment: Screenshot from 2024-12-05 15-07-08.png
 
 

2 comments

 
cid:jira-generated-image-avatar-c631b819-f399-45e8-a802-dbbeb08e04dc Charpentier Lucas on 05/Dec/24 15:09
 

This only happens in the Rendered view (in 17.0.0, this is not the default one).

_thumb_42996.png
_thumb_42997.png

Note that this only happens when the content of the two rows is very similar.

_thumb_42995.png
_thumb_42998.png

___
My guess is that in the case those are very similar, the diff evaluator for rendered content understands the change as : small modification of the first line (edit = remove old + add new) and removal of second line. Somehow, with the same example, the diff evaluator for Raw content is okay.

 
cid:jira-generated-image-avatar-c631b819-f399-45e8-a802-dbbeb08e04dc Charpentier Lucas on 05/Dec/24 15:11
 
This only happens in the Rendered view (in 17.0.0, this is not the default one).

!Screenshot from 2024-12-05 15-03-38.png|thumbnail!
!Screenshot from 2024-12-05 15-06-16.png|thumbnail!

Note that this only happens when the content of the two rows is very similar.

!screenshot-1.png|thumbnail!
!Screenshot from 2024-12-05 15-07-08.png|thumbnail!

___
My guess is that in the case those are very similar, the diff evaluator for rendered content understands the change as : small modification of the first line (edit = remove old + add new) and removal of second line. Somehow, with the same example, the diff evaluator for Raw content is okay.


___
I doubt this is much of an issue (I have similar experiences with Github or Intellij Idea diff highlights), and it's probably quite complicated to fix it without breaking something else. I'm in favor of closing it as a `Won't fix`.