There are 2 updates, 5 comments.
 
 
XWiki Platform / cid:jira-generated-image-avatar-46d1295b-680b-40a3-93de-3574cb65f682 XWIKI-22715 Open

Include and Display macros shouldn't duplicate the content of multiline content when used inline

 
View issue   ยท   Add comment
 

2 updates

 
cid:jira-generated-image-avatar-d37eb32e-6ec5-4348-92d0-6f252d657b99 Changes by Thomas Mortagne on 05/Dec/24 14:46
 
Component: WYSIWYG Editor
Component: Rendering - Include Macro
 
 

5 comments

 
cid:jira-generated-image-avatar-6d00303d-1d93-41c5-9806-62b4c6052a4e Vincent Massol on 05/Dec/24 14:43
 

Seems related to XWIKI-21125 (could maybe even be caused by it?).

 
cid:jira-generated-image-avatar-d37eb32e-6ec5-4348-92d0-6f252d657b99 Thomas Mortagne on 05/Dec/24 14:45
 

This does not have much to do with the include macro. The WYSIWYG is just quite unpredictable when you give it invalid HTML (like standalone content instead of paragraph).

 
cid:jira-generated-image-avatar-d37eb32e-6ec5-4348-92d0-6f252d657b99 Thomas Mortagne on 05/Dec/24 14:46
 

Seems related to XWIKI-21125 (could maybe even be caused by it?).

XWIKI-21125 tries to improve the situation, but it only helps when the included content is a single paragraph.

 
cid:jira-generated-image-avatar-d37eb32e-6ec5-4348-92d0-6f252d657b99 Thomas Mortagne on 05/Dec/24 14:47
 
This The behavior does not have much to do with the include macro. The WYSIWYG is just quite unpredictable when you give it invalid HTML (like standalone content instead of paragraph).

All the macro could do is produce an error if it cannot convert the included content to inline content.
 
cid:jira-generated-image-avatar-d37eb32e-6ec5-4348-92d0-6f252d657b99 Thomas Mortagne on 05/Dec/24 14:47
 
The behavior does not have much to do with the include macro. The WYSIWYG is just quite unpredictable when you give it invalid HTML (like standalone content instead of paragraph).

All the macro could do is produce an error if it cannot convert the included content to inline content
(like the HTML macro does) . But I'm afraid this could be seen as quite a regression, since it usually works fine (if you don't try to edit this with the WYSIWYG).