There are 2 comments.
 
 
XWiki Platform / cid:jira-generated-image-avatar-a3c26067-c7c2-467b-8709-e7affd3e2457 XWIKI-24546 Reopened

Images inserted by uploading in Annotations become broken after save

 
View issue   ·   Add comment
 

2 comments

 
cid:jira-generated-image-avatar-21189acf-7c2c-4252-83e4-b61c5909aa67 Vincent Massol on 09/Jul/26 12:41
 
  XWIKI‑24174 was backported to every maintained stable branch. Earliest released tag containing it:                                                                                                                                                                                                                        
                                                                                                                                                                                                                                                                                                                            
  ┌────────────────┬─────────────────┬────────────────────────────────┐                                                                                                                                                                                                                                                     
  │     Branch     │ Backport commit │       First released in        │                                                                                                                                                                                                                                                     
  ├────────────────┼─────────────────┼────────────────────────────────┤                                                                                                                                                                                                                                                     
  │ stable‑16.10.x │ f33a3373ada     │ 16.10.18 (2026‑06‑18)          │                                                                                                                                                                                                                                                     
  ├────────────────┼─────────────────┼────────────────────────────────┤                                                                                                                                                                                                                                                     
  │ stable‑17.10.x │ 28492cc00a7     │ not yet released (branch only) │                                                                                                                                                                                                                                                     
  ├────────────────┼─────────────────┼────────────────────────────────┤                                                                                                                                                                                                                                                     
  │ stable‑18.4.x  │ b34a9ff120a     │ 18.4.2                         │                                                                                                                                                                                                                                                     
  ├────────────────┼─────────────────┼────────────────────────────────┤                                                                                                                                                                                                                                                     
  │ stable‑18.5.x  │ ae02285c25b     │ 18.5.0                         │                                                                                                                                                                                                                                                     
  ├────────────────┼─────────────────┼────────────────────────────────┤                                                                                                                                                                                                                                                     
  │ master         │ 1ff1ad666c3     │ 18.6.0                         │                                                                                                                                                                                                                                                     
  └────────────────┴─────────────────┴────────────────────────────────┘       

Also:

The comment story is fully explained by XWIKI‑24174 (high confidence). For annotation, one data point doesn't fit a single-cause theory: the original reporter said annotation was already broken on 17.10.9 and 18.4.1, both of which predate the XWIKI‑24174 release on their branches. If that report is accurate,
annotation likely also has an older, independent problem — most plausibly the pre-existing save-side handling from XWIKI‑18989 (old REST code attached temp files to a separately-fetched document instance, not the one the annotation save persists), which is exactly what the merged d98e8a1557e corrected. That would
make annotation a two-bug situation (old save-side + new XWIKI‑24174 upload-side), whereas comment is purely XWIKI‑24174. Pinning the older annotation cause to an exact commit would need a runtime bisect on a pre‑24174 build — I can do that if useful.

 
cid:jira-generated-image-avatar-21189acf-7c2c-4252-83e4-b61c5909aa67 Vincent Massol on 09/Jul/26 12:42
 
Cause of the regression: XWIKI‑24174

Details:

{noformat}
  XWIKI‑24174 was backported to every maintained stable branch. Earliest released tag containing it:                    
                    
  ┌────────────────┬─────────────────┬────────────────────────────────┐                    
  │     Branch     │ Backport commit │       First released in        │                    
  ├────────────────┼─────────────────┼────────────────────────────────┤                    
  │ stable‑16.10.x │ f33a3373ada     │ 16.10.18 (2026‑06‑18)          │                    
  ├────────────────┼─────────────────┼────────────────────────────────┤                    
  │ stable‑17.10.x │ 28492cc00a7     │ not yet released (branch only) │                    
  ├────────────────┼─────────────────┼────────────────────────────────┤                    
  │ stable‑18.4.x  │ b34a9ff120a     │ 18.4.2                     │                    
  ├────────────────┼─────────────────┼────────────────────────────────┤                    
  │ stable‑18.5.x  │ ae02285c25b     │ 18.5.0                     │                    
  ├────────────────┼─────────────────┼────────────────────────────────┤                    
  │ master         │ 1ff1ad666c3     │ 18.6.0                     │                    
  └────────────────┴─────────────────┴────────────────────────────────┘       
{noformat}

Also:

{quote}
The comment story is fully explained by XWIKI‑24174 (high confidence). For annotation, one data point doesn't fit a single-cause theory: the original reporter said annotation was already broken on 17.10.9 and 18.4.1, both of which predate the XWIKI‑24174 release on their branches. If that report is accurate,
annotation likely also has an older, independent problem — most plausibly the pre-existing save-side handling from XWIKI‑18989 (old REST code attached temp files to a separately-fetched document instance, not the one the annotation save persists), which is exactly what the merged d98e8a1557e corrected. That would
make annotation a two-bug situation (old save-side + new XWIKI‑24174 upload-side), whereas comment is purely XWIKI‑24174. Pinning the older annotation cause to an exact commit would need a runtime bisect on a pre‑24174 build — I can do that if useful.
{quote}