This issue has been created
There is 1 update.
 
 
XWiki Platform / cid:jira-generated-image-avatar-5303e10a-3193-4228-94bf-d32265bb738f XWIKI-23512 Open

"Minor change" checkbox and "Summarize changes" option should not be active when "Enable minor edits" is set to "No"
 
View issue   ยท   Add comment
 

Issue created

 
cid:jira-generated-image-avatar-8b3e5e92-ed23-47af-8e3b-468985e6015c Ilie Andriuta created this issue on 08/Sep/25 16:08
 
Summary: "Minor change" checkbox and "Summarize changes" option should not be active when "Enable minor edits" is set to "No"
Issue Type: cid:jira-generated-image-avatar-5303e10a-3193-4228-94bf-d32265bb738f Bug
Affects Versions: 16.10.11, 17.4.2
Assignee: Unassigned
Attachments: Minor_Edit_Set_to_No_Summarize_Changes.png, Minor_Edit_Set_to_No_Summarize_and_Done.png
Components: CKEditor, Realtime
Created: 08/Sep/25 16:08
Environment: Windows 11 Pro, Firefox 142, using an instance of XWiki 17.4.4 on PostgreSQL 17, Tomcat 11.0.10, reproducible also on Jetty/HSQL
Priority: cid:jira-generated-image-static-major-3a71ccec-8d7b-4bd1-9af2-cb420c99c85c Major
Reporter: Ilie Andriuta
Description:

Steps to reproduce

  1. Login as Admin
  2. Go to Administer Wiki > Editing > Edit Mode
  3. Set "Enable minor edits" to "No" and Save
  4. Go to a page (e.g. Sandbox)
  5. Click "Edit" button
  6. Make a change in the page content
  7. Click the drop-down arrow in the right of the 'Done' button
  8. Click "Summarize & Done"
  9. Observe the state of the "Minor change" checkbox
  10. Click on "Recent versions" button from the right side of the toolbar
  11. Observe the stat of the "Summarize changes" option

Expected results

Step 10: Since "Enable minor edits" from Administration is set to "No", the "Minor change" checkbox is not active (cannot be ticked).

Step 17: Also, the "Summarize changes" option from the "Recent versions" button on the right side of the toolbar is not active either, since it saves the changes as minor versions.

Actual results

The "Minor change" checkbox is active and so is the "Summarize changes" option from the "Recent versions" button on the right side of the toolbar.

If the "Minor change" checkbox is ticked and a brief description of the changes is inserted, then "Done" button is clicked, the page is not saved and the following error is displayed in JS console:

Uncaught (in promise) TypeError: can't access property "checked", this._oldToolbar.querySelector(...) is null
    _saveChangeSummary toolbar.js:204
    _createChangeSummaryModal toolbar.js:137
    jQuery 6
toolbar.js:204:52
    _saveChangeSummary toolbar.js:204
    _createChangeSummaryModal toolbar.js:137
    jQuery 10
    _createChangeSummaryModal toolbar.js:135
    r toolbar.js:54
    _createToolbar wysiwygEditor.js:192
    _startRealtimeSync wysiwygEditor.js:118
    n wysiwygEditor.js:82
    d plugin.js:297
    m plugin.js:311
    execCb require.min.js:5
    check require.min.js:5
    enable require.min.js:5
    bind require.min.js:5
    emit require.min.js:5
    each require.min.js:5
    emit require.min.js:5
    check require.min.js:5
    enable require.min.js:5
    bind require.min.js:5
    emit require.min.js:5
    each require.min.js:5
    emit require.min.js:5
    check require.min.js:5
    enable require.min.js:5
    bind require.min.js:5
    emit require.min.js:5
    each require.min.js:5
    emit require.min.js:5
    check require.min.js:5
    enable require.min.js:5
    init require.min.js:5
    a require.min.js:5
    completeLoad require.min.js:5
    onScriptLoad require.min.js:5
    (Async: EventListener.handleEvent)
    load require.min.js:5
    load require.min.js:5
    load require.min.js:5
    fetch require.min.js:5
    check require.min.js:5
    enable require.min.js:5
    enable require.min.js:5
    enable require.min.js:5
    bind require.min.js:5
    each require.min.js:5
    enable require.min.js:5
    enable require.min.js:5
    enable require.min.js:5
    bind require.min.js:5
    each require.min.js:5
    enable require.min.js:5
    enable require.min.js:5
    enable require.min.js:5
    bind require.min.js:5
    each require.min.js:5
    enable require.min.js:5
    init require.min.js:5
    s require.min.js:5
    (Async: setTimeout handler)
    nextTick require.min.js:5
    s require.min.js:5
    requirejs require.min.js:5
    d plugin.js:296
    d plugin.js:295
    InterpretGeneratorResume self-hosted:1332
    AsyncFunctionNext self-hosted:800
    (Async: async)
    init plugin.js:69
    m plugin.js:311
    execCb require.min.js:5
    check require.min.js:5
    enable require.min.js:5
    bind require.min.js:5
    emit require.min.js:5
    each require.min.js:5
    emit require.min.js:5
    check require.min.js:5
    enable require.min.js:5
    bind require.min.js:5
    emit require.min.js:5
    each require.min.js:5
    emit require.min.js:5
    check require.min.js:5
    enable require.min.js:5
    init require.min.js:5
    o require.min.js:5
    bind require.min.js:5
    load l10n.js:74
    (Async: promise callback)
    load l10n.js:72
    execCb require.min.js:5
    check require.min.js:5
    enable require.min.js:5
    bind require.min.js:5
    emit require.min.js:5
    each require.min.js:5
    emit require.min.js:5
    check require.min.js:5

The same error is encountered if the "Summarize changes" option is clicked, a brief text is inserted and then the "Save" button is clicked.
 
 

1 update

 
cid:jira-generated-image-avatar-8b3e5e92-ed23-47af-8e3b-468985e6015c Changes by Ilie Andriuta on 08/Sep/25 16:11
 
Labels: usability
 
 
This message was sent by Atlassian Jira (v9.3.0#930000-sha1:287aeb6) Atlassian logo
If image attachments aren't displayed, see this article.