There is 1 comment.
 
 
XWiki Platform / cid:jira-generated-image-avatar-c5a23e52-af59-411b-a19e-cc98fa2b4a04 XWIKI-24683 Closed

Factorize the duplicated user-with-avatar display macro in likers.vm and getusers.vm

 
View issue   ยท   Add comment
 

1 comment

 
cid:jira-generated-image-avatar-5faa881d-a30c-41aa-96f8-0e0ceddbbf69 Charpentier Lucas on 05/Nov/26 12:16
 

The first commit introduced a regression: the Administration users list and the likers list showed the user's full name instead of the username, because displayUser renders the full name while the removed local macros rendered the username. Besides being a visible change, it broke the User column, whose filter and default sort work on the page name (filtering on "John" returned nothing, filtering on "editUser" returned a row reading "John"). It also made UserEditIT#editUser fail intermittently on master.

Fixed in https://github.com/xwiki/xwiki-platform/pull/7336 (commit 30433f5820d773a457192efe57696f54ce66e486):

  • Added an aliasAsName option to the displayUser macro, used by _displayUserAliasWithAvatar so both lists show the username again.
  • Made UserEditIT#editUser reload the users list before looking up the edited user, so it now fails every time without the fix instead of only when the Live Data had already refreshed.